db-migration #10

Merged
hsh-michaelhoennig merged 74 commits from db-migration into master 2024-01-23 15:11:24 +01:00
No description provided.
hsh-michaelhoennig added 51 commits 2024-01-18 15:53:37 +01:00
1f278819c3 HSDB Dump Script
Script that is a able to dump HSDB (legacy) data to csv files.
Dump of "office" module data already implemented.
ab281c93a7 Merge pull request 'HSDB Dump Script' (#9) from hsh-michaelhierweck-hsdb-dump-script into db-migration
Reviewed-on: #9
Reviewed-by: Michael Hoennig <michael.hoennig@hostsharing.net>
hsh-michaelhoennig reviewed 2024-01-19 09:30:28 +01:00
.aliases Outdated
@ -42,0 +58,4 @@
./gradlew importOfficeData
}
alias import-office-data=importOfficeData
Author
Member

rename: gw-importOfficeData

rename: gw-importOfficeData
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig added 1 commit 2024-01-19 12:39:11 +01:00
hsh-michaelhoennig added 2 commits 2024-01-19 13:41:05 +01:00
hsh-michaelhoennig added 1 commit 2024-01-19 13:55:12 +01:00
hsh-michaelhoennig added 2 commits 2024-01-19 15:53:10 +01:00
hsh-michaelhoennig force-pushed db-migration from cd34038364 to d069e87c01 2024-01-20 10:24:25 +01:00 Compare
hsh-michaelhoennig added 4 commits 2024-01-20 15:17:55 +01:00
hsh-michaelhoennig added 1 commit 2024-01-20 15:33:30 +01:00
hsh-michaelhoennig added 1 commit 2024-01-22 10:38:15 +01:00
hsh-michaelhoennig added 1 commit 2024-01-22 12:33:34 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 10:48:30 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 10:50:24 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 10:51:31 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 10:55:21 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 10:57:46 +01:00
hsh-timotheuspokorra approved these changes 2024-01-23 11:23:21 +01:00
hsh-timotheuspokorra left a comment
Member

looks good to me

looks good to me
hsh-michaelhoennig reviewed 2024-01-23 11:28:42 +01:00
hsh-michaelhoennig left a comment
Author
Member

aus dem gemeinsamen Code-Review

aus dem gemeinsamen Code-Review
@ -59,2 +60,4 @@
private Range<LocalDate> validity;
@Column(name = "membership_fee_billable")
private boolean membershipFeeBillable;
Author
Member

alle neuen Felder prüfen, ob sie im Patcher und Test berücksichtigt sind

alle neuen Felder prüfen, ob sie im Patcher und Test berücksichtigt sind
hsh-michaelhoennig marked this conversation as resolved
@ -10,3 +9,1 @@
- JOINT_AGENT # e.g. heir
- ACCOUNTING_CONTACT
- TECHNICAL_CONTACT
- REPRESENTATIVE
Author
Member

hier fehlen welche

hier fehlen welche
hsh-michaelhoennig marked this conversation as resolved
@ -21,2 +21,4 @@
liquibase:
contexts: dev
hsadminng:
Author
Member

remove, unused

remove, unused
Author
Member

fixed

fixed
hsh-michaelhoennig marked this conversation as resolved
@ -17,0 +16,4 @@
vatBusiness boolean not null,
vatReverseCharge boolean not null,
refundBankAccountUuid uuid references hs_office_bankaccount(uuid),
defaultPrefix char(3) not null
Author
Member

unique

unique
Author
Member

fixed

fixed
hsh-michaelhoennig marked this conversation as resolved
@ -186,2 +188,4 @@
partnerUuid = new.partnerUuid,
billable = new.billable,
billingContactUuid = new.billingContactUuid,
debitorNumberSuffix = new.debitorNumberSuffix,
Author
Member

add TODO: prüfen, ob wir das wollen

add TODO: prüfen, ob wir das wollen
hsh-michaelhoennig marked this conversation as resolved
@ -191,1 +195,3 @@
vatBusiness = new.vatBusiness
vatBusiness = new.vatBusiness,
vatreversecharge = new.vatreversecharge,
defaultPrefix = new.defaultPrefix
Author
Member

add TODO: prüfen, ob wir das wollen

add TODO: prüfen, ob wir das wollen
hsh-michaelhoennig marked this conversation as resolved
@ -8,14 +8,17 @@
/*
Creates a single membership test record.
*/
-- create or replace procedure createHsOfficeMembershipTestData( forPartnerTradeName varchar, forMainDebitorNumber integer )
Author
Member

remove

remove
hsh-michaelhoennig marked this conversation as resolved
@ -18,1 +15,3 @@
newMemberNumber numeric;
currentTask varchar;
idName varchar;
-- forDebitorNumberPrefix integer;
Author
Member

remove

remove
Author
Member

fixed

fixed
hsh-michaelhoennig marked this conversation as resolved
@ -26,3 +29,3 @@
join hs_office_person person on person.uuid = partner.personUuid
where person.tradeName = forPartnerTradeName into relatedPartner;
select d.* from hs_office_debitor d where d.debitorNumber = forMainDebitorNumber into relatedDebitor;
-- forDebitorNumberPrefix := forMainDebitorNumber/ 100;
Author
Member

remove

remove
hsh-michaelhoennig marked this conversation as resolved
@ -33,6 +39,7 @@ begin
raise notice '- using debitor (%): %', relatedDebitor.uuid, relatedDebitor;
insert
into hs_office_membership (uuid, partneruuid, maindebitoruuid, membernumber, validity, reasonfortermination)
-- values (uuid_generate_v4(), relatedPartner.uuid, relatedDebitor.uuid, forDebitorNumberPrefix, daterange('20221001' , null, '[]'), 'NONE');
Author
Member

remove

remove
hsh-michaelhoennig marked this conversation as resolved
@ -50,1 +56,4 @@
call createHsOfficeMembershipTestData('Third OHG', 13);
end;
-- begin
-- call createHsOfficeMembershipTestData('First GmbH', 1000100);
Author
Member

remove

remove
hsh-michaelhoennig marked this conversation as resolved
@ -100,0 +127,4 @@
HsOfficeDebitorEntity::setVatReverseCharge)
.notNullable(),
new SimpleProperty<>(
"personType",
Author
Member

copy+paste Fehler: vatBusiness

copy+paste Fehler: vatBusiness
hsh-michaelhoennig marked this conversation as resolved
@ -103,0 +134,4 @@
.notNullable(),
new SimpleProperty<>(
"personType",
HsOfficeDebitorPatchResource::setVatReverseCharge,
Author
Member

copy+paste Fehler: billable

copy+paste Fehler: billable
hsh-michaelhoennig marked this conversation as resolved
@ -294,6 +297,7 @@ class HsOfficePartnerControllerAcceptanceTest {
.contentType(ContentType.JSON)
.body("""
{
"debitorNumerPrefix": "12345",
Author
Member

typo: debitorNumberPrefix

typo: debitorNumberPrefix
hsh-michaelhoennig marked this conversation as resolved
@ -37,6 +39,14 @@ class RbacRoleControllerAcceptanceTest {
@Autowired
RbacRoleRepository rbacRoleRepository;
@Value("${HSADMINNG_POSTGRES_RESTRICTED_USERNAME}")
Author
Member

remove

remove
hsh-michaelhoennig marked this conversation as resolved
@ -42,6 +43,14 @@ class RbacUserControllerAcceptanceTest {
@Autowired
RbacUserRepository rbacUserRepository;
@Value("${HSADMINNG_POSTGRES_RESTRICTED_USERNAME}")
Author
Member

remove

remove
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig added 1 commit 2024-01-23 12:44:59 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 12:52:48 +01:00
hsh-michaelhoennig added 1 commit 2024-01-23 13:01:33 +01:00
hsh-timotheuspokorra approved these changes 2024-01-23 13:03:34 +01:00
@ -27,3 +30,3 @@
private static Stringify<HsOfficeCoopAssetsTransactionEntity> stringify = stringify(HsOfficeCoopAssetsTransactionEntity.class)
.withProp(e -> e.getMembership().getMemberNumber())
.withProp(e -> ofNullable(e.getMembership()).map(HsOfficeMembershipEntity::getMemberNumber).orElse(null))

Diese Änderung bitte auch bei CoopShares

Diese Änderung bitte auch bei CoopShares
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig added 2 commits 2024-01-23 13:30:33 +01:00
hsh-michaelhoennig merged commit fd1bd897b1 into master 2024-01-23 15:11:24 +01:00
hsh-michaelhoennig deleted branch db-migration 2024-01-23 15:11:24 +01:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hostsharing/hs.hsadmin.ng#10
No description provided.