check-domain-setup-permission #97

Merged
hsh-michaelhoennig merged 17 commits from check-domain-setup-permission into master 2024-09-10 13:15:03 +02:00
No description provided.
hsh-michaelhoennig added 14 commits 2024-09-10 10:30:23 +02:00
hsh-michaelhoennig scheduled this pull request to auto merge when all checks succeed 2024-09-10 10:31:26 +02:00
hsh-michaelhoennig canceled auto merging this pull request when all checks succeed 2024-09-10 10:31:32 +02:00
hsh-michaelhoennig added 2 commits 2024-09-10 10:32:14 +02:00
hsh-marcsandlus reviewed 2024-09-10 10:55:04 +02:00
@ -51,0 +52,4 @@
case Dns.Status.NAME_NOT_FOUND: {
final var superDomain = superDomain(domainName);
final var verificationRequired = !superDomain.map(Dns::isRegistrarLevel).orElse(false)
&& assetEntity.getBookingItem() != null; // FIXME: or getParentAsset() == nuĺl? or extract method

use getParentAsset == null + Test

use getParentAsset == null + Test
hsh-michaelhoennig marked this conversation as resolved
hsh-marcsandlus reviewed 2024-09-10 10:58:24 +02:00
@ -51,0 +82,4 @@
return violations;
}
private static Optional<String> findTxtRecord(final Dns.Result result, final String expectedTxtRecordValue) {

findRecord

findRecord
hsh-marcsandlus reviewed 2024-09-10 11:03:33 +02:00
@ -0,0 +81,4 @@
@ParameterizedTest
@ValueSource(strings = {
"hostsharing.net", "hostsharing.org", "hostsharing.com", "hostsharing.coop"

+.de

+.de
hsh-michaelhoennig marked this conversation as resolved
hsh-marcsandlus reviewed 2024-09-10 11:05:22 +02:00
@ -249,6 +250,7 @@ class HsHostingAssetControllerAcceptanceTest extends ContextBasedTestWithCleanup
void globalAdmin_canAddTopLevelAsset() {
context.define("superuser-alex@hostsharing.net");
Dns.fakeResultForDomain("example.com", new Dns.Result(Dns.Status.NAME_NOT_FOUND, null, null));

reset nicht vergessen

reset nicht vergessen
hsh-michaelhoennig marked this conversation as resolved
hsh-marcsandlus reviewed 2024-09-10 11:08:52 +02:00
@ -51,3 +91,2 @@
// then
assertThat(result).containsExactly(
"'identifier' expected to match '^((?!-)[A-Za-z0-9-]{1,63}(?<!-)\\.)+[A-Za-z]{2,12}', but is '"+testCase.domainName+"'"
assertThat(result).contains(

test für parentAsset, inkl. gültige Zeichenlänge

test für parentAsset, inkl. gültige Zeichenlänge
hsh-michaelhoennig marked this conversation as resolved
hsh-marcsandlus reviewed 2024-09-10 11:20:13 +02:00
@ -125,0 +351,4 @@
return parentAsset;
}
class DomainSetupBuilder {

DomainSetup

DomainSetup
hsh-marcsandlus approved these changes 2024-09-10 11:21:42 +02:00
hsh-michaelhoennig added 1 commit 2024-09-10 13:14:45 +02:00
hsh-michaelhoennig merged commit a7d586f0f7 into master 2024-09-10 13:15:03 +02:00
hsh-michaelhoennig deleted branch check-domain-setup-permission 2024-09-10 13:15:04 +02:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hostsharing/hs.hsadmin.ng#97
No description provided.