improved RBAC generators #26

Merged
hsh-michaelhoennig merged 17 commits from improved-rbac-generator into master 2024-03-26 11:25:18 +01:00
No description provided.
hsh-michaelhoennig added 2 commits 2024-03-22 09:50:31 +01:00
hsh-michaelhoennig added 1 commit 2024-03-22 10:00:23 +01:00
hsh-michaelhoennig added 1 commit 2024-03-22 13:49:52 +01:00
hsh-michaelhoennig force-pushed improved-rbac-generator from 204f6583e0 to e118cfac73 2024-03-22 14:14:25 +01:00 Compare
hsh-michaelhoennig added 1 commit 2024-03-22 14:46:35 +01:00
hsh-michaelhoennig added 1 commit 2024-03-23 13:59:50 +01:00
hsh-michaelhoennig added 1 commit 2024-03-23 14:09:57 +01:00
hsh-michaelhoennig added 1 commit 2024-03-23 14:11:31 +01:00
hsh-michaelhoennig force-pushed improved-rbac-generator from 26115bd4ac to 725a0dd386 2024-03-24 07:39:56 +01:00 Compare
hsh-michaelhoennig force-pushed improved-rbac-generator from 725a0dd386 to fbe2204d72 2024-03-24 07:44:01 +01:00 Compare
hsh-michaelhoennig added 2 commits 2024-03-24 11:12:51 +01:00
hsh-michaelhoennig added 2 commits 2024-03-25 06:46:11 +01:00
hsh-michaelhoennig added 1 commit 2024-03-25 09:13:44 +01:00
hsh-timotheuspokorra approved these changes 2024-03-25 10:53:25 +01:00
hsh-timotheuspokorra left a comment
Member

soweit gut

soweit gut
@ -126,0 +164,4 @@
An indirect role is a role FIXME.
*/
create or replace function ${rawSubTable}_insert_permission_missing_tf()

rename missing to check

rename missing to check
hsh-michaelhoennig marked this conversation as resolved
@ -66,2 +72,4 @@
final var grants = rawGrantRepo.findByAscendingUuid(refUuid);
grants.forEach(g -> {
if ( g.getDescendantIdName() == null ) {
// FIXME: what's that?

anschauen

anschauen
hsh-michaelhoennig marked this conversation as resolved
@ -650,6 +691,11 @@ declare
superRoleId uuid;
subRoleId uuid;
begin
-- FIXME: maybe separate method grantRoleToRoleIfNotNull(...)?

anschauen

anschauen
hsh-michaelhoennig marked this conversation as resolved
@ -61,2 +61,3 @@
-- direct grants to users need a grantedByRole which can revoke the grant
if grantedByRole is null then
grantedByRoleUuid := roleUuid;
userGrantsByRoleUuid := roleUuid; -- FIXME: or do we want to require an explicit userGrantsByRoleUuid?

anschauen

anschauen
hsh-michaelhoennig marked this conversation as resolved
@ -109,3 +111,3 @@
if NEW.customerUuid <> OLD.customerUuid then
call revokePermissionFromRole(findPermissionId(OLD.uuid, 'INSERT'), testCustomerAdmin(oldCustomer));
call revokePermissionFromRole(getPermissionId(OLD.uuid, 'INSERT'), testCustomerAdmin(oldCustomer));

diese Zeile muss raus

diese Zeile muss raus
hsh-michaelhoennig marked this conversation as resolved
@ -209,13 +223,15 @@ create trigger test_package_insert_permission_check_tg
call generateRbacIdentityViewFromProjection('test_package', $idName$

line break

line break
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig added 1 commit 2024-03-25 11:47:45 +01:00
hsh-michaelhoennig force-pushed improved-rbac-generator from 6696031ebd to 197e155f00 2024-03-26 10:05:38 +01:00 Compare
hsh-michaelhoennig force-pushed improved-rbac-generator from 197e155f00 to 260de22fd6 2024-03-26 10:54:30 +01:00 Compare
hsh-michaelhoennig merged commit 4572c6bda0 into master 2024-03-26 11:25:18 +01:00
hsh-michaelhoennig deleted branch improved-rbac-generator 2024-03-26 11:25:44 +01:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hostsharing/hs.hsadmin.ng#26
No description provided.