hostsharing/hs.hsadmin.ng
6
0
Fork 0
Code Pull Requests 1 Activity

post new contact: process postalAddress #145

Merged
hsh-timotheuspokorra merged 5 commits from TP-20250109_addcontact_putpostaladdress into master 2025-01-16 13:57:15 +01:00
Conversation 3 Commits 5 Files Changed 4 +2
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 27de4ce634 - Show all commits

1
src/main/java/net/hostsharing/hsadminng/hs/office/contact/HsOfficeContactController.java
View File

@ -131,6 +131,7 @@ public class HsOfficeContactController implements HsOfficeContactsApi {
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
final BiConsumer<HsOfficeContactInsertResource, HsOfficeContactRbacEntity> RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> { final BiConsumer<HsOfficeContactInsertResource, HsOfficeContactRbacEntity> RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> {
entity.putPostalAddress(from(resource.getPostalAddress()));
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig commented 2025-01-09 10:33:30 +01:00
Review
Copy Link

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactControllerAcceptanceTest.AddContact#globalAdmin_withoutAssumedRole_canAddContact

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactControllerAcceptanceTest.AddContact#globalAdmin_withoutAssumedRole_canAddContact
entity.putEmailAddresses(from(resource.getEmailAddresses())); entity.putEmailAddresses(from(resource.getEmailAddresses()));
entity.putPhoneNumbers(from(resource.getPhoneNumbers())); entity.putPhoneNumbers(from(resource.getPhoneNumbers()));
}; };

1
src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java
View File

@ -185,6 +185,7 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
@SuppressWarnings("unchecked") @SuppressWarnings("unchecked")
final BiConsumer<HsOfficeContactInsertResource, HsOfficeContactRealEntity> CONTACT_RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> { final BiConsumer<HsOfficeContactInsertResource, HsOfficeContactRealEntity> CONTACT_RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> {
entity.putPostalAddress(from(resource.getPostalAddress()));
hsh-timotheuspokorra marked this conversation as resolved
hsh-michaelhoennig commented 2025-01-09 10:33:31 +01:00
Review
Copy Link

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationControllerAcceptanceTest.AddRelation#globalAdmin_withoutAssumedRole_canAddRelationWithHolderAndContactData

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationControllerAcceptanceTest.AddRelation#globalAdmin_withoutAssumedRole_canAddRelationWithHolderAndContactData
hsh-timotheuspokorra commented 2025-01-16 09:50:05 +01:00
Review
Copy Link

das habe ich nun auch gelöst

das habe ich nun auch gelöst
entity.putEmailAddresses(from(resource.getEmailAddresses())); entity.putEmailAddresses(from(resource.getEmailAddresses()));
entity.putPhoneNumbers(from(resource.getPhoneNumbers())); entity.putPhoneNumbers(from(resource.getPhoneNumbers()));
}; };