hostsharing/hs.hsadmin.ng
6
0
Fork 0
Code Pull Requests 1 Activity

post new contact: process postalAddress #145

Merged
hsh-timotheuspokorra merged 5 commits from TP-20250109_addcontact_putpostaladdress into master 2025-01-16 13:57:15 +01:00
Conversation 3 Commits 5 Files Changed 4 +26 -2
hsh-timotheuspokorra commented 2025-01-09 10:22:46 +01:00
Member
Copy Link
No description provided.
hsh-timotheuspokorra added 1 commit 2025-01-09 10:22:46 +01:00
hsh-michaelhoennig reviewed 2025-01-09 10:33:30 +01:00
src/main/java/net/hostsharing/hsadminng/hs/office/contact/HsOfficeContactController.java
@ -131,6 +131,7 @@ public class HsOfficeContactController implements HsOfficeContactsApi {
@SuppressWarnings("unchecked")
final BiConsumer<HsOfficeContactInsertResource, HsOfficeContactRbacEntity> RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> {
entity.putPostalAddress(from(resource.getPostalAddress()));
hsh-michaelhoennig commented 2025-01-09 10:33:30 +01:00
Member
Copy Link

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactControllerAcceptanceTest.AddContact#globalAdmin_withoutAssumedRole_canAddContact

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactControllerAcceptanceTest.AddContact#globalAdmin_withoutAssumedRole_canAddContact
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig reviewed 2025-01-09 10:33:31 +01:00
src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java
@ -185,6 +185,7 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
@SuppressWarnings("unchecked")
final BiConsumer<HsOfficeContactInsertResource, HsOfficeContactRealEntity> CONTACT_RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> {
entity.putPostalAddress(from(resource.getPostalAddress()));
hsh-michaelhoennig commented 2025-01-09 10:33:31 +01:00
Member
Copy Link

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationControllerAcceptanceTest.AddRelation#globalAdmin_withoutAssumedRole_canAddRelationWithHolderAndContactData

das sollte noch in einen Test aufgenommen werden, z.B. in net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationControllerAcceptanceTest.AddRelation#globalAdmin_withoutAssumedRole_canAddRelationWithHolderAndContactData
hsh-timotheuspokorra commented 2025-01-16 09:50:05 +01:00
Author
Member
Copy Link

das habe ich nun auch gelöst

das habe ich nun auch gelöst
hsh-timotheuspokorra marked this conversation as resolved
hsh-michaelhoennig requested review from hsh-michaelhoennig 2025-01-09 10:40:52 +01:00
hsh-timotheuspokorra added 1 commit 2025-01-16 08:54:37 +01:00
hsh-timotheuspokorra added 3 commits 2025-01-16 09:49:23 +01:00
hsh-michaelhoennig approved these changes 2025-01-16 13:07:04 +01:00
hsh-timotheuspokorra merged commit abddebd7c3 into master 2025-01-16 13:57:15 +01:00
hsh-timotheuspokorra deleted branch TP-20250109_addcontact_putpostaladdress 2025-01-16 13:57:15 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
hsh-michaelhoennig
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: hostsharing/hs.hsadmin.ng#145
No description provided.
Delete Branch "TP-20250109_addcontact_putpostaladdress"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?