introduce separate database-schemas base+rbac #103

Merged
hsh-michaelhoennig merged 54 commits from introduce-separate-database-schemas-base-and-rbac into master 2024-09-16 15:36:38 +02:00
No description provided.
hsh-michaelhoennig added 49 commits 2024-09-16 09:44:38 +02:00
hsh-michaelhoennig added 2 commits 2024-09-16 13:59:57 +02:00
hsh-marcsandlus reviewed 2024-09-16 14:16:53 +02:00
@ -163,2 +160,2 @@
perform createRbacUser('selfregistered-user-drew@hostsharing.org');
perform createRbacUser('selfregistered-test-user@hostsharing.org');
admins = rbac.findRoleId(rbac.globalAdmin());
call rbac.grantRoleToUserUnchecked(admins, admins, rbac.create_subject('superuser-alex@hostsharing.net'));

müsste das nicht grantRoleToSubjectUnchecked heißen

müsste das nicht grantRoleToSubjectUnchecked heißen
hsh-michaelhoennig marked this conversation as resolved
hsh-marcsandlus reviewed 2024-09-16 14:37:47 +02:00
@ -11,3 +11,3 @@
-- ============================================================================
--changeset hs-office-membership-rbac-ROLE-DESCRIPTORS:1 endDelimiter:--//
--changeset RbacRoleDescirptorsGenerator:hs-office-membership-rbac-ROLE-DESCRIPTORS endDelimiter:--//

typo

typo
hsh-michaelhoennig marked this conversation as resolved
hsh-michaelhoennig added 1 commit 2024-09-16 14:50:59 +02:00
hsh-marcsandlus reviewed 2024-09-16 14:54:10 +02:00
@ -39,3 +39,3 @@
Very flexible access, programmatic, rules could be implemented.
The role-hierarchy and permissions for currently logged-in users user could be cached in the backend.
The role-hierarchy and permissions for currently logged-in sujects could be cached in the backend.

typo

typo
hsh-michaelhoennig marked this conversation as resolved
hsh-marcsandlus reviewed 2024-09-16 14:55:50 +02:00
@ -99,1 +97,3 @@
globalADMIN());
call rbac.grantPermissionToRole(
rbac.createPermission(row.uuid, 'INSERT', 'test_customer'),
rbac.globalADMIN());

globalAdmin statt globalADMIN?

globalAdmin statt globalADMIN?
Author
Member

ist nicht case-sensitiv, und da der Teil 'ADMIN' sich auf den Enum-Wert ADMIN von rbac.RoleType bezieht, ist sogar globalADMIN() passender - PostgreSQL speichert es als "globaladmin", da geht also die Groß-/Kleinschreibung ganz verloren, ich lasse das erst einmal so, vor allem weil ich sonst massig Merge-Probleme mit dem nächsten Branch habe

ist nicht case-sensitiv, und da der Teil 'ADMIN' sich auf den Enum-Wert ADMIN von rbac.RoleType bezieht, ist sogar globalADMIN() passender - PostgreSQL speichert es als "globaladmin", da geht also die Groß-/Kleinschreibung ganz verloren, ich lasse das erst einmal so, vor allem weil ich sonst massig Merge-Probleme mit dem nächsten Branch habe
hsh-marcsandlus approved these changes 2024-09-16 14:55:54 +02:00
hsh-michaelhoennig added 1 commit 2024-09-16 14:56:00 +02:00
hsh-michaelhoennig added 1 commit 2024-09-16 15:35:46 +02:00
hsh-michaelhoennig merged commit 1eed0e9b21 into master 2024-09-16 15:36:38 +02:00
hsh-michaelhoennig deleted branch introduce-separate-database-schemas-base-and-rbac 2024-09-16 15:36:38 +02:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: hostsharing/hs.hsadmin.ng#103
No description provided.