src/main/java/net/hostsharing/hsadminng/hs/office/debitor/HsOfficeDebitorEntity.java

@@ -1,10 +1,6 @@
 package net.hostsharing.hsadminng.hs.office.debitor;
 
-import lombok.AllArgsConstructor;
-import lombok.Builder;
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
+import lombok.*;
 import net.hostsharing.hsadminng.errors.DisplayName;
 import net.hostsharing.hsadminng.hs.office.bankaccount.HsOfficeBankAccountEntity;
 import net.hostsharing.hsadminng.hs.office.partner.HsOfficePartnerEntity;
@@ -19,13 +15,7 @@ import org.hibernate.annotations.JoinFormula;
 import org.hibernate.annotations.NotFound;
 import org.hibernate.annotations.NotFoundAction;
 
-import jakarta.persistence.Column;
-import jakarta.persistence.Entity;
-import jakarta.persistence.GeneratedValue;
-import jakarta.persistence.Id;
-import jakarta.persistence.JoinColumn;
-import jakarta.persistence.ManyToOne;
-import jakarta.persistence.Table;
+import jakarta.persistence.*;
 import jakarta.validation.constraints.Pattern;
 import java.io.IOException;
 import java.util.UUID;
@@ -36,7 +26,7 @@ import static jakarta.persistence.CascadeType.PERSIST;
 import static jakarta.persistence.CascadeType.REFRESH;
 import static java.util.Optional.ofNullable;
 import static net.hostsharing.hsadminng.rbac.rbacdef.RbacView.Column.dependsOnColumn;
-import static net.hostsharing.hsadminng.rbac.rbacdef.RbacView.ColumnValue.usingDefaultCase;
+import static net.hostsharing.hsadminng.rbac.rbacdef.RbacView.ColumnValue.usingCase;
 import static net.hostsharing.hsadminng.rbac.rbacdef.RbacView.Nullable.NOT_NULL;
 import static net.hostsharing.hsadminng.rbac.rbacdef.RbacView.Nullable.NULLABLE;
 import static net.hostsharing.hsadminng.rbac.rbacdef.RbacView.Permission.*;
@@ -168,8 +158,7 @@ public class HsOfficeDebitorEntity implements RbacObject, Stringifyable {
                 .toRole("global", ADMIN).grantPermission(INSERT)
 
                 .importRootEntityAliasProxy("debitorRel", HsOfficeRelationEntity.class,
-                        // TODO.spec: do we need a distinct case for DEBITOR-Relation?
-                        usingDefaultCase(),
+                        usingCase("DEBITOR"),
                         directlyFetchedByDependsOnColumn(),
                         dependsOnColumn("debitorRelUuid"))
                 .createPermission(DELETE).grantedTo("debitorRel", OWNER)

src/main/java/net/hostsharing/hsadminng/rbac/rbacdef/RbacView.java

@@ -257,7 +257,7 @@ public class RbacView {
         return permDefs.stream()
                 .filter(p -> p.permission == permission && p.entityAlias == entityAlias)
                 .findFirst()
-                // .map(g -> g.forCase(processingCase)) TODO.impl: not implemented case dependent
+                // .map(g -> g.forCase(processingCase)) TODO: not implemented case dependent
                 .orElseGet(() -> new RbacPermissionDefinition(entityAlias, permission, null, true));
     }
 
@@ -415,6 +415,7 @@ public class RbacView {
         this.discriminatorColumName = discriminatorColumName;
         allCases.addAll(stream(caseDefs).toList());
 
+        // FIXME: currently only the default case is executed
         stream(caseDefs).forEach(caseDef -> {
             this.processingCase = caseDef;
             caseDef.def.accept(this);
@@ -1132,7 +1133,6 @@ public class RbacView {
         }
     }
 
-    // FIXME: subclass of ColumnValue
     public static class CaseDef {
 
         final String val;

src/main/java/net/hostsharing/hsadminng/rbac/rbacdef/RolesGrantsAndPermissionsGenerator.java

@@ -331,6 +331,11 @@ class RolesGrantsAndPermissionsGenerator {
                         .replace("${permRef}", createPerm(NEW, grantDef.getPermDef()))
                         .replace("${superRoleRef}", roleRef(NEW, grantDef.getSuperRoleDef()));
         };
+//        if (grantDef.isConditional()) {
+//            return "if " + grantDef.generateCondition() + " then\n"
+//                    + "    " + grantSql + "\n"
+//                    + "end if;";
+//        }
         return grantSql;
     }
 

src/test/java/net/hostsharing/hsadminng/hs/office/migration/ImportOfficeData.java

@@ -218,6 +218,23 @@ public class ImportOfficeData extends ContextBasedTest {
         }
     }
 
+    @Test
+    @Order(1021)
+    void buildDebitorRelations() {
+        debitors.forEach( (id, debitor) -> {
+            final var debitorRel = HsOfficeRelationEntity.builder()
+                    .type(HsOfficeRelationType.DEBITOR)
+                    .anchor(debitor.getPartner().getPartnerRel().getHolder())
+                    .holder(debitor.getPartner().getPartnerRel().getHolder()) //  just 1 debitor/partner in legacy hsadmin
+                    // FIXME .contact()
+                    .build();
+            if (debitorRel.getAnchor() != null && debitorRel.getHolder() != null &&
+                    debitorRel.getContact() != null ) {
+                relations.put(relationId++, debitorRel);
+            }
+        });
+    }
+
     @Test
     @Order(1029)
     void verifyContacts() {