.aliases

@@ -30,13 +30,13 @@ postgresAutodoc () {
     fi
 	postgresql_autodoc -d postgres -f build/postgres-autodoc -h localhost -u postgres --password=password \
 		-m '(rbacobject|hs).*' \
-		-l /usr/share/postgresql-autodoc -t neato &&
+		-l /usr/share/postgresql-autodoc -t neato && 
 	dot -Tsvg build/postgres-autodoc.neato >build/postgres-autodoc-hs.svg && \
 	echo "generated: $PWD/build/postgres-autodoc-hs.svg"
 
 	postgresql_autodoc -d postgres -f build/postgres-autodoc -h localhost -u postgres --password=password \
 		-m '(global|rbac).*' \
-		-l /usr/share/postgresql-autodoc -t neato &&
+		-l /usr/share/postgresql-autodoc -t neato && 
 	dot -Tsvg build/postgres-autodoc.neato >build/postgres-autodoc-rbac.svg && \
 	echo "generated $PWD/build/postgres-autodoc-rbac.svg"
 }
@@ -83,7 +83,7 @@ alias fp='grep -r '@Accepts' src | sed -e 's/^.*@/@/g' | sort -u | wc -l'
 
 alias gw-spotless='./gradlew spotlessApply -x pitest -x test -x :processResources'
 alias gw-test='. .aliases; ./gradlew test'
-alias gw-check='. .aliases; gw test check -x pitest'
+alias gw-check='. .aliases; gw test importOfficeData check -x pitest -x :dependencyCheckAnalyze'
 
 # etc/docker-compose.yml limits CPUs+MEM and includes a PostgreSQL config for analysing slow queries
 alias gw-importOfficeData-in-docker-compose='

Jenkinsfile

@@ -1,52 +0,0 @@
-pipeline {
-    agent {
-        dockerfile {
-            filename 'etc/jenkinsAgent.Dockerfile'
-            // additionalBuildArgs  ...
-            args '--network=bridge --user root -v $PWD:$PWD -v /var/run/docker.sock:/var/run/docker.sock --group-add 984'
-            reuseNode true
-       }
-    }
-
-    environment {
-        DOCKER_HOST = 'unix:///var/run/docker.sock'
-        HSADMINNG_POSTGRES_ADMIN_USERNAME = 'admin'
-        HSADMINNG_POSTGRES_RESTRICTED_USERNAME = 'restricted'
-        HSADMINNG_MIGRATION_DATA_PATH = 'migration'
-    }
-
-    triggers {
-        pollSCM('H/1 * * * *')
-    }
-
-    stages {
-        stage('Checkout') {
-            steps {
-                checkout scm
-            }
-        }
-
-        stage ('Compile & Test') {
-            steps {
-                sh './gradlew clean check --no-daemon -x pitest -x dependencyCheckAnalyze'
-            }
-        }
-    }
-
-    post {
-        always {
-            // archive test results
-            junit 'build/test-results/test/*.xml'
-
-            // archive the JaCoCo coverage report in XML and HTML format
-            jacoco(
-                execPattern: 'build/jacoco/*.exec',
-                classPattern: 'build/classes/java/main',
-                sourcePattern: 'src/main/java'
-            )
-
-            // cleanup workspace
-            cleanWs()
-        }
-    }
-}

README.md

@@ -497,19 +497,9 @@ We'll see if this changes when the project progresses and more validations are a
 
 ### OWASP Security Vulnerability Check
 
-An OWASP security vulnerability is configured, but you need an API key.
+An OWASP security vulnerability is configured and can be utilized by running:
-Fetch it from https://nvd.nist.gov/developers/request-an-api-key.
-
-Then add it to your `~/.gradle/gradle.properties` file:
-
-```
-OWASP_API_KEY=........-....-....-....-............
-```
-
-Now you can run the dependency vulnerability check:
 
 ```shell
-gw dependencyCheckUpdate
 gw dependencyCheckAnalyze
 ```
 
@@ -560,37 +550,12 @@ Dependency versions can be automatically upgraded to the latest available versio
 gw useLatestVersions
 ```
 
-Afterward, `gw check` is automatically started.
+Afterwards, `gw check` is automatically started.
 Please only commit+push to master if the check run shows no errors.
 
 More infos, e.g. on blacklists see on the [project's website](https://github.com/patrikerdes/gradle-use-latest-versions-plugin).
 
 
-## Biggest Flaws in our Architecture
-
-### The RBAC System is too Complicated
-
-Now, where we have a better experience with what we really need from the RBAC system, we have learned
-that and creates too many (grant- and role-) rows and too even tables which could be avoided completely.
-
-The basic idea is always to always have a fixed set of ordered role-types which apply for all DB-tables under RBAC,
-e.g. OWNER>ADMIN>AGENT\[>PROXY?\]>TENENT>REFERRER.
-Grants between these for the same DB-row would be implicit by order comparision.
-This way we would get rid of all explicit grants within the same DB-row
-and would not need the `rbac.role` table anymore.
-We would also reduce the depth of the expensive recursive CTE-query.
-
-This has to be explored further.
-For now, we just keep it in mind and  
-
-### The Mapper is Error-Prone
-
-Where `org.modelmapper.ModelMapper` reduces bloat-code a lot and has some nice features about recursive data-structure mappings,
-it often causes strange errors which are hard to fix.
-E.g. the uuid of the target main object is often taken from an uuid of a sub-subject.
-(For now, use `StrictMapper` to avoid this, for the case it happens.)
-
-
 ## How To ...
 
 ### How to Configure .pgpass for the Default PostgreSQL Database?

bin/git-pull-and-if-origin-changed-run-tests

@@ -1,38 +1,36 @@
 #!/bin/bash
-# waits for commits on any branch on origin, checks it out and builds it
 
-. .aliases
+# get the current branch name
+BRANCH=$(git rev-parse --abbrev-ref HEAD)
 
 while true; do
-    git fetch origin >/dev/null
-    branch_with_new_commits=`git fetch origin >/dev/null; git for-each-ref --format='%(refname:short) %(upstream:track)' refs/heads | grep '\[behind' | cut -d' ' -f1 | head -n1`
 
-    if [ -n "$branch_with_new_commits" ]; then
+  # get the latest commit hashes from origin and local
-          echo "checking out branch: $branch_with_new_commits"
+  git fetch origin
-          if git show-ref --quiet --heads "$branch_with_new_commits"; then
+  LOCAL=$(git rev-parse HEAD)
-              echo "Branch $branch_with_new_commits already exists. Checking it out and pulling latest changes."
+  REMOTE=$(git rev-parse origin/$BRANCH)
-              git checkout "$branch_with_new_commits"
-              git pull origin "$branch_with_new_commits"
-          else
-              echo "Creating and checking out new branch: $branch_with_new_commits"
-              git checkout -b "$branch_with_new_commits" "origin/$branch_with_new_commits"
-          fi
 
-          echo "building ..."
+  # check if the local branch differs from the remote branch
-          ./gradlew gw clean test check -x pitest
+  if [ "$LOCAL" != "$REMOTE" ]; then
-    fi
+    echo "local $LOCAL differs from remote $REMOTE => pulling changes from origin"
+    git pull origin $BRANCH
 
-    # wait 10s with a little animation
+    # run the command
-    echo -e -n "\r\033[K waiting for changes (/) ..."
+    echo "Running ./gradlew test"
-    sleep 2
+    source .aliases # only variables, aliases are not expanded in scripts
-    echo -e -n "\r\033[K waiting for changes (-) ..."
+    ./gradlew test
-    sleep 2
+  fi
-    echo -e -n "\r\033[K waiting for changes (\) ..."
+
-    sleep 2
+  # wait 10s with a little animation
-    echo -e -n "\r\033[K waiting for changes (|) ..."
+  echo -e -n " waiting for changes (/) ..."
-    sleep 2
+  sleep 2
-    echo -e -n "\r\033[K waiting for changes ( ) ... "
+  echo -e -n "\r\033[K waiting for changes (-) ..."
-    sleep 2
+  sleep 2
-    echo -e -n "\r\033[K checking for changes"
+  echo -e -n "\r\033[K waiting for changes (\) ..."
+  sleep 2
+  echo -e -n "\r\033[K waiting for changes (|) ..."
+  sleep 2
+  echo -e -n "\r\033[K waiting for changes ( ) ... "
+  sleep 2
+  echo -e -n "\r\033[K"
 done
-

build.gradle

@@ -1,10 +1,10 @@
 plugins {
     id 'java'
-    id 'org.springframework.boot' version '3.3.4'
+    id 'org.springframework.boot' version '3.2.4'
-    id 'io.spring.dependency-management' version '1.1.6'
+    id 'io.spring.dependency-management' version '1.1.4'
     id 'io.openapiprocessor.openapi-processor' version '2023.2'
-    id 'com.github.jk1.dependency-license-report' version '2.9'
+    id 'com.github.jk1.dependency-license-report' version '2.6'
-    id "org.owasp.dependencycheck" version "10.0.4"
+    id "org.owasp.dependencycheck" version "9.0.10"
     id "com.diffplug.spotless" version "6.25.0"
     id 'jacoco'
     id 'info.solidsoft.pitest' version '1.15.0'
@@ -58,20 +58,19 @@ dependencies {
     implementation 'org.springframework.boot:spring-boot-starter-jdbc'
     implementation 'org.springframework.boot:spring-boot-starter-web'
     implementation 'org.springframework.boot:spring-boot-starter-validation'
-    implementation 'com.github.gavlyukovskiy:datasource-proxy-spring-boot-starter:1.9.2'
+    implementation 'com.github.gavlyukovskiy:datasource-proxy-spring-boot-starter:1.9.1'
-    implementation 'org.springdoc:springdoc-openapi:2.6.0'
+    implementation 'org.springdoc:springdoc-openapi:2.4.0'
-    implementation 'org.postgresql:postgresql:42.7.4'
+    implementation 'org.postgresql:postgresql:42.7.3'
-    implementation 'org.liquibase:liquibase-core:4.29.2'
+    implementation 'org.liquibase:liquibase-core:4.27.0'
-    implementation 'io.hypersistence:hypersistence-utils-hibernate-63:3.8.3'
+    implementation 'io.hypersistence:hypersistence-utils-hibernate-63:3.7.3'
-    implementation 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.18.0'
+    implementation 'com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.17.0'
     implementation 'org.openapitools:jackson-databind-nullable:0.2.6'
-    implementation 'org.apache.commons:commons-text:1.12.0'
+    implementation 'org.apache.commons:commons-text:1.11.0'
-    implementation 'net.java.dev.jna:jna:5.15.0'
+    implementation 'net.java.dev.jna:jna:5.8.0'
-    implementation 'org.modelmapper:modelmapper:3.2.1'
+    implementation 'org.modelmapper:modelmapper:3.2.0'
-    implementation 'org.iban4j:iban4j:3.2.10-RELEASE'
+    implementation 'org.iban4j:iban4j:3.2.7-RELEASE'
-    implementation 'org.springdoc:springdoc-openapi-starter-webmvc-ui:2.6.0'
+    implementation 'org.springdoc:springdoc-openapi-starter-webmvc-ui:2.4.0'
-    implementation 'org.webjars:swagger-ui:5.17.14'
+    implementation 'org.reflections:reflections:0.9.12'
-    implementation 'org.reflections:reflections:0.10.2'
 
     compileOnly 'org.projectlombok:lombok'
     testCompileOnly 'org.projectlombok:lombok'
@@ -86,9 +85,9 @@ dependencies {
     testImplementation 'org.testcontainers:junit-jupiter'
     testImplementation 'org.junit.jupiter:junit-jupiter'
     testImplementation 'org.testcontainers:postgresql'
-    testImplementation 'com.tngtech.archunit:archunit-junit5:1.3.0'
+    testImplementation 'com.tngtech.archunit:archunit-junit5:1.2.1'
     testImplementation 'io.rest-assured:spring-mock-mvc'
-    testImplementation 'org.hamcrest:hamcrest-core:3.0'
+    testImplementation 'org.hamcrest:hamcrest-core:2.2'
     testImplementation 'org.pitest:pitest-junit5-plugin:1.2.1'
     testImplementation 'org.junit.jupiter:junit-jupiter-api'
 }
@@ -277,7 +276,7 @@ jacocoTestCoverageVerification {
     violationRules {
         rule {
             limit {
-                minimum = 0.80 // TODO.test: improve instruction coverage
+                minimum = 0.92
             }
         }
 
@@ -289,20 +288,15 @@ jacocoTestCoverageVerification {
             element = 'CLASS'
             excludes = [
                     'net.hostsharing.hsadminng.**.generated.**',
-                    'net.hostsharing.hsadminng.rbac.test.dom.TestDomainEntity',
                     'net.hostsharing.hsadminng.HsadminNgApplication',
                     'net.hostsharing.hsadminng.ping.PingController',
-                    'net.hostsharing.hsadminng.rbac.generator.*',
-                    'net.hostsharing.hsadminng.rbac.grant.RbacGrantsDiagramService',
-                    'net.hostsharing.hsadminng.rbac.grant.RbacGrantsDiagramService.Node',
-                    'net.hostsharing.hsadminng.**.*Repository',
                     'net.hostsharing.hsadminng.mapper.Mapper'
             ]
 
             limit {
                 counter = 'LINE'
                 value = 'COVEREDRATIO'
-                minimum = 0.75 // TODO.test: improve line coverage
+                minimum = 0.98
             }
         }
         rule {
@@ -316,7 +310,7 @@ jacocoTestCoverageVerification {
             limit {
                 counter = 'BRANCH'
                 value = 'COVEREDRATIO'
-                minimum = 0.00 // TODO.test: improve branch coverage
+                minimum = 1.00
             }
         }
     }
@@ -349,14 +343,14 @@ pitest {
     targetClasses = ['net.hostsharing.hsadminng.**']
     excludedClasses = [
             'net.hostsharing.hsadminng.config.**',
-            // 'net.hostsharing.hsadminng.**.*Controller',
+            'net.hostsharing.hsadminng.**.*Controller',
             'net.hostsharing.hsadminng.**.generated.**'
     ]
 
     targetTests = ['net.hostsharing.hsadminng.**.*UnitTest', 'net.hostsharing.hsadminng.**.*RestTest']
     excludedTestClasses = ['**AcceptanceTest*', '**IntegrationTest*']
 
-    pitestVersion = '1.17.0'
+    pitestVersion = '1.15.3'
     junit5PluginVersion = '1.1.0'
 
     threads = 4

doc/adr/2024-09-27-automatic-hosting-asset-creation-for-new-booking-items.md

@@ -1,119 +0,0 @@
-# Handling Automatic Creation of Hosting Assets for New Booking Items
-
-**Status:**
-- [x] proposed by (Michael Hönnig)
-- [ ] accepted by (Participants)
-- [ ] rejected by (Participants)
-- [ ] superseded by (superseding ADR)
-
-
-## Context and Problem Statement
-
-When a customer creates a new booking item (e.g., `MANAGED_WEBSPACE`), the system must automatically create the related hosting asset.
-This process can sometimes fail or require additional data from the user, e.g. installing a DNS verification key, or a hostmaster, e.g. the target server to use.
-
-The challenge is how to handle this automatic creation process while dealing with missing data, asynchronicity and failures while ensuring system consistency and proper user notification.
-
-
-### Technical Background
-
-The creation of hosting assets can occur synchronously (in simple cases) or asynchronously (when additional steps like manual verification are needed).
-For example, a `DOMAIN_SETUP` hosting asset may require DNS verification from the user, and until this is provided, the related domain cannot be fully set up.
-
-Additionally, not all data needed for creating the hosting asset is stored in the booking item.
-It's part of the HTTP request and later stored in the hosting asset, but we also need to store it before the hosting asset can be created asynchronously.
-
-Current system behavior involves returning HTTP 201 upon booking item creation, but the automatic hosting asset creation might fail due to missing information.
-The system needs to manage the creation process in a way that ensures valid hosting assets are created and informs the user of any actions required while still returning a 201 HTTP code, not an error code.
-
-
-## Considered Options
-
-For storing the data needed for the hosting-asset creation:
-
-* STORAGE-1: Store temporary asset data in the `BookingItemEntity`, e.g. a JSON column.
-    And delete the value of that column, once the hosting assets got successfully created.
-* STORAGE-2: Create hosting assets immediately, even if invalid, but mark them as "inactive" until completed and fully validated.
-* STORAGE-3: Store the asset data in a kind of event- or job-queue, which get deleted once the hosting-asset got successfully created.
-
-For the user-notification status:
-
-* STATUS-1: Introduce a status field in the booking-items.
-* STATUS-2: Store the status in the event-/job-queue entries.
-
-### STORAGE-1: Temporary Data Storage in `BookingItemEntity`
-
-Store asset-related data (e.g., domain name) in a temporary column or JSON field in the `BookingItemEntity` until the hosting assets are successfully created.
-Once assets are created, the temporary data is deleted to avoid inconsistencies.
-
-#### Advantages
-- Easy to implement.
-
-#### Disadvantages
-- Needs either a separate map of properties in the booking-item.
-- Or, if stored as a JSON field in the booking-item-resources, these are misused. 
-- Requires additional cleanup logic to remove stale data.
-
-### STORAGE-2: Inactive Hosting Assets Until Validation
-
-Create the hosting assets immediately upon booking item creation but mark them as "inactive" until all required information (e.g., verification code) is provided and validation is complete.
-
-#### Advantages
-- Avoids temporary external data storage for the hosting-assets.
-
-#### Disadvantages
-- Validation becomes more complex as some properties need to be validated, others not.
-    And some properties even need special treatment for new entities, which then becomes vague.
-- Inactive assets have to be filtered from operational assets.
-- Potential risk of incomplete or inconsistent assets being created, which may require correction.
-- Difficult to write tests for all possible combinations of validations.
-
-### STORAGE-3: Event-Based Approach
-
-The hosting asset data required for creation us passed to the API and stored in a `BookingItemCreatedEvent`.
-If hosting asset creation cannot happen synchronously, the event is stored and processed asynchronously in batches, retrying failed asset creation as needed.
-
-#### Advantages
-- Clean-data-structure (separation of concerns).
-- Clear separation between booking item creation and hosting asset creation.
-- Only valid assets in the database.
-- Can handle complex asynchronous processes (like waiting for external verification) in a clean and structured manner.
-- Easier to manage retries and failures in asset creation without complicating the booking item structure.
-
-#### Disadvantages
-- At the Spring controller level, the whole JSON is already converted into Java objects,
-    but for storing the asset data in the even, we need JSON again.
-    This could is not just a performance-overhead but could also lead to inconsistencies.
-
-### STATUS-1: Store hosting-asset-creation-status in the `BookingItemEntity`
-
-A status field would be added to booking-items to track the creation state of related hosting assets.
-The users could check their booking-items for the status of the hosting-asset creation, error messages and further instructions.
-
-#### Advantages
-- Easy to implement.
-
-#### Disadvantages
-- Adds a field to the booking-item which is makes no sense anymore once the related hosting asset is created.
-
-
-### Status-2: Store hosting-asset-creation-status in the `BookingItemCreateEvent`
-
-A status field would be added to the booking-item-created event and get updated with the latest messages any time we try to create the hosting-asset. 
-
-#### Advantages
-- Clean-data-structure (separation of concerns)
-
-#### Disadvantages
-- Accessing the status requires querying the event queue.
-
-
-## Decision Outcome
-
-**Chosen Option: STORAGE-3 with STATUS-2 (Event-Based Approach with `BookingItemCreatedEvent`)**
-
-The event-based approach was selected as the best solution for handling automatic hosting asset creation. This option provides a clear separation between booking item creation and hosting asset creation, ensuring that no invalid or incomplete assets are created. The asynchronous nature of the event system allows for retries and external validation steps (such as user-entered verification codes) without disrupting the overall flow.
-
-By using `BookingItemCreatedEvent` to store the hosting-asset data and the status,
-we don't need to misuse other data structures for temporary data
-and therefore hava a clean separation of concerns.

doc/rbac-performance-analysis.md

@@ -199,7 +199,7 @@ Limit  (cost=6549.08..6549.35 rows=54 width=16)
                                         Group Key: grants.descendantuuid
                                         ->  CTE Scan on grants  (cost=0.00..22.06 rows=1103 width=16)
                     ->  Index Only Scan using rbacobject_objecttable_uuid_key on rbacobject obj  (cost=0.28..0.31 rows=1 width=16)
-                            Index Cond: ((objecttable = 'hs_hosting.asset'::text) AND (uuid = perm.objectuuid))
+                            Index Cond: ((objecttable = 'hs_hosting_asset'::text) AND (uuid = perm.objectuuid))
 ```
 
 ### Office-Relation-Query
@@ -276,15 +276,15 @@ At this point, the import took 21mins with these statistics:
 | call rbac.grantRoleToRole(roleUuid, superRoleUuid, superRoleDesc.assumed) | 31316 | 0 | 1 |
 | call buildRbacSystemForHsHostingAsset(NEW) | 2258 | 0 | 7 |
 | select * from rbac.isGranted(array[granteeId], grantedId) | 44613 | 0 | 0 |
-| insert into public.hs_hosting.asset_rv (alarmcontactuuid,assignedtoassetuuid,bookingitemuuid,caption,config,identifier,parentassetuuid,type,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10) | 2207 | 0 | 7 |
+| insert into public.hs_hosting_asset_rv (alarmcontactuuid,assignedtoassetuuid,bookingitemuuid,caption,config,identifier,parentassetuuid,type,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10) | 2207 | 0 | 7 |
-| insert into hs_hosting.asset (alarmcontactuuid, version, bookingitemuuid, type, parentassetuuid, assignedtoassetuuid, config, uuid, identifier, caption) values (new.alarmcontactuuid, new. version, new. bookingitemuuid, new. type, new. parentassetuuid, new. assignedtoassetuuid, new. config, new. uuid, new. identifier, new. caption) returning * | 2207 | 0 | 7 |
+| insert into hs_hosting_asset (alarmcontactuuid, version, bookingitemuuid, type, parentassetuuid, assignedtoassetuuid, config, uuid, identifier, caption) values (new.alarmcontactuuid, new. version, new. bookingitemuuid, new. type, new. parentassetuuid, new. assignedtoassetuuid, new. config, new. uuid, new. identifier, new. caption) returning * | 2207 | 0 | 7 |
 | insert into public.hs_office.relation_rv (anchoruuid,contactuuid,holderuuid,mark,type,version,uuid) values ($1,$2,$3,$4,$5,$6,$7) | 1261 | 0 | 9 |
 | insert into hs_office.relation (uuid, version, anchoruuid, holderuuid, contactuuid, type, mark) values (new.uuid, new. version, new. anchoruuid, new. holderuuid, new. contactuuid, new. type, new. mark) returning * | 1261 | 0 | 9 |
 | call buildRbacSystemForHsOfficeRelation(NEW) | 1276 | 0 | 8 |
 | with recursive grants as ( select descendantUuid, ascendantUuid from RbacGrants where descendantUuid = grantedId union all select ""grant"".descendantUuid, ""grant"".ascendantUuid from RbacGrants ""grant"" inner join grants recur on recur.ascendantUuid = ""grant"".descendantUuid ) select exists ( select $3 from grants where ascendantUuid = any(granteeIds) ) or grantedId = any(granteeIds) | 47540 | 0 | 0 |
 | insert into RbacGrants (grantedByTriggerOf, ascendantuuid, descendantUuid, assumed) values (currentTriggerObjectUuid(), superRoleId, subRoleId, doAssume) on conflict do nothing" | 40472 | 0 | 0 |
-| insert into public.hs_booking.item_rv (caption,parentitemuuid,projectuuid,resources,type,validity,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8) | 926 | 0 | 7 |
+| insert into public.hs_booking_item_rv (caption,parentitemuuid,projectuuid,resources,type,validity,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8) | 926 | 0 | 7 |
-| insert into hs_booking.item (resources, version, projectuuid, type, parentitemuuid, validity, uuid, caption) values (new.resources, new. version, new. projectuuid, new. type, new. parentitemuuid, new. validity, new. uuid, new. caption) returning * | 926 | 0 | 7 |
+| insert into hs_booking_item (resources, version, projectuuid, type, parentitemuuid, validity, uuid, caption) values (new.resources, new. version, new. projectuuid, new. type, new. parentitemuuid, new. validity, new. uuid, new. caption) returning * | 926 | 0 | 7 |
 
 
 The slowest query now was fetching Relations joined with Contact, Anchor-Person and Holder-Person, for all tables using the restricted (RBAC) views (_rv).
@@ -300,14 +300,14 @@ We changed these mappings from `EAGER` (default) to `LAZY` to `@ManyToOne(fetch
 | call rbac.grantRoleToRole(roleUuid, superRoleUuid, superRoleDesc.assumed)                                                                                                                                                                                                                                                                                                                                  | 31316 | 0           | 1   |      
 | select * from rbac.isGranted(array[granteeId], grantedId)                                                                                                                                                                                                                                                                                                                                                  | 44613 | 0           | 0     |    
 | call buildRbacSystemForHsHostingAsset(NEW)                                                                                                                                                                                                                                                                                                                                                            | 2258 | 0           | 7        | 
-| insert into public.hs_hosting.asset_rv (alarmcontactuuid,assignedtoassetuuid,bookingitemuuid,caption,config,identifier,parentassetuuid,type,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10)                                                                                                                                                                                                     | 2207 | 0           | 7         |
+| insert into public.hs_hosting_asset_rv (alarmcontactuuid,assignedtoassetuuid,bookingitemuuid,caption,config,identifier,parentassetuuid,type,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10)                                                                                                                                                                                                     | 2207 | 0           | 7         |
-| insert into hs_hosting.asset (alarmcontactuuid, version, bookingitemuuid, type, parentassetuuid, assignedtoassetuuid, config, uuid, identifier, caption) values (new.alarmcontactuuid, new. version, new. bookingitemuuid, new. type, new. parentassetuuid, new. assignedtoassetuuid, new. config, new. uuid, new. identifier, new. caption) returning *                                              | 2207 | 0           | 7 |        
+| insert into hs_hosting_asset (alarmcontactuuid, version, bookingitemuuid, type, parentassetuuid, assignedtoassetuuid, config, uuid, identifier, caption) values (new.alarmcontactuuid, new. version, new. bookingitemuuid, new. type, new. parentassetuuid, new. assignedtoassetuuid, new. config, new. uuid, new. identifier, new. caption) returning *                                              | 2207 | 0           | 7 |        
 | with recursive grants as ( select descendantUuid, ascendantUuid from RbacGrants where descendantUuid = grantedId union all select ""grant"".descendantUuid, ""grant"".ascendantUuid from RbacGrants ""grant"" inner join grants recur on recur.ascendantUuid = ""grant"".descendantUuid ) select exists ( select $3 from grants where ascendantUuid = any(granteeIds) ) or grantedId = any(granteeIds) | 47538 | 0           | 0 |        
  insert into public.hs_office.relation_rv (anchoruuid,contactuuid,holderuuid,mark,type,version,uuid) values ($1,$2,$3,$4,$5,$6,$7)                                                                                                                                                                                                                                                                     | 1261 | 0           | 8         |
 | insert into hs_office.relation (uuid, version, anchoruuid, holderuuid, contactuuid, type, mark) values (new.uuid, new. version, new. anchoruuid, new. holderuuid, new. contactuuid, new. type, new. mark) returning *                                                                                                                                                                                 | 1261 | 0           | 8         |
 | call buildRbacSystemForHsOfficeRelation(NEW)                                                                                                                                                                                                                                                                                                                                                          | 1276 | 0           | 7 |        
-| insert into public.hs_booking.item_rv (caption,parentitemuuid,projectuuid,resources,type,validity,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8)                                                                                                                                                                                                                                                      | 926 | 0           | 7 |        
+| insert into public.hs_booking_item_rv (caption,parentitemuuid,projectuuid,resources,type,validity,version,uuid) values ($1,$2,$3,$4,$5,$6,$7,$8)                                                                                                                                                                                                                                                      | 926 | 0           | 7 |        
-| insert into hs_booking.item (resources, version, projectuuid, type, parentitemuuid, validity, uuid, caption) values (new.resources, new. version, new. projectuuid, new. type, new. parentitemuuid, new. validity, new. uuid, new. caption) returning *                                                                                                                                               | 926 | 0           | 7         |
+| insert into hs_booking_item (resources, version, projectuuid, type, parentitemuuid, validity, uuid, caption) values (new.resources, new. version, new. projectuuid, new. type, new. parentitemuuid, new. validity, new. uuid, new. caption) returning *                                                                                                                                               | 926 | 0           | 7         |
  insert into RbacGrants (grantedByTriggerOf, ascendantuuid, descendantUuid, assumed) values (currentTriggerObjectUuid(), superRoleId, subRoleId, doAssume) on conflict do nothing                                                                                                                                                                                                                      | 40472 | 0           | 0 |
 
 Now, finally, the total runtime of the import was down to 12 minutes. This is repeatable, where originally, the import took about 25mins in most cases and just rarely -  and for unknown reasons - 10min.
@@ -318,7 +318,7 @@ But once UnixUser and EmailAlias assets got added to the import, the total time
 
 This was not acceptable, especially not, considering that domains, email-addresses and database-assets are almost 10 times that number and thus the import would go up to over 1100min which is 20 hours.
 
-In a first step, a `HsHostingAssetRawEntity` was created, mapped to the raw table (hs_hosting.asset) not to the RBAC-view (hs_hosting.asset_rv). Unfortunately we did not keep measurements, but that was only part of the problem anyway. 
+In a first step, a `HsHostingAssetRawEntity` was created, mapped to the raw table (hs_hosting_asset) not to the RBAC-view (hs_hosting_asset_rv). Unfortunately we did not keep measurements, but that was only part of the problem anyway. 
 
 The main problem was, that there is something strange with persisting (`EntityManager.persist`) for EmailAlias assets. Where importing UnixUsers was mostly slow due to RBAC SELECT-permission checks, persisting EmailAliases suddenly created about a million (in numbers 1.000.000) SQL UPDATE statements after the INSERT, all with the same data, just increased version number (used for optimistic locking). We were not able to figure out why this happened.
 
@@ -330,7 +330,7 @@ Now, the longest running queries are these:
 
 | No.| calls   | total_m | mean_ms | query                                                                                                                                                                                                                                                                                                                                                                                          |
 |---:|---------|--------:|--------:|:-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-|  1 | 13.093  |       4 |      21 | insert into hs_hosting.asset( uuid, type, bookingitemuuid, parentassetuuid, assignedtoassetuuid, alarmcontactuuid, identifier, caption, config, version) values ( $1, $2, $3, $4, $5, $6, $7, $8, cast($9 as jsonb), $10)                                                                                                                                                                      |
+|  1 | 13.093  |       4 |      21 | insert into hs_hosting_asset( uuid, type, bookingitemuuid, parentassetuuid, assignedtoassetuuid, alarmcontactuuid, identifier, caption, config, version) values ( $1, $2, $3, $4, $5, $6, $7, $8, cast($9 as jsonb), $10)                                                                                                                                                                      |
 |  2 | 517     |       4 |     502 | select hore1_0.uuid,hore1_0.anchoruuid,hore1_0.contactuuid,hore1_0.holderuuid,hore1_0.mark,hore1_0.type,hore1_0.version from public.hs_office.relation_rv hore1_0 where hore1_0.uuid=$1                                                                                                                                                                                                        |
 |  3 | 13.144  |       4 |      21 | call buildRbacSystemForHsHostingAsset(NEW)                                                                                                                                                                                                                                                                                                                                                     |
 |  4 | 96.632  |       3 |       2 | call rbac.grantRoleToRole(roleUuid, superRoleUuid, superRoleDesc.assumed)                                                                                                                                                                                                                                                                                                                           |
@@ -338,10 +338,10 @@ Now, the longest running queries are these:
 |  6 | 123.740 |       3 |       2 | with recursive grants as ( select descendantUuid, ascendantUuid from RbacGrants where descendantUuid = grantedId union all select "grant".descendantUuid, "grant".ascendantUuid from RbacGrants "grant" inner join grants recur on recur.ascendantUuid = "grant".descendantUuid ) select exists ( select $3 from grants where ascendantUuid = any(granteeIds) ) or grantedId = any(granteeIds) |
 |  7 | 497     |       2 |     259 | select hoce1_0.uuid,hoce1_0.caption,hoce1_0.emailaddresses,hoce1_0.phonenumbers,hoce1_0.postaladdress,hoce1_0.version from public.hs_office.contact_rv hoce1_0 where hoce1_0.uuid=$1                                                                                                                                                                                                           |
 |  8 | 497     |       2 |     255 | select hope1_0.uuid,hope1_0.familyname,hope1_0.givenname,hope1_0.persontype,hope1_0.salutation,hope1_0.title,hope1_0.tradename,hope1_0.version from public.hs_office.person_rv hope1_0 where hope1_0.uuid=$1                                                                                                                                                                                   |
-|  9 | 13.144  |       1 |       8 | SELECT createRoleWithGrants( hs_hosting.asset_TENANT(NEW), permissions => array[$7], incomingSuperRoles => array[ hs_hosting.asset_AGENT(NEW), hs_office.contact_ADMIN(newAlarmContact)], outgoingSubRoles => array[ hs_booking.item_TENANT(newBookingItem), hs_hosting.asset_TENANT(newParentAsset)] ) |
+|  9 | 13.144  |       1 |       8 | SELECT createRoleWithGrants( hsHostingAssetTENANT(NEW), permissions => array[$7], incomingSuperRoles => array[ hsHostingAssetAGENT(NEW), hsOfficeContactADMIN(newAlarmContact)], outgoingSubRoles => array[ hsBookingItemTENANT(newBookingItem), hsHostingAssetTENANT(newParentAsset)] ) |
-| 10 |  13.144 |       1 |       5 |  SELECT createRoleWithGrants( hs_hosting.asset_ADMIN(NEW), permissions => array[$7], incomingSuperRoles => array[ hs_booking.item_AGENT(newBookingItem), hs_hosting.asset_AGENT(newParentAsset), hs_hosting.asset_OWNER(NEW)] ) |
+| 10 |  13.144 |       1 |       5 |  SELECT createRoleWithGrants( hsHostingAssetADMIN(NEW), permissions => array[$7], incomingSuperRoles => array[ hsBookingItemAGENT(newBookingItem), hsHostingAssetAGENT(newParentAsset), hsHostingAssetOWNER(NEW)] ) |
 
-That the `INSERT into hs_hosting.asset` (No. 1) takes up the most time, seems to be normal, and 21ms for each call is also fine.
+That the `INSERT into hs_hosting_asset` (No. 1) takes up the most time, seems to be normal, and 21ms for each call is also fine.
 
 It seems that the trigger effects (eg. No. 3 and No. 4) are included in the measure for the causing INSERT, otherwise summing up the totals would exceed the actual total time of the whole import. And it was to be expected that building the RBAC rules for new business objects takes most of the time.
 
@@ -408,12 +408,12 @@ We found some solution approaches:
 This optimization idea came from Michael Hierweck and was promising.
 The idea is to reduce the size of the result of the recursive CTE query and maybe even speed up that query itself.
 
-To evaluate this, I added a type column to the `rbacObject` table, initially as an enum hsHostingAssetType. Then I entered the type there for all rows from hs_hosting.asset. This means that 83,886 of 92,545 rows in `rbacobject` have a type set, leaving 8,659 without.
+To evaluate this, I added a type column to the `rbacObject` table, initially as an enum hsHostingAssetType. Then I entered the type there for all rows from hs_hosting_asset. This means that 83,886 of 92,545 rows in `rbacobject` have a type set, leaving 8,659 without.
 
 If we do this for other types (we currently have 1,271 relations and 927 booking items), it gets more complicated because they are different enum types. As varchar(16), we could lose performance again due to the higher storage space requirements.
 
 But the performance gained is not particularly high anyway.
-See the average seconds per recursive CTE select as role 'hs_hosting.asset:<DEBITOR>defaultproject:ADMIN',
+See the average seconds per recursive CTE select as role 'hs_hosting_asset:<DEBITOR>defaultproject:ADMIN',
 joined with business query for all `'EMAIL_ADDRESSES'`:
 
 |                                                     | D-1000000-hsh    | D-1000300-mih |

etc/allowed-licenses.json

@@ -1,10 +1,8 @@
 {
     "allowedLicenses": [
-        { "moduleLicense": "Apache 2" },
         { "moduleLicense": "Apache 2.0" },
-        { "moduleLicense": "Apache-2.0" },
+        { "moduleLicense": "Apache 2" },
         { "moduleLicense": "Apache License 2.0" },
-        { "moduleLicense": "Apache License v2.0" },
         { "moduleLicense": "Apache License, Version 2.0" },
         { "moduleLicense": "The Apache Software License, Version 2.0" },
 
@@ -13,8 +11,6 @@
         { "moduleLicense": "BSD-3-Clause" },
         { "moduleLicense": "The BSD License" },
 
-        { "moduleLicense": "The New BSD License" },
-
         { "moduleLicense": "CDDL 1.1" },
         { "moduleLicense": "CDDL/GPLv2+CE" },
         { "moduleLicense": "COMMON DEVELOPMENT AND DISTRIBUTION LICENSE (CDDL) Version 1.0" },
@@ -33,22 +29,11 @@
         { "moduleLicense": "GNU General Public License, version 2 with the GNU Classpath Exception" },
         { "moduleLicense": "GPL2 w/ CPE" },
 
-        { "moduleLicense": "LGPL, version 2.1"},
-        { "moduleLicense": "LGPL-2.1-or-later"},
-
         { "moduleLicense": "MIT License" },
         { "moduleLicense": "MIT" },
         { "moduleLicense": "The MIT License (MIT)" },
         { "moduleLicense": "The MIT License" },
 
-        { "moduleLicense": "WTFPL" },
+        { "moduleName": "org.springdoc:springdoc-openapi" }
-
-        {
-            "moduleLicense": null,
-            "#moduleLicense": "Apache License 2.0, see https://github.com/springdoc/springdoc-openapi/blob/main/LICENSE",
-            "moduleVersion": "2.4.0",
-            "moduleName": "org.springdoc:springdoc-openapi"
-        }
-
     ]
 }

etc/jenkinsAgent.Dockerfile

@@ -1,10 +0,0 @@
-FROM eclipse-temurin:21-jdk
-RUN apt-get update && \
-    apt-get install -y bind9-utils && \
-    apt-get clean && \
-    rm -rf /var/lib/apt/lists/*
-
-
-# RUN mkdir /opt/app
-# COPY japp.jar /opt
-# CMD ["java", "-jar", "/opt/app/japp.jar"]

etc/owasp-dependency-check-suppression.xml

@@ -1,5 +1,12 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <suppressions xmlns="https://jeremylong.github.io/DependencyCheck/dependency-suppression.1.3.xsd">
+    <suppress>
+        <notes><![CDATA[
+           Cyclic references are not possible if file comes in JSON text format.
+       ]]></notes>
+        <packageUrl regex="true">^pkg:maven/com\.fasterxml\.jackson\.core/jackson\-databind@.*$</packageUrl>
+        <cpe>cpe:/a:fasterxml:jackson-databind</cpe>
+    </suppress>
     <suppress>
         <notes><![CDATA[
            Internal tooling, not exposed to the Internet.
@@ -7,10 +14,4 @@
         <packageUrl regex="true">^pkg:maven/org\.pitest/pitest\-command\-line@.*$</packageUrl>
         <cpe>cpe:/a:line:line</cpe>
     </suppress>
-    <suppress>
-        <notes><![CDATA[
-           Malicious HTTP redirect in JAXB on a REST-endpoint is not that dangerous.
-        ]]></notes>
-        <cve>CVE-2024-9329</cve>
-    </suppress>
 </suppressions>

sql/historization.sql

@@ -6,21 +6,21 @@
 rollback;
 begin transaction;
 call defineContext('historization testing', null, 'superuser-alex@hostsharing.net',
---                    'hs_booking.project#D-1000000-hshdefaultproject:ADMIN'); -- prod+test
+--                    'hs_booking_project#D-1000000-hshdefaultproject:ADMIN'); -- prod+test
-                   'hs_booking.project#D-1000313-D-1000313defaultproject:ADMIN'); -- prod+test
+                   'hs_booking_project#D-1000313-D-1000313defaultproject:ADMIN'); -- prod+test
---                    'hs_booking.project#D-1000300-mihdefaultproject:ADMIN'); -- prod
+--                    'hs_booking_project#D-1000300-mihdefaultproject:ADMIN'); -- prod
---                    'hs_booking.project#D-1000300-mimdefaultproject:ADMIN'); -- test
+--                    'hs_booking_project#D-1000300-mimdefaultproject:ADMIN'); -- test
--- update hs_hosting.asset set caption='lug00 b' where identifier = 'lug00' and type = 'MANAGED_WEBSPACE'; -- prod
+-- update hs_hosting_asset set caption='lug00 b' where identifier = 'lug00' and type = 'MANAGED_WEBSPACE'; -- prod
--- update hs_hosting.asset set caption='hsh00 A ' || now()::text where identifier = 'hsh00' and type = 'MANAGED_WEBSPACE'; -- test
+-- update hs_hosting_asset set caption='hsh00 A ' || now()::text where identifier = 'hsh00' and type = 'MANAGED_WEBSPACE'; -- test
--- update hs_hosting.asset set caption='hsh00 B ' || now()::text where identifier = 'hsh00' and type = 'MANAGED_WEBSPACE'; -- test
+-- update hs_hosting_asset set caption='hsh00 B ' || now()::text where identifier = 'hsh00' and type = 'MANAGED_WEBSPACE'; -- test
 
--- insert into hs_hosting.asset
+-- insert into hs_hosting_asset
 --     (uuid, bookingitemuuid, type, parentassetuuid, assignedtoassetuuid, identifier, caption, config, alarmcontactuuid)
 --     values
 --     (uuid_generate_v4(), null, 'EMAIL_ADDRESS', 'bbda5895-0569-4e20-bb4c-34f3a38f3f63'::uuid, null,
 --         'new@thi.example.org', 'some new E-Mail-Address', '{}'::jsonb, null);
 
-delete from hs_hosting.asset where uuid='5aea68d2-3b55-464f-8362-b05c76c5a681'::uuid;
+delete from hs_hosting_asset where uuid='5aea68d2-3b55-464f-8362-b05c76c5a681'::uuid;
 commit;
 
 -- single version at point in time
@@ -29,11 +29,11 @@ set hsadminng.tx_history_txid to '';
 set hsadminng.tx_history_timestamp to '2024-08-29 12:42';
 -- all versions
 select base.tx_history_txid(), txc.txtimestamp, txc.currentSubject, txc.currentTask, haex.*
-    from hs_hosting.asset_ex haex
+    from hs_hosting_asset_ex haex
              join base.tx_context txc on haex.txid=txc.txid
     where haex.identifier = 'test@thi.example.org';
 
-select uuid, version, type, identifier, caption from hs_hosting.asset_hv p where identifier = 'test@thi.example.org';
+select uuid, version, type, identifier, caption from hs_hosting_asset_hv p where identifier = 'test@thi.example.org';
 
 select pg_current_xact_id();
 

sql/recursive-cte-experiments-for-accessible-uuids.sql

@@ -6,10 +6,10 @@ select * from hs_statistics_v;
 
 -- This is the extracted recursive CTE query to determine the visible object UUIDs of a single table
 -- (and optionally the hosting-asset-type) as a separate VIEW.
--- In the generated code this is part of the hs_hosting.asset_rv VIEW.
+-- In the generated code this is part of the hs_hosting_asset_rv VIEW.
 
-drop view if exists hs_hosting.asset_example_gv;
+drop view if exists hs_hosting_asset_example_gv;
-create view hs_hosting.asset_example_gv as
+create view hs_hosting_asset_example_gv as
 with recursive
     recursive_grants as (
         select distinct rbacgrants.descendantuuid,
@@ -40,7 +40,7 @@ select distinct perm.objectuuid
              join rbacpermission perm on recursive_grants.descendantuuid = perm.uuid
              join rbacobject obj on obj.uuid = perm.objectuuid
              join count_check cc on cc.valid
-    where obj.objecttable::text = 'hs_hosting.asset'::text
+    where obj.objecttable::text = 'hs_hosting_asset'::text
       -- with/without this type condition
 --       and obj.type = 'EMAIL_ADDRESS'::hshostingassettype
       and obj.type = 'EMAIL_ADDRESS'::hshostingassettype
@@ -53,10 +53,10 @@ select distinct perm.objectuuid
 rollback transaction;
 begin transaction;
 CALL defineContext('performance testing', null, 'superuser-alex@hostsharing.net',
-                   'hs_booking.project#D-1000000-hshdefaultproject:ADMIN');
+                   'hs_booking_project#D-1000000-hshdefaultproject:ADMIN');
---                        'hs_booking.project#D-1000300-mihdefaultproject:ADMIN');
+--                        'hs_booking_project#D-1000300-mihdefaultproject:ADMIN');
 SET TRANSACTION READ ONLY;
-EXPLAIN ANALYZE select * from hs_hosting.asset_example_gv;
+EXPLAIN ANALYZE select * from hs_hosting_asset_example_gv;
 end transaction ;
 
 -- ========================================================
@@ -64,15 +64,15 @@ end transaction ;
 -- An example for a restricted view (_rv) similar to the one generated by our RBAC system,
 -- but using the above separate VIEW to determine the visible objects.
 
-drop view if exists hs_hosting.asset_example_rv;
+drop view if exists hs_hosting_asset_example_rv;
-create view hs_hosting.asset_example_rv as
+create view hs_hosting_asset_example_rv as
-    with accessible_hs_hosting.asset_uuids as (
+    with accessible_hs_hosting_asset_uuids as (
-        select * from hs_hosting.asset_example_gv
+        select * from hs_hosting_asset_example_gv
     )
     select target.*
-        from hs_hosting.asset target
+        from hs_hosting_asset target
-        where (target.uuid in (select accessible_hs_hosting.asset_uuids.objectuuid
+        where (target.uuid in (select accessible_hs_hosting_asset_uuids.objectuuid
-                                   from accessible_hs_hosting.asset_uuids));
+                                   from accessible_hs_hosting_asset_uuids));
 
 -- -------------------------------------------------------------------------------
 
@@ -89,8 +89,8 @@ BEGIN
     start_time := clock_timestamp();
 
     CALL defineContext('performance testing', null, 'superuser-alex@hostsharing.net',
-                       'hs_booking.project#D-1000000-hshdefaultproject:ADMIN');
+                       'hs_booking_project#D-1000000-hshdefaultproject:ADMIN');
---                        'hs_booking.project#D-1000300-mihdefaultproject:ADMIN');
+--                        'hs_booking_project#D-1000300-mihdefaultproject:ADMIN');
     SET TRANSACTION READ ONLY;
 
     FOR i IN 0..25 LOOP
@@ -99,7 +99,7 @@ BEGIN
 
                 -- An example for a business query based on the view:
                 select type, uuid, identifier, caption
-                  from hs_hosting.asset_example_rv
+                  from hs_hosting_asset_example_rv
                  where type = 'EMAIL_ADDRESS'
                     and identifier like letter || '%'
                  -- end of the business query example.
@@ -115,7 +115,7 @@ BEGIN
 END;
 $$;
 
--- average seconds per recursive CTE select as role 'hs_hosting.asset:<DEBITOR>defaultproject:ADMIN'
+-- average seconds per recursive CTE select as role 'hs_hosting_asset:<DEBITOR>defaultproject:ADMIN'
 --      joined with business query for all 'EMAIL_ADDRESSES':
 --                                              D-1000000-hsh      D-1000300-mih
 --  - without type comparison in rbacobject:    ~3.30 - ~3.49      ~0.23
@@ -128,15 +128,15 @@ $$;
 rollback transaction;
 begin transaction;
 CALL defineContext('performance testing', null, 'superuser-alex@hostsharing.net',
-                   'hs_booking.project#D-1000000-hshdefaultproject:ADMIN');
+                   'hs_booking_project#D-1000000-hshdefaultproject:ADMIN');
---                        'hs_booking.project#D-1000300-mihdefaultproject:ADMIN');
+--                        'hs_booking_project#D-1000300-mihdefaultproject:ADMIN');
 SET TRANSACTION READ ONLY;
 
 EXPLAIN SELECT * from (
 
                 -- An example for a business query based on the view:
                 select type, uuid, identifier, caption
-                  from hs_hosting.asset_example_rv
+                  from hs_hosting_asset_example_rv
                  where type = 'EMAIL_ADDRESS'
 --                     and identifier like 'b%'
                  -- end of the business query example.
@@ -151,17 +151,17 @@ end transaction;
 
 alter table rbacobject
     -- just for performance testing, we would need a joined enum or a varchar(16) which would make it slow
-    add column type hs_hosting.AssetType;
+    add column type hshostingassettype;
 
--- and fill the type column with hs_hosting.asset types:
+-- and fill the type column with hs_hosting_asset types:
 
 rollback transaction;
 begin transaction;
-call defineContext('setting rbacobject.type from hs_hosting.asset.type', null, 'superuser-alex@hostsharing.net');
+call defineContext('setting rbacobject.type from hs_hosting_asset.type', null, 'superuser-alex@hostsharing.net');
 
     UPDATE rbacobject
     SET type = hs.type
-        FROM hs_hosting.asset hs
+        FROM hs_hosting_asset hs
         WHERE rbacobject.uuid = hs.uuid;
 
 end transaction;

src/main/java/net/hostsharing/hsadminng/config/JsonObjectMapperConfiguration.java

@@ -17,7 +17,7 @@ public class JsonObjectMapperConfiguration {
     public Jackson2ObjectMapperBuilder customObjectMapper() {
         return new Jackson2ObjectMapperBuilder()
                 .modules(new JsonNullableModule(), new JavaTimeModule())
-                .featuresToEnable(JsonParser.Feature.ALLOW_COMMENTS, JsonParser.Feature.ALLOW_COMMENTS)
+                .featuresToEnable(JsonParser.Feature.ALLOW_COMMENTS)
                 .featuresToDisable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS);
     }
 }

src/main/java/net/hostsharing/hsadminng/errors/DisplayAs.java

@@ -9,25 +9,15 @@ import java.lang.annotation.Target;
 @Target(ElementType.TYPE)
 @Retention(RetentionPolicy.RUNTIME)
 public @interface DisplayAs {
-
     class DisplayName {
-
         public static String of(final Class<?> clazz) {
-            final var displayNameAnnot = getDisplayNameAnnotation(clazz);
+            final var displayNameAnnot = clazz.getAnnotation(DisplayAs.class);
             return displayNameAnnot != null ? displayNameAnnot.value() : clazz.getSimpleName();
         }
 
         public static String of(@NotNull final Object instance) {
             return of(instance.getClass());
         }
-
-        private static DisplayAs getDisplayNameAnnotation(final Class<?> clazz) {
-            if (clazz == null) {
-                return null;
-            }
-            final var annot = clazz.getAnnotation(DisplayAs.class);
-            return annot != null ? annot : getDisplayNameAnnotation(clazz.getSuperclass());
-        }
     }
 
     String value() default "";

src/main/java/net/hostsharing/hsadminng/hash/HashGenerator.java

@@ -27,7 +27,7 @@ public final class HashGenerator {
             "abcdefghijklmnopqrstuvwxyz" +
                     "ABCDEFGHIJKLMNOPQRSTUVWXYZ" +
                     "0123456789/.";
-    private static boolean couldBeHashEnabled; // TODO.legacy: remove after legacy data is migrated
+    private static boolean couldBeHashEnabled; // TODO.impl: remove after legacy data is migrated
 
     public enum Algorithm {
         LINUX_SHA512(LinuxEtcShadowHashGenerator::hash, "6"),

src/main/java/net/hostsharing/hsadminng/hs/booking/debitor/HsBookingDebitorEntity.java

@@ -18,7 +18,7 @@ import static net.hostsharing.hsadminng.stringify.Stringify.stringify;
 
 // a partial HsOfficeDebitorEntity to reduce the number of SQL queries to load the entity
 @Entity
-@Table(schema = "hs_booking", name = "debitor_xv")
+@Table(name = "hs_booking_debitor_xv")
 @Getter
 @Builder
 @NoArgsConstructor

src/main/java/net/hostsharing/hsadminng/hs/booking/item/BookingItemCreatedAppEvent.java

@@ -1,20 +0,0 @@
-package net.hostsharing.hsadminng.hs.booking.item;
-
-import lombok.Getter;
-import org.springframework.context.ApplicationEvent;
-
-import jakarta.validation.constraints.NotNull;
-
-@Getter
-public class BookingItemCreatedAppEvent extends ApplicationEvent {
-
-    private BookingItemCreatedEventEntity entity;
-
-    public BookingItemCreatedAppEvent(
-            @NotNull final Object source,
-            @NotNull final HsBookingItemRealEntity newBookingItem,
-            final String assetJson) {
-        super(source);
-        this.entity = new BookingItemCreatedEventEntity(newBookingItem, assetJson);
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/booking/item/BookingItemCreatedEventEntity.java

@@ -1,55 +0,0 @@
-package net.hostsharing.hsadminng.hs.booking.item;
-
-import lombok.Getter;
-import lombok.NoArgsConstructor;
-import lombok.Setter;
-import lombok.ToString;
-import lombok.experimental.SuperBuilder;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
-
-import jakarta.persistence.Column;
-import jakarta.persistence.Entity;
-import jakarta.persistence.Id;
-import jakarta.persistence.JoinColumn;
-import jakarta.persistence.ManyToOne;
-import jakarta.persistence.MapsId;
-import jakarta.persistence.Table;
-import jakarta.persistence.Version;
-import jakarta.validation.constraints.NotNull;
-import java.util.UUID;
-
-
-
-@Entity
-@Table(schema = "hs_booking", name = "item_created_event")
-@SuperBuilder(toBuilder = true)
-@Getter
-@ToString
-@NoArgsConstructor
-public class BookingItemCreatedEventEntity implements BaseEntity {
-    @Id
-    @Column(name="bookingitemuuid")
-    private UUID uuid;
-
-    @MapsId
-    @ManyToOne(optional = false)
-    @JoinColumn(name = "bookingitemuuid", nullable = false)
-    private HsBookingItemRealEntity bookingItem;
-
-    @Version
-    private int version;
-
-    @Column(name = "assetjson")
-    private String assetJson;
-
-    @Setter
-    @Column(name = "statusmessage")
-    private String statusMessage;
-
-    public BookingItemCreatedEventEntity(
-            @NotNull final HsBookingItemRealEntity newBookingItem,
-            final String assetJson) {
-        this.bookingItem = newBookingItem;
-        this.assetJson = assetJson;
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/booking/item/BookingItemCreatedEventRepository.java

@@ -1,12 +0,0 @@
-package net.hostsharing.hsadminng.hs.booking.item;
-
-import org.springframework.data.repository.Repository;
-
-import java.util.UUID;
-
-public interface BookingItemCreatedEventRepository extends Repository<BookingItemCreatedEventEntity, UUID> {
-
-    BookingItemCreatedEventEntity save(HsBookingItemRealEntity current);
-
-    BookingItemCreatedEventEntity findByBookingItem(HsBookingItemRealEntity newBookingItem);
-}

src/main/java/net/hostsharing/hsadminng/hs/booking/item/HsBookingItem.java

@@ -14,7 +14,7 @@ import net.hostsharing.hsadminng.hs.booking.project.HsBookingProject;
 import net.hostsharing.hsadminng.hs.booking.project.HsBookingProjectRealEntity;
 import net.hostsharing.hsadminng.hs.validation.PropertiesProvider;
 import net.hostsharing.hsadminng.mapper.PatchableMapWrapper;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
 import org.hibernate.annotations.Type;

src/main/java/net/hostsharing/hsadminng/hs/booking/item/HsBookingItemController.java

@@ -1,31 +1,26 @@
 package net.hostsharing.hsadminng.hs.booking.item;
 
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
 import net.hostsharing.hsadminng.context.Context;
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.api.HsBookingItemsApi;
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingItemInsertResource;
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingItemPatchResource;
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingItemResource;
-import net.hostsharing.hsadminng.hs.booking.item.validators.BookingItemEntitySaveProcessor;
 import net.hostsharing.hsadminng.hs.booking.item.validators.HsBookingItemEntityValidatorRegistry;
-import net.hostsharing.hsadminng.hs.booking.project.HsBookingProjectRealEntity;
 import net.hostsharing.hsadminng.mapper.KeyValueMap;
-import net.hostsharing.hsadminng.mapper.StrictMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.context.ApplicationEventPublisher;
 import org.springframework.http.ResponseEntity;
 import org.springframework.transaction.annotation.Transactional;
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.servlet.mvc.method.annotation.MvcUriComponentsBuilder;
 
+import jakarta.persistence.EntityManager;
+import jakarta.persistence.PersistenceContext;
 import java.time.LocalDate;
 import java.util.List;
 import java.util.UUID;
 import java.util.function.BiConsumer;
 
-import static java.util.Optional.ofNullable;
 import static net.hostsharing.hsadminng.mapper.PostgresDateRange.toPostgresDateRange;
 
 @RestController
@@ -35,19 +30,13 @@ public class HsBookingItemController implements HsBookingItemsApi {
     private Context context;
 
     @Autowired
-    private StrictMapper mapper;
+    private Mapper mapper;
-
-    @Autowired
-    private ApplicationEventPublisher applicationEventPublisher;
 
     @Autowired
     private HsBookingItemRbacRepository bookingItemRepo;
 
-    @Autowired
+    @PersistenceContext
-    private ObjectMapper jsonMapper;
+    private EntityManager em;
-
-    @Autowired
-    private EntityManagerWrapper em;
 
     @Override
     @Transactional(readOnly = true)
@@ -59,7 +48,7 @@ public class HsBookingItemController implements HsBookingItemsApi {
 
         final var entities = bookingItemRepo.findAllByProjectUuid(projectUuid);
 
-        final var resources = mapper.mapList(entities, HsBookingItemResource.class, RBAC_ENTITY_TO_RESOURCE_POSTMAPPER);
+        final var resources = mapper.mapList(entities, HsBookingItemResource.class, ENTITY_TO_RESOURCE_POSTMAPPER);
         return ResponseEntity.ok(resources);
     }
 
@@ -73,22 +62,15 @@ public class HsBookingItemController implements HsBookingItemsApi {
         context.define(currentSubject, assumedRoles);
 
         final var entityToSave = mapper.map(body, HsBookingItemRbacEntity.class, RESOURCE_TO_ENTITY_POSTMAPPER);
-        final var saveProcessor = new BookingItemEntitySaveProcessor(em, entityToSave);
+
-        final var mapped = saveProcessor
+        final var saved = HsBookingItemEntityValidatorRegistry.validated(em, bookingItemRepo.save(entityToSave));
-                .preprocessEntity()
-                .validateEntity()
-                .prepareForSave()
-                .save()
-                .validateContext()
-                .mapUsing(e -> mapper.map(e, HsBookingItemResource.class, ITEM_TO_RESOURCE_POSTMAPPER))
-                .revampProperties();
-        publishSavedEvent(saveProcessor, body);
 
         final var uri =
                 MvcUriComponentsBuilder.fromController(getClass())
                         .path("/api/hs/booking/items/{id}")
-                        .buildAndExpand(mapped.getUuid())
+                        .buildAndExpand(saved.getUuid())
                         .toUri();
+        final var mapped = mapper.map(saved, HsBookingItemResource.class, ENTITY_TO_RESOURCE_POSTMAPPER);
         return ResponseEntity.created(uri).body(mapped);
     }
 
@@ -105,7 +87,7 @@ public class HsBookingItemController implements HsBookingItemsApi {
         result.ifPresent(entity -> em.detach(entity)); // prevent further LAZY-loading
         return result
                 .map(bookingItemEntity -> ResponseEntity.ok(
-                        mapper.map(bookingItemEntity, HsBookingItemResource.class, RBAC_ENTITY_TO_RESOURCE_POSTMAPPER)))
+                        mapper.map(bookingItemEntity, HsBookingItemResource.class, ENTITY_TO_RESOURCE_POSTMAPPER)))
                 .orElseGet(() -> ResponseEntity.notFound().build());
     }
 
@@ -138,34 +120,18 @@ public class HsBookingItemController implements HsBookingItemsApi {
         new HsBookingItemEntityPatcher(current).apply(body);
 
         final var saved = bookingItemRepo.save(HsBookingItemEntityValidatorRegistry.validated(em, current));
-        final var mapped = mapper.map(saved, HsBookingItemResource.class, RBAC_ENTITY_TO_RESOURCE_POSTMAPPER);
+        final var mapped = mapper.map(saved, HsBookingItemResource.class, ENTITY_TO_RESOURCE_POSTMAPPER);
         return ResponseEntity.ok(mapped);
     }
 
-    private void publishSavedEvent(final BookingItemEntitySaveProcessor saveProcessor, final HsBookingItemInsertResource body) {
+    final BiConsumer<HsBookingItemRbacEntity, HsBookingItemResource> ENTITY_TO_RESOURCE_POSTMAPPER = (entity, resource) -> {
-        try {
-            final var bookingItemRealEntity = em.getReference(HsBookingItemRealEntity.class, saveProcessor.getEntity().getUuid());
-            applicationEventPublisher.publishEvent(new BookingItemCreatedAppEvent(
-                    this, bookingItemRealEntity, jsonMapper.writeValueAsString(body.getHostingAsset())));
-        } catch (JsonProcessingException e) {
-            throw new RuntimeException(e);
-        }
-    }
-
-    final BiConsumer<HsBookingItem, HsBookingItemResource> ITEM_TO_RESOURCE_POSTMAPPER = (entity, resource) -> {
         resource.setValidFrom(entity.getValidity().lower());
         if (entity.getValidity().hasUpperBound()) {
             resource.setValidTo(entity.getValidity().upper().minusDays(1));
         }
     };
 
-    final BiConsumer<HsBookingItemRbacEntity, HsBookingItemResource> RBAC_ENTITY_TO_RESOURCE_POSTMAPPER = ITEM_TO_RESOURCE_POSTMAPPER::accept;
-
     final BiConsumer<HsBookingItemInsertResource, HsBookingItemRbacEntity> RESOURCE_TO_ENTITY_POSTMAPPER = (resource, entity) -> {
-        entity.setProject(em.find(HsBookingProjectRealEntity.class, resource.getProjectUuid()));
-        ofNullable(resource.getParentItemUuid())
-                .map(parentItemUuid -> em.find(HsBookingItemRealEntity.class, parentItemUuid))
-                .ifPresent(entity::setParentItem);
         entity.setValidity(toPostgresDateRange(LocalDate.now(), resource.getValidTo()));
         entity.putResources(KeyValueMap.from(resource.getResources()));
     };

src/main/java/net/hostsharing/hsadminng/hs/booking/item/HsBookingItemRbacEntity.java

@@ -31,7 +31,7 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.SQL.directlyFetc
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 
 @Entity
-@Table(schema = "hs_booking", name = "item_rv")
+@Table(name = "hs_booking_item_rv")
 @SuperBuilder(toBuilder = true)
 @Getter
 @Setter

src/main/java/net/hostsharing/hsadminng/hs/booking/item/HsBookingItemRealEntity.java

@@ -13,7 +13,7 @@ import jakarta.persistence.Table;
 
 
 @Entity
-@Table(schema = "hs_booking", name = "item")
+@Table(name = "hs_booking_item")
 @SuperBuilder(toBuilder = true)
 @Getter
 @Setter

src/main/java/net/hostsharing/hsadminng/hs/booking/item/validators/BookingItemEntitySaveProcessor.java

@@ -1,136 +0,0 @@
-package net.hostsharing.hsadminng.hs.booking.item.validators;
-
-import lombok.Getter;
-import net.hostsharing.hsadminng.errors.MultiValidationException;
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingItemResource;
-import net.hostsharing.hsadminng.hs.booking.item.HsBookingItem;
-import net.hostsharing.hsadminng.hs.validation.HsEntityValidator;
-
-import jakarta.persistence.EntityManager;
-import java.util.Arrays;
-import java.util.Map;
-import java.util.function.Function;
-import java.util.regex.Pattern;
-
-// TODO.refa: introduce common base class with HsHostingAssetEntitySaveProcessor
-/**
- * Wraps the steps of the pararation, validation, mapping and revamp around saving of a HsBookingItem into a readable API.
- */
-public class BookingItemEntitySaveProcessor {
-
-    private final HsEntityValidator<HsBookingItem> validator;
-    private String expectedStep = "preprocessEntity";
-    private final EntityManager em;
-
-    @Getter
-    private HsBookingItem entity;
-
-    @Getter
-    private HsBookingItemResource resource;
-
-    public BookingItemEntitySaveProcessor(final EntityManager em, final HsBookingItem entity) {
-        this.em = em;
-        this.entity = entity;
-        this.validator = HsBookingItemEntityValidatorRegistry.forType(entity.getType());
-    }
-
-    /// initial step allowing to set default values before any validations
-    public BookingItemEntitySaveProcessor preprocessEntity() {
-        step("preprocessEntity", "validateEntity");
-        validator.preprocessEntity(entity);
-        return this;
-    }
-
-    /// validates the entity itself including its properties
-    public BookingItemEntitySaveProcessor validateEntity() {
-        step("validateEntity", "prepareForSave");
-        MultiValidationException.throwIfNotEmpty(validator.validateEntity(entity));
-        return this;
-    }
-
-    // TODO.legacy: remove once the migration of legacy data is done
-    /// validates the entity itself including its properties, but ignoring some error messages for import of legacy data
-    public BookingItemEntitySaveProcessor validateEntityIgnoring(final String... ignoreRegExp) {
-        step("validateEntity", "prepareForSave");
-        final var ignoreRegExpPatterns = Arrays.stream(ignoreRegExp).map(Pattern::compile).toList();
-        MultiValidationException.throwIfNotEmpty(
-                validator.validateEntity(entity).stream()
-                        .filter(error -> ignoreRegExpPatterns.stream().noneMatch(p -> p.matcher(error).matches() ))
-                        .toList()
-        );
-        return this;
-    }
-
-    /// hashing passwords etc.
-    public BookingItemEntitySaveProcessor prepareForSave() {
-        step("prepareForSave", "save");
-        validator.prepareProperties(em, entity);
-        return this;
-    }
-
-    /**
-     * Saves the entity using the given `saveFunction`.
-     *
-     * <p>`validator.postPersist(em, entity)` is NOT called.
-     * If any postprocessing is necessary, the saveFunction has to implement this.</p>
-     * @param saveFunction
-     * @return this
-     */
-    public BookingItemEntitySaveProcessor saveUsing(final Function<HsBookingItem, HsBookingItem> saveFunction) {
-        step("save", "validateContext");
-        entity = saveFunction.apply(entity);
-        return this;
-    }
-
-    /**
-     * Saves the using the `EntityManager`, but does NOT ever merge the entity.
-     *
-     * <p>`validator.postPersist(em, entity)` is called afterwards with the entity guaranteed to be flushed to the database.</p>
-     * @return this
-     */
-    public BookingItemEntitySaveProcessor save() {
-        return saveUsing(e -> {
-            if (!em.contains(entity)) {
-                em.persist(entity);
-            }
-            em.flush(); // makes RbacEntity available as RealEntity if needed
-            validator.postPersist(em, entity);
-            return entity;
-        });
-    }
-
-    /// validates the entity within it's parent and child hierarchy (e.g. totals validators and other limits)
-    public BookingItemEntitySaveProcessor validateContext() {
-        step("validateContext", "mapUsing");
-        return HsEntityValidator.doWithEntityManager(em, () -> {
-            MultiValidationException.throwIfNotEmpty(validator.validateContext(entity));
-            return this;
-        });
-    }
-
-    /// maps entity to JSON resource representation
-    public BookingItemEntitySaveProcessor mapUsing(
-            final Function<HsBookingItem, HsBookingItemResource> mapFunction) {
-        step("mapUsing", "revampProperties");
-        resource = mapFunction.apply(entity);
-        return this;
-    }
-
-    /// removes write-only-properties and ads computed-properties
-    @SuppressWarnings("unchecked")
-    public HsBookingItemResource revampProperties() {
-        step("revampProperties", null);
-        final var revampedProps = validator.revampProperties(em, entity, (Map<String, Object>) resource.getResources());
-        resource.setResources(revampedProps);
-        return resource;
-    }
-
-    // Makes sure that the steps are called in the correct order.
-    // Could also be implemented using an interface per method, but that seems exaggerated.
-    private void step(final String current, final String next) {
-        if (!expectedStep.equals(current)) {
-            throw new IllegalStateException("expected " + expectedStep + " but got " + current);
-        }
-        expectedStep = next;
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/booking/item/validators/HsBookingItemEntityValidatorRegistry.java

@@ -48,11 +48,10 @@ public class HsBookingItemEntityValidatorRegistry {
     }
 
     public static List<String> doValidate(final EntityManager em, final HsBookingItem bookingItem) {
-        final var bookingItemValidator = HsBookingItemEntityValidatorRegistry.forType(bookingItem.getType());
         return HsEntityValidator.doWithEntityManager(em, () ->
             HsEntityValidator.sequentiallyValidate(
-                    () -> bookingItemValidator.validateEntity(bookingItem),
+                    () -> HsBookingItemEntityValidatorRegistry.forType(bookingItem.getType()).validateEntity(bookingItem),
-                    () -> bookingItemValidator.validateContext(bookingItem))
+                    () -> HsBookingItemEntityValidatorRegistry.forType(bookingItem.getType()).validateContext(bookingItem))
         );
     }
 

src/main/java/net/hostsharing/hsadminng/hs/booking/item/validators/HsDomainSetupBookingItemValidator.java

@@ -1,4 +1,3 @@
-
 package net.hostsharing.hsadminng.hs.booking.item.validators;
 
 import net.hostsharing.hsadminng.hs.booking.item.HsBookingItem;
@@ -13,16 +12,13 @@ import static net.hostsharing.hsadminng.hs.hosting.asset.validators.Dns.REGISTRA
 import static net.hostsharing.hsadminng.hs.validation.StringProperty.stringProperty;
 
 class HsDomainSetupBookingItemValidator extends HsBookingItemEntityValidator {
-    public static final String DOMAIN_NAME_PROPERTY_NAME = "domainName";
 
     public static final String FQDN_REGEX = "^((?!-)[A-Za-z0-9-]{1,63}(?<!-)\\.)+[A-Za-z]{2,12}";
-    public static final String WEBSPACE_NAME_REGEX = "[a-z][a-z0-9]{2}[0-9]{2}";
+    public static final String DOMAIN_NAME_PROPERTY_NAME = "domainName";
-    public static final String TARGET_UNIX_USER_NAME_REGEX = "^"+WEBSPACE_NAME_REGEX+"$|^"+WEBSPACE_NAME_REGEX+"-[a-z0-9\\._-]+$";
     public static final String VERIFICATION_CODE_PROPERTY_NAME = "verificationCode";
 
     HsDomainSetupBookingItemValidator() {
         super(
-                // TODO.spec: feels wrong
                 stringProperty(DOMAIN_NAME_PROPERTY_NAME).writeOnce()
                         .maxLength(253)
                         .matchesRegEx(FQDN_REGEX).describedAs("is not a (non-top-level) fully qualified domain name")
@@ -49,11 +45,6 @@ class HsDomainSetupBookingItemValidator extends HsBookingItemEntityValidator {
     }
 
     private static String generateVerificationCode(final EntityManager em, final PropertiesProvider propertiesProvider) {
-        final var userDefinedVerificationCode = propertiesProvider.getDirectValue(VERIFICATION_CODE_PROPERTY_NAME, String.class);
-        if (userDefinedVerificationCode != null) {
-            return userDefinedVerificationCode;
-        }
-
         final var alphaNumeric = "ABCDEFGHJKLMNPQRSTUVWXYZ23456789";
         final var secureRandom = new SecureRandom();
         final var sb = new StringBuilder();

src/main/java/net/hostsharing/hsadminng/hs/booking/project/HsBookingProject.java

@@ -3,14 +3,30 @@ package net.hostsharing.hsadminng.hs.booking.project;
 import lombok.*;
 import lombok.experimental.SuperBuilder;
 import net.hostsharing.hsadminng.hs.booking.debitor.HsBookingDebitorEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.hs.office.debitor.HsOfficeDebitorEntity;
+import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRbacEntity;
+import net.hostsharing.hsadminng.rbac.generator.RbacView;
+import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
 
 import jakarta.persistence.*;
+import java.io.IOException;
 import java.util.UUID;
 
 import static java.util.Optional.ofNullable;
+import static net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationType.DEBITOR;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.Column.dependsOnColumn;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.ColumnValue.usingCase;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.ColumnValue.usingDefaultCase;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.GLOBAL;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.Nullable.NOT_NULL;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.Permission.*;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.Role.*;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.SQL.directlyFetchedByDependsOnColumn;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.SQL.fetchedBySql;
+import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 import static net.hostsharing.hsadminng.stringify.Stringify.stringify;
 
 @MappedSuperclass
@@ -50,4 +66,50 @@ public abstract class HsBookingProject implements Stringifyable, BaseEntity<HsBo
         return ofNullable(debitor).map(HsBookingDebitorEntity::toShortString).orElse("D-???????") +
                 ":" + caption;
     }
+
+    public static RbacView rbac() {
+        return rbacViewFor("project", HsBookingProjectRbacEntity.class)
+                .withIdentityView(SQL.query("""
+                        SELECT bookingProject.uuid as uuid, debitorIV.idName || '-' || base.cleanIdentifier(bookingProject.caption) as idName
+                            FROM hs_booking_project bookingProject
+                            JOIN hs_office.debitor_iv debitorIV ON debitorIV.uuid = bookingProject.debitorUuid
+                        """))
+                .withRestrictedViewOrderBy(SQL.expression("caption"))
+                .withUpdatableColumns("version", "caption")
+
+                .importEntityAlias("debitor", HsOfficeDebitorEntity.class, usingDefaultCase(),
+                        dependsOnColumn("debitorUuid"),
+                        directlyFetchedByDependsOnColumn(),
+                        NOT_NULL)
+
+                .importEntityAlias("debitorRel", HsOfficeRelationRbacEntity.class, usingCase(DEBITOR),
+                        dependsOnColumn("debitorUuid"),
+                        fetchedBySql("""
+                                SELECT ${columns}
+                                    FROM hs_office.relation debitorRel
+                                    JOIN hs_office.debitor debitor ON debitor.debitorRelUuid = debitorRel.uuid
+                                    WHERE debitor.uuid = ${REF}.debitorUuid
+                                """),
+                        NOT_NULL)
+                .toRole("debitorRel", ADMIN).grantPermission(INSERT)
+                .toRole(GLOBAL, ADMIN).grantPermission(DELETE)
+
+                .createRole(OWNER, (with) -> {
+                    with.incomingSuperRole("debitorRel", AGENT).unassumed();
+                })
+                .createSubRole(ADMIN, (with) -> {
+                    with.permission(UPDATE);
+                })
+                .createSubRole(AGENT)
+                .createSubRole(TENANT, (with) -> {
+                    with.outgoingSubRole("debitorRel", TENANT);
+                    with.permission(SELECT);
+                })
+
+                .limitDiagramTo("project", "debitorRel", "rbac.global");
+    }
+
+    public static void main(String[] args) throws IOException {
+        rbac().generateWithBaseFileName("6-hs-booking/620-booking-project/6203-hs-booking-project-rbac");
+    }
 }

src/main/java/net/hostsharing/hsadminng/hs/booking/project/HsBookingProjectController.java

@@ -6,7 +6,7 @@ import net.hostsharing.hsadminng.hs.booking.generated.api.v1.api.HsBookingProjec
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingProjectInsertResource;
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingProjectPatchResource;
 import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsBookingProjectResource;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.ResponseEntity;
 import org.springframework.transaction.annotation.Transactional;
@@ -25,7 +25,7 @@ public class HsBookingProjectController implements HsBookingProjectsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsBookingProjectRbacRepository bookingProjectRepo;

src/main/java/net/hostsharing/hsadminng/hs/booking/project/HsBookingProjectRbacEntity.java

@@ -32,7 +32,7 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.SQL.fetchedBySql
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 
 @Entity
-@Table(schema = "hs_booking", name = "project_rv")
+@Table(name = "hs_booking_project_rv")
 @SuperBuilder(toBuilder = true)
 @Getter
 @Setter
@@ -43,7 +43,7 @@ public class HsBookingProjectRbacEntity extends HsBookingProject {
         return rbacViewFor("project", HsBookingProjectRbacEntity.class)
                 .withIdentityView(SQL.query("""
                         SELECT bookingProject.uuid as uuid, debitorIV.idName || '-' || base.cleanIdentifier(bookingProject.caption) as idName
-                            FROM hs_booking.project bookingProject
+                            FROM hs_booking_project bookingProject
                             JOIN hs_office.debitor_iv debitorIV ON debitorIV.uuid = bookingProject.debitorUuid
                         """))
                 .withRestrictedViewOrderBy(SQL.expression("caption"))

src/main/java/net/hostsharing/hsadminng/hs/booking/project/HsBookingProjectRealEntity.java

@@ -10,7 +10,7 @@ import jakarta.persistence.Table;
 
 
 @Entity
-@Table(schema = "hs_booking", name = "project")
+@Table(name = "hs_booking_project")
 @SuperBuilder(toBuilder = true)
 @Getter
 @Setter

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/HsHostingAsset.java

@@ -14,7 +14,7 @@ import net.hostsharing.hsadminng.hs.booking.project.HsBookingProject;
 import net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactRealEntity;
 import net.hostsharing.hsadminng.hs.validation.PropertiesProvider;
 import net.hostsharing.hsadminng.mapper.PatchableMapWrapper;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
 import org.hibernate.annotations.Type;
@@ -89,9 +89,10 @@ public abstract class HsHostingAsset implements Stringifyable, BaseEntity<HsHost
     @JoinColumn(name = "alarmcontactuuid")
     private HsOfficeContactRealEntity alarmContact;
 
+    @Builder.Default
     @OneToMany(cascade = CascadeType.REFRESH, orphanRemoval = true, fetch = FetchType.LAZY)
     @JoinColumn(name = "parentassetuuid", referencedColumnName = "uuid")
-    private List<HsHostingAssetRealEntity> subHostingAssets;
+    private List<HsHostingAssetRealEntity> subHostingAssets = new ArrayList<>();
 
     @Column(name = "identifier")
     private String identifier; // e.g. vm1234, xyz00, example.org, xyz00_abc
@@ -124,13 +125,6 @@ public abstract class HsHostingAsset implements Stringifyable, BaseEntity<HsHost
         PatchableMapWrapper.of(configWrapper, (newWrapper) -> {configWrapper = newWrapper;}, config).assign(newConfig);
     }
 
-    public List<HsHostingAssetRealEntity> getSubHostingAssets() {
-        if (subHostingAssets == null) {
-            subHostingAssets = new ArrayList<>();
-        }
-        return subHostingAssets;
-    }
-
     @Override
     public PatchableMapWrapper<Object> directProps() {
         return getConfig();

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/HsHostingAssetController.java

@@ -11,7 +11,7 @@ import net.hostsharing.hsadminng.hs.hosting.generated.api.v1.model.HsHostingAsse
 import net.hostsharing.hsadminng.hs.hosting.generated.api.v1.model.HsHostingAssetResource;
 import net.hostsharing.hsadminng.hs.hosting.generated.api.v1.model.HsHostingAssetTypeResource;
 import net.hostsharing.hsadminng.mapper.KeyValueMap;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.ResponseEntity;
@@ -35,7 +35,7 @@ public class HsHostingAssetController implements HsHostingAssetsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsHostingAssetRbacRepository rbacAssetRepo;

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/HsHostingAssetRbacEntity.java

@@ -33,7 +33,7 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.SQL.directlyFetc
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 
 @Entity
-@Table(schema = "hs_hosting", name = "asset_rv")
+@Table(name = "hs_hosting_asset_rv")
 @SuperBuilder(toBuilder = true)
 @Getter
 @Setter

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/HsHostingAssetRbacRepository.java

@@ -25,15 +25,15 @@ public interface HsHostingAssetRbacRepository extends HsHostingAssetRepository<H
                ha.parentassetuuid,
                ha.type,
                ha.version
-            from hs_hosting.asset_rv ha
+            from hs_hosting_asset_rv ha
-                left join hs_booking.item bi on bi.uuid = ha.bookingitemuuid
+                left join hs_booking_item bi on bi.uuid = ha.bookingitemuuid
-                left join hs_hosting.asset pha on pha.uuid = ha.parentassetuuid
+                left join hs_hosting_asset pha on pha.uuid = ha.parentassetuuid
             where (:projectUuid is null or bi.projectuuid=:projectUuid)
               and (:parentAssetUuid is null or pha.uuid=:parentAssetUuid)
               and (:type is null or :type=cast(ha.type as text))
     """, nativeQuery = true)
     // The JPQL query did not generate "left join" but just "join".
-    // I also optimized the query by not using the _rv for hs_booking.item and hs_hosting.asset, only for hs_hosting.asset_rv.
+    // I also optimized the query by not using the _rv for hs_booking_item and hs_hosting_asset, only for hs_hosting_asset_rv.
     List<HsHostingAssetRbacEntity> findAllByCriteriaImpl(UUID projectUuid, UUID parentAssetUuid, String type);
     default List<HsHostingAssetRbacEntity> findAllByCriteria(final UUID projectUuid, final UUID parentAssetUuid, final HsHostingAssetType type) {
         return findAllByCriteriaImpl(projectUuid, parentAssetUuid, HsHostingAssetType.asString(type));

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/HsHostingAssetRealEntity.java

@@ -9,7 +9,7 @@ import jakarta.persistence.Entity;
 import jakarta.persistence.Table;
 
 @Entity
-@Table(schema = "hs_hosting", name = "asset")
+@Table(name = "hs_hosting_asset")
 @SuperBuilder(builderMethodName = "genericBuilder", toBuilder = true)
 @Getter
 @Setter

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/HsHostingAssetRealRepository.java

@@ -3,7 +3,6 @@ package net.hostsharing.hsadminng.hs.hosting.asset;
 import org.springframework.data.jpa.repository.Query;
 import org.springframework.data.repository.Repository;
 
-import jakarta.validation.constraints.NotNull;
 import java.util.List;
 import java.util.Optional;
 import java.util.UUID;
@@ -14,18 +13,6 @@ public interface HsHostingAssetRealRepository extends HsHostingAssetRepository<H
 
     List<HsHostingAssetRealEntity> findByIdentifier(String assetIdentifier);
 
-    default List<HsHostingAssetRealEntity> findByTypeAndIdentifier(@NotNull HsHostingAssetType type,  @NotNull String identifier) {
-        return findByTypeAndIdentifierImpl(type.name(), identifier);
-    }
-
-    @Query("""
-            select ha
-              from HsHostingAssetRealEntity ha
-             where cast(ha.type as String) = :type
-               and ha.identifier = :identifier
-            """)
-    List<HsHostingAssetRealEntity> findByTypeAndIdentifierImpl(@NotNull String type, @NotNull String identifier);
-
     @Query(value = """
         select ha.uuid,
                ha.alarmcontactuuid,
@@ -37,15 +24,15 @@ public interface HsHostingAssetRealRepository extends HsHostingAssetRepository<H
                ha.parentassetuuid,
                ha.type,
                ha.version
-            from hs_hosting.asset_rv ha
+            from hs_hosting_asset_rv ha
-                left join hs_booking.item bi on bi.uuid = ha.bookingitemuuid
+                left join hs_booking_item bi on bi.uuid = ha.bookingitemuuid
-                left join hs_hosting.asset pha on pha.uuid = ha.parentassetuuid
+                left join hs_hosting_asset pha on pha.uuid = ha.parentassetuuid
             where (:projectUuid is null or bi.projectuuid=:projectUuid)
               and (:parentAssetUuid is null or pha.uuid=:parentAssetUuid)
               and (:type is null or :type=cast(ha.type as text))
     """, nativeQuery = true)
     // The JPQL query did not generate "left join" but just "join".
-    // I also optimized the query by not using the _rv for hs_booking.item and hs_hosting.asset, only for hs_hosting.asset_rv.
+    // I also optimized the query by not using the _rv for hs_booking_item and hs_hosting_asset, only for hs_hosting_asset_rv.
     List<HsHostingAssetRealEntity> findAllByCriteriaImpl(UUID projectUuid, UUID parentAssetUuid, String type);
     default List<HsHostingAssetRealEntity> findAllByCriteria(final UUID projectUuid, final UUID parentAssetUuid, final HsHostingAssetType type) {
         return findAllByCriteriaImpl(projectUuid, parentAssetUuid, HsHostingAssetType.asString(type));

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/factories/DomainSetupHostingAssetFactory.java

@@ -1,159 +0,0 @@
-package net.hostsharing.hsadminng.hs.hosting.asset.factories;
-
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetAutoInsertResource;
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetSubInsertResource;
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetTypeResource;
-import net.hostsharing.hsadminng.hs.booking.item.HsBookingItemRealEntity;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAsset;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetRealEntity;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType;
-import net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactRealEntity;
-import net.hostsharing.hsadminng.lambda.Reducer;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
-import net.hostsharing.hsadminng.mapper.ToStringConverter;
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
-
-import jakarta.validation.ValidationException;
-import java.net.IDN;
-import java.util.List;
-import java.util.Optional;
-import java.util.UUID;
-import java.util.function.Function;
-
-import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMAIN_DNS_SETUP;
-import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMAIN_HTTP_SETUP;
-import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMAIN_MBOX_SETUP;
-import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMAIN_SMTP_SETUP;
-
-public class DomainSetupHostingAssetFactory extends HostingAssetFactory {
-
-    public DomainSetupHostingAssetFactory(
-            final EntityManagerWrapper emw,
-            final HsBookingItemRealEntity newBookingItemRealEntity,
-            final HsHostingAssetAutoInsertResource asset,
-            final StandardMapper standardMapper) {
-        super(emw, newBookingItemRealEntity, asset, standardMapper);
-    }
-
-    @Override
-    protected HsHostingAsset create() {
-        final var domainSetupAsset = createDomainSetupAsset(getDomainName());
-        final var subHostingAssets = domainSetupAsset.getSubHostingAssets();
-
-        // TODO.legacy: as long as we need to be compatible, we always do all technical domain-setups
-
-        final var domainHttpSetupAssetResource = findSubHostingAssetResource(HsHostingAssetTypeResource.DOMAIN_HTTP_SETUP);
-        final var assignedToUnixUserAssetEntity = domainHttpSetupAssetResource
-                .map(HsHostingAssetSubInsertResource::getAssignedToAssetUuid)
-                .map(uuid -> emw.find(HsHostingAssetRealEntity.class, uuid))
-                .orElseThrow(() -> new ValidationException("DOMAIN_HTTP_SETUP subAsset with assignedToAssetUuid required in compatibility mode"));
-
-        subHostingAssets.add(
-                createDomainSubSetupAssetEntity(
-                        domainSetupAsset,
-                        DOMAIN_HTTP_SETUP,
-                        builder -> builder
-                                .assignedToAsset(assignedToUnixUserAssetEntity)
-                                .identifier(getDomainName() + "|HTTP")
-                                .caption("HTTP-Setup für " + IDN.toUnicode(getDomainName())))
-        );
-
-        // Do not add to subHostingAssets in compatibility mode, in this case, DNS setup works via file system.
-        // The entity is created just for validation purposes.
-        createDomainSubSetupAssetEntity(
-                domainSetupAsset,
-                DOMAIN_DNS_SETUP,
-                builder -> builder
-                        .assignedToAsset(assignedToUnixUserAssetEntity.getParentAsset())
-                        .identifier(getDomainName() + "|DNS")
-                        .caption("DNS-Setup für " + IDN.toUnicode(getDomainName())));
-
-        subHostingAssets.add(
-            createDomainSubSetupAssetEntity(
-                    domainSetupAsset,
-                    DOMAIN_MBOX_SETUP,
-                    builder -> builder
-                            .assignedToAsset(assignedToUnixUserAssetEntity.getParentAsset())
-                            .identifier(getDomainName() + "|MBOX")
-                            .caption("MBOX-Setup für " + IDN.toUnicode(getDomainName())))
-        );
-
-        subHostingAssets.add(
-            createDomainSubSetupAssetEntity(
-                    domainSetupAsset,
-                    DOMAIN_SMTP_SETUP,
-                    builder -> builder
-                            .assignedToAsset(assignedToUnixUserAssetEntity.getParentAsset())
-                            .identifier(getDomainName() + "|SMTP")
-                            .caption("SMTP-Setup für " + IDN.toUnicode(getDomainName())))
-        );
-
-        return domainSetupAsset;
-    }
-
-    private HsHostingAssetRealEntity createDomainSetupAsset(final String domainName) {
-        return HsHostingAssetRealEntity.builder()
-                .bookingItem(fromBookingItem)
-                .type(HsHostingAssetType.DOMAIN_SETUP)
-                .identifier(domainName)
-                .caption(asset.getCaption() != null ? asset.getCaption() : domainName)
-                .alarmContact(ref(HsOfficeContactRealEntity.class, asset.getAlarmContactUuid()))
-                // the sub-hosting-assets get added later
-                .build();
-    }
-
-    private HsHostingAssetRealEntity createDomainSubSetupAssetEntity(
-            final HsHostingAssetRealEntity domainSetupAsset,
-            final HsHostingAssetType subAssetType,
-            final Function<HsHostingAssetRealEntity.HsHostingAssetRealEntityBuilder<?, ?>, HsHostingAssetRealEntity.HsHostingAssetRealEntityBuilder<?, ?>> builderTransformer) {
-        final var resourceType = HsHostingAssetTypeResource.valueOf(subAssetType.name());
-
-        final var subAssetResourceOptional = findSubHostingAssetResource(resourceType);
-
-        subAssetResourceOptional.ifPresentOrElse(
-            this::verifyNotOverspecified,
-            () -> { throw new ValidationException("sub-asset of type " + resourceType.name() + " required in legacy mode, but missing"); }
-        );
-
-        return builderTransformer.apply(
-                        HsHostingAssetRealEntity.builder()
-                                .type(subAssetType)
-                                .parentAsset(domainSetupAsset))
-                .build();
-    }
-
-    private Optional<HsHostingAssetSubInsertResource> findSubHostingAssetResource(final HsHostingAssetTypeResource resourceType) {
-        return getSubHostingAssetResources().stream()
-                .filter(ha -> ha.getType() == resourceType)
-                .reduce(Reducer::toSingleElement);
-    }
-
-    // TODO.legacy: while we need to stay compatible, only default values can be used, thus only the type can be specified
-    private void verifyNotOverspecified(final HsHostingAssetSubInsertResource givenSubAssetResource) {
-        final var convert = new ToStringConverter().ignoring("assignedToAssetUuid");
-        final var expectedSubAssetResource = new HsHostingAssetSubInsertResource();
-        expectedSubAssetResource.setType(givenSubAssetResource.getType());
-        if ( !convert.from(givenSubAssetResource).equals(convert.from(expectedSubAssetResource)) ) {
-            throw new ValidationException("sub asset " + givenSubAssetResource.getType() + " is over-specified, in compatibility mode, only default values allowed");
-        }
-
-    }
-
-    private String getDomainName() {
-        return asset.getIdentifier();
-    }
-
-    private List<HsHostingAssetSubInsertResource> getSubHostingAssetResources() {
-        return asset.getSubHostingAssets();
-    }
-
-    @Override
-    protected void persist(final HsHostingAsset newHostingAsset) {
-        super.persist(newHostingAsset);
-        newHostingAsset.getSubHostingAssets().forEach(super::persist);
-    }
-
-    private <T> T ref(final Class<T> entityClass, final UUID uuid) {
-        return uuid != null ? emw.getReference(entityClass, uuid) : null;
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/factories/HostingAssetFactory.java

@@ -1,41 +0,0 @@
-package net.hostsharing.hsadminng.hs.hosting.asset.factories;
-
-import jakarta.validation.ValidationException;
-import lombok.RequiredArgsConstructor;
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetAutoInsertResource;
-import net.hostsharing.hsadminng.hs.booking.item.HsBookingItemRealEntity;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAsset;
-import net.hostsharing.hsadminng.hs.hosting.asset.validators.HostingAssetEntitySaveProcessor;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
-
-
-@RequiredArgsConstructor
-abstract class HostingAssetFactory {
-
-    final EntityManagerWrapper emw;
-    final HsBookingItemRealEntity fromBookingItem;
-    final HsHostingAssetAutoInsertResource asset;
-    final StandardMapper standardMapper;
-
-    protected abstract HsHostingAsset create();
-
-    public String createAndPersist() {
-        try {
-            final HsHostingAsset newHostingAsset = create();
-            persist(newHostingAsset);
-            return null;
-        } catch (final ValidationException exc) {
-            return exc.getMessage();
-        }
-    }
-
-    protected void persist(final HsHostingAsset newHostingAsset) {
-        new HostingAssetEntitySaveProcessor(emw, newHostingAsset)
-                .preprocessEntity()
-                .validateEntity()
-                .prepareForSave()
-                .save()
-                .validateContext();
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/factories/HsBookingItemCreatedListener.java

@@ -1,76 +0,0 @@
-package net.hostsharing.hsadminng.hs.hosting.asset.factories;
-
-import com.fasterxml.jackson.core.JsonProcessingException;
-import com.fasterxml.jackson.databind.ObjectMapper;
-import jakarta.validation.ValidationException;
-import jakarta.validation.constraints.NotNull;
-import lombok.SneakyThrows;
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetAutoInsertResource;
-import net.hostsharing.hsadminng.hs.booking.item.BookingItemCreatedAppEvent;
-import net.hostsharing.hsadminng.hs.booking.item.HsBookingItemRealEntity;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAsset;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.context.ApplicationListener;
-import org.springframework.stereotype.Component;
-
-@Component
-public class HsBookingItemCreatedListener implements ApplicationListener<BookingItemCreatedAppEvent> {
-
-    @Autowired
-    private EntityManagerWrapper emw;
-
-    @Autowired
-    private ObjectMapper jsonMapper;
-
-    @Autowired
-    private StandardMapper standardMapper;
-
-    @Override
-    @SneakyThrows
-    public void onApplicationEvent(@NotNull BookingItemCreatedAppEvent bookingItemCreatedAppEvent) {
-        if (containsAssetJson(bookingItemCreatedAppEvent)) {
-            createRelatedHostingAsset(bookingItemCreatedAppEvent);
-        }
-    }
-
-    private static boolean containsAssetJson(final BookingItemCreatedAppEvent bookingItemCreatedAppEvent) {
-        return bookingItemCreatedAppEvent.getEntity().getAssetJson() != null;
-    }
-
-    private void createRelatedHostingAsset(final BookingItemCreatedAppEvent event) throws JsonProcessingException {
-        final var newBookingItemRealEntity = event.getEntity().getBookingItem();
-        final var asset = jsonMapper.readValue(event.getEntity().getAssetJson(), HsHostingAssetAutoInsertResource.class);
-        final var factory = switch (newBookingItemRealEntity.getType()) {
-            case PRIVATE_CLOUD, CLOUD_SERVER, MANAGED_SERVER ->
-                    forNowNoAutomaticHostingAssetCreationPossible(emw, newBookingItemRealEntity, asset, standardMapper);
-            case MANAGED_WEBSPACE -> new ManagedWebspaceHostingAssetFactory(emw, newBookingItemRealEntity, asset, standardMapper);
-            case DOMAIN_SETUP -> new DomainSetupHostingAssetFactory(emw, newBookingItemRealEntity, asset, standardMapper);
-        };
-        if (factory != null) {
-            final var statusMessage = factory.createAndPersist();
-            // TODO.impl: once we implement retry, we need to amend this code (persist/merge/delete)
-            if (statusMessage != null) {
-                event.getEntity().setStatusMessage(statusMessage);
-                emw.persist(event.getEntity());
-            }
-        }
-    }
-
-    private HostingAssetFactory forNowNoAutomaticHostingAssetCreationPossible(
-            final EntityManagerWrapper emw,
-            final HsBookingItemRealEntity fromBookingItem,
-            final HsHostingAssetAutoInsertResource asset,
-            final StandardMapper standardMapper
-    ) {
-        return new HostingAssetFactory(emw, fromBookingItem, asset, standardMapper) {
-
-            @Override
-            protected HsHostingAsset create() {
-                // TODO.impl: we should validate the asset JSON, but some violations are un-avoidable at that stage
-                throw new ValidationException("waiting for manual setup of hosting asset for booking item of type " + fromBookingItem.getType());
-            }
-        };
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/factories/ManagedWebspaceHostingAssetFactory.java

@@ -1,51 +0,0 @@
-package net.hostsharing.hsadminng.hs.hosting.asset.factories;
-
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetAutoInsertResource;
-import net.hostsharing.hsadminng.hs.booking.generated.api.v1.model.HsHostingAssetTypeResource;
-import net.hostsharing.hsadminng.hs.booking.item.HsBookingItemRealEntity;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAsset;
-import net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetRealEntity;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
-
-import jakarta.validation.ValidationException;
-
-import java.util.Optional;
-
-
-public class ManagedWebspaceHostingAssetFactory extends HostingAssetFactory {
-
-    public ManagedWebspaceHostingAssetFactory(
-            final EntityManagerWrapper emw,
-            final HsBookingItemRealEntity newBookingItemRealEntity,
-            final HsHostingAssetAutoInsertResource asset,
-            final StandardMapper standardMapper) {
-        super(emw, newBookingItemRealEntity, asset, standardMapper);
-    }
-
-    @Override
-    protected HsHostingAsset create() {
-        if (asset.getType() != HsHostingAssetTypeResource.MANAGED_WEBSPACE) {
-            throw new ValidationException("requires MANAGED_WEBSPACE hosting asset, but got " +
-                    Optional.of(asset)
-                            .map(HsHostingAssetAutoInsertResource::getType)
-                            .map(Enum::name)
-                            .orElse(null));
-        }
-        final var managedWebspaceHostingAsset = standardMapper.map(asset, HsHostingAssetRealEntity.class);
-        managedWebspaceHostingAsset.setBookingItem(fromBookingItem);
-        emw.createQuery(
-                "SELECT asset FROM HsHostingAssetRealEntity asset WHERE asset.bookingItem.uuid=:bookingItemUuid",
-                HsHostingAssetRealEntity.class)
-                .setParameter("bookingItemUuid", fromBookingItem.getParentItem().getUuid())
-                .getResultStream().findFirst()
-                .ifPresent(managedWebspaceHostingAsset::setParentAsset);
-
-        return managedWebspaceHostingAsset;
-    }
-
-    @Override
-    protected void persist(final HsHostingAsset newManagedWebspaceHostingAsset) {
-        super.persist(newManagedWebspaceHostingAsset);
-    }
-}

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/validators/HostingAssetEntitySaveProcessor.java

@@ -42,7 +42,7 @@ public class HostingAssetEntitySaveProcessor {
         return this;
     }
 
-    // TODO.legacy: remove once the migration of legacy data is done
+    // TODO.impl: remove once the migration of legacy data is done
     /// validates the entity itself including its properties, but ignoring some error messages for import of legacy data
     public HostingAssetEntitySaveProcessor validateEntityIgnoring(final String... ignoreRegExp) {
         step("validateEntity", "prepareForSave");

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/validators/HsDomainDnsSetupHostingAssetValidator.java

@@ -15,7 +15,7 @@ import static net.hostsharing.hsadminng.hs.validation.BooleanProperty.booleanPro
 import static net.hostsharing.hsadminng.hs.validation.IntegerProperty.integerProperty;
 import static net.hostsharing.hsadminng.hs.validation.StringProperty.stringProperty;
 
-// TODO.legacy: make package private once we've migrated the legacy data
+// TODO.impl: make package private once we've migrated the legacy data
 public class HsDomainDnsSetupHostingAssetValidator extends HostingAssetEntityValidator {
 
     // according to  RFC 1035 (section 5) and RFC 1034
@@ -33,7 +33,7 @@ public class HsDomainDnsSetupHostingAssetValidator extends HostingAssetEntityVal
             RR_REGEX_NAME  + RR_REGEX_IN + RR_REGEX_TTL + RR_RECORD_TYPE + RR_RECORD_DATA + RR_COMMENT;
     public static final String IDENTIFIER_SUFFIX = "|DNS";
 
-    private static List<String> zoneFileErrors = null; // TODO.legacy: remove once legacy data is migrated
+    private static List<String> zoneFileErrors = null; // TODO.impl: remove once legacy data is migrated
 
     HsDomainDnsSetupHostingAssetValidator() {
         super(

src/main/java/net/hostsharing/hsadminng/hs/hosting/asset/validators/HsUnixUserHostingAssetValidator.java

@@ -53,7 +53,7 @@ class HsUnixUserHostingAssetValidator extends HostingAssetEntityValidator {
     }
 
     private static Integer computeUserId(final EntityManager em, final PropertiesProvider propertiesProvider) {
-        final Object result = em.createNativeQuery("SELECT nextval('hs_hosting.asset_unixuser_system_id_seq')", Integer.class)
+        final Object result = em.createNativeQuery("SELECT nextval('hs_hosting_asset_unixuser_system_id_seq')", Integer.class)
                 .getSingleResult();
         return (Integer) result;
     }

src/main/java/net/hostsharing/hsadminng/hs/office/bankaccount/HsOfficeBankAccountController.java

@@ -4,7 +4,7 @@ import net.hostsharing.hsadminng.context.Context;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeBankAccountsApi;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeBankAccountInsertResource;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeBankAccountResource;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.iban4j.BicUtil;
 import org.iban4j.IbanUtil;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -24,7 +24,7 @@ public class HsOfficeBankAccountController implements HsOfficeBankAccountsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeBankAccountRepository bankAccountRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/bankaccount/HsOfficeBankAccountEntity.java

@@ -3,7 +3,7 @@ package net.hostsharing.hsadminng.hs.office.bankaccount;
 import lombok.*;
 import lombok.experimental.FieldNameConstants;
 import net.hostsharing.hsadminng.errors.DisplayAs;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;

src/main/java/net/hostsharing/hsadminng/hs/office/contact/HsOfficeContact.java

@@ -11,7 +11,7 @@ import lombok.experimental.FieldNameConstants;
 import lombok.experimental.SuperBuilder;
 import net.hostsharing.hsadminng.errors.DisplayAs;
 import net.hostsharing.hsadminng.mapper.PatchableMapWrapper;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
 import org.hibernate.annotations.GenericGenerator;

src/main/java/net/hostsharing/hsadminng/hs/office/contact/HsOfficeContactController.java

@@ -1,6 +1,6 @@
 package net.hostsharing.hsadminng.hs.office.contact;
 
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.context.Context;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeContactsApi;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeContactInsertResource;
@@ -26,7 +26,7 @@ public class HsOfficeContactController implements HsOfficeContactsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeContactRbacRepository contactRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/coopassets/HsOfficeCoopAssetsTransactionController.java

@@ -4,7 +4,7 @@ import net.hostsharing.hsadminng.context.Context;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeCoopAssetsApi;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.*;
 import net.hostsharing.hsadminng.errors.MultiValidationException;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.format.annotation.DateTimeFormat;
 import org.springframework.format.annotation.DateTimeFormat.ISO;
@@ -29,7 +29,7 @@ public class HsOfficeCoopAssetsTransactionController implements HsOfficeCoopAsse
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeCoopAssetsTransactionRepository coopAssetsTransactionRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/coopassets/HsOfficeCoopAssetsTransactionEntity.java

@@ -8,7 +8,7 @@ import lombok.NoArgsConstructor;
 import lombok.Setter;
 import net.hostsharing.hsadminng.errors.DisplayAs;
 import net.hostsharing.hsadminng.hs.office.membership.HsOfficeMembershipEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
@@ -34,7 +34,7 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 import static net.hostsharing.hsadminng.stringify.Stringify.stringify;
 
 @Entity
-@Table(schema = "hs_office", name = "coopassettx_rv")
+@Table(schema = "hs_office", name = "coopassetstransaction_rv")
 @Getter
 @Setter
 @Builder

src/main/java/net/hostsharing/hsadminng/hs/office/coopshares/HsOfficeCoopSharesTransactionController.java

@@ -6,7 +6,7 @@ import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeCoopShar
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeCoopSharesTransactionInsertResource;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeCoopSharesTransactionResource;
 import net.hostsharing.hsadminng.errors.MultiValidationException;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.format.annotation.DateTimeFormat;
 import org.springframework.format.annotation.DateTimeFormat.ISO;
@@ -31,7 +31,7 @@ public class HsOfficeCoopSharesTransactionController implements HsOfficeCoopShar
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeCoopSharesTransactionRepository coopSharesTransactionRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/coopshares/HsOfficeCoopSharesTransactionEntity.java

@@ -8,7 +8,7 @@ import lombok.Setter;
 import net.hostsharing.hsadminng.errors.DisplayAs;
 import net.hostsharing.hsadminng.hs.office.membership.HsOfficeMembershipEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
@@ -32,7 +32,7 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 import static net.hostsharing.hsadminng.stringify.Stringify.stringify;
 
 @Entity
-@Table(schema = "hs_office", name = "coopsharetx_rv")
+@Table(schema = "hs_office", name = "coopsharestransaction_rv")
 @Getter
 @Setter
 @Builder

src/main/java/net/hostsharing/hsadminng/hs/office/debitor/HsOfficeDebitorController.java

@@ -7,8 +7,8 @@ import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeDebito
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeDebitorResource;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRealEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRealRepository;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
-import net.hostsharing.hsadminng.persistence.EntityExistsValidator;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import org.apache.commons.lang3.Validate;
 import org.hibernate.Hibernate;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -23,6 +23,7 @@ import jakarta.validation.ValidationException;
 import java.util.List;
 import java.util.UUID;
 
+import static net.hostsharing.hsadminng.errors.DisplayAs.DisplayName;
 import static net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationType.DEBITOR;
 
 @RestController
@@ -33,7 +34,7 @@ public class HsOfficeDebitorController implements HsOfficeDebitorsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeDebitorRepository debitorRepo;
@@ -41,9 +42,6 @@ public class HsOfficeDebitorController implements HsOfficeDebitorsApi {
     @Autowired
     private HsOfficeRelationRealRepository relrealRepo;
 
-    @Autowired
-    private EntityExistsValidator entityValidator;
-
     @PersistenceContext
     private EntityManager em;
 
@@ -86,10 +84,10 @@ public class HsOfficeDebitorController implements HsOfficeDebitorsApi {
         final var entityToSave = mapper.map(body, HsOfficeDebitorEntity.class);
         if ( body.getDebitorRel() != null ) {
             body.getDebitorRel().setType(DEBITOR.name());
-            final var debitorRel = mapper.map("debitorRel.", body.getDebitorRel(), HsOfficeRelationRealEntity.class);
+            final var debitorRel = mapper.map(body.getDebitorRel(), HsOfficeRelationRealEntity.class);
-            entityValidator.validateEntityExists("debitorRel.anchorUuid", debitorRel.getAnchor());
+            validateEntityExists("debitorRel.anchorUuid", debitorRel.getAnchor());
-            entityValidator.validateEntityExists("debitorRel.holderUuid", debitorRel.getHolder());
+            validateEntityExists("debitorRel.holderUuid", debitorRel.getHolder());
-            entityValidator.validateEntityExists("debitorRel.contactUuid", debitorRel.getContact());
+            validateEntityExists("debitorRel.contactUuid", debitorRel.getContact());
             entityToSave.setDebitorRel(relrealRepo.save(debitorRel));
         } else {
             final var debitorRelOptional = relrealRepo.findByUuid(body.getDebitorRelUuid());
@@ -162,4 +160,15 @@ public class HsOfficeDebitorController implements HsOfficeDebitorsApi {
         final var mapped = mapper.map(saved, HsOfficeDebitorResource.class);
         return ResponseEntity.ok(mapped);
     }
+
+    // TODO.impl: extract this to some generally usable class?
+    private <T extends BaseEntity<T>> T validateEntityExists(final String property, final T entitySkeleton) {
+        final var foundEntity = em.find(entitySkeleton.getClass(), entitySkeleton.getUuid());
+        if ( foundEntity == null) {
+            throw new ValidationException("Unable to find " + DisplayName.of(entitySkeleton) + " by " + property + ": " + entitySkeleton.getUuid());
+        }
+
+        //noinspection unchecked
+        return (T) foundEntity;
+    }
 }

src/main/java/net/hostsharing/hsadminng/hs/office/debitor/HsOfficeDebitorEntity.java

@@ -11,7 +11,7 @@ import net.hostsharing.hsadminng.hs.office.partner.HsOfficePartnerEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelation;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRealEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRbacEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 import net.hostsharing.hsadminng.stringify.Stringify;

src/main/java/net/hostsharing/hsadminng/hs/office/membership/HsOfficeMembershipController.java

@@ -5,7 +5,7 @@ import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeMembersh
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeMembershipInsertResource;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeMembershipPatchResource;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeMembershipResource;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.ResponseEntity;
 import org.springframework.transaction.annotation.Transactional;
@@ -24,7 +24,7 @@ public class HsOfficeMembershipController implements HsOfficeMembershipsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeMembershipRepository membershipRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/membership/HsOfficeMembershipEntity.java

@@ -9,7 +9,7 @@ import lombok.NoArgsConstructor;
 import lombok.Setter;
 import net.hostsharing.hsadminng.errors.DisplayAs;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRbacEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.hs.office.partner.HsOfficePartnerEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;

src/main/java/net/hostsharing/hsadminng/hs/office/membership/HsOfficeMembershipEntityPatcher.java

@@ -2,18 +2,18 @@ package net.hostsharing.hsadminng.hs.office.membership;
 
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeMembershipPatchResource;
 import net.hostsharing.hsadminng.mapper.EntityPatcher;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.mapper.OptionalFromJson;
 
 import java.util.Optional;
 
 public class HsOfficeMembershipEntityPatcher implements EntityPatcher<HsOfficeMembershipPatchResource> {
 
-    private final StandardMapper mapper;
+    private final Mapper mapper;
     private final HsOfficeMembershipEntity entity;
 
     public HsOfficeMembershipEntityPatcher(
-            final StandardMapper mapper,
+            final Mapper mapper,
             final HsOfficeMembershipEntity entity) {
         this.mapper = mapper;
         this.entity = entity;

src/main/java/net/hostsharing/hsadminng/hs/office/partner/HsOfficePartnerController.java

@@ -12,8 +12,8 @@ import net.hostsharing.hsadminng.hs.office.person.HsOfficePersonEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRealEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRealRepository;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationType;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
@@ -36,7 +36,7 @@ public class HsOfficePartnerController implements HsOfficePartnersApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficePartnerRepository partnerRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/partner/HsOfficePartnerDetailsEntity.java

@@ -2,7 +2,7 @@ package net.hostsharing.hsadminng.hs.office.partner;
 
 import lombok.*;
 import net.hostsharing.hsadminng.errors.DisplayAs;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 import net.hostsharing.hsadminng.stringify.Stringify;

src/main/java/net/hostsharing/hsadminng/hs/office/partner/HsOfficePartnerEntity.java

@@ -10,7 +10,7 @@ import net.hostsharing.hsadminng.hs.office.contact.HsOfficeContact;
 import net.hostsharing.hsadminng.hs.office.person.HsOfficePersonEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRealEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRbacEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelation;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;

src/main/java/net/hostsharing/hsadminng/hs/office/person/HsOfficePersonController.java

@@ -1,6 +1,6 @@
 package net.hostsharing.hsadminng.hs.office.person;
 
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.context.Context;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficePersonsApi;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficePersonInsertResource;
@@ -23,7 +23,7 @@ public class HsOfficePersonController implements HsOfficePersonsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficePersonRepository personRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/person/HsOfficePersonEntity.java

@@ -3,7 +3,7 @@ package net.hostsharing.hsadminng.hs.office.person;
 import lombok.*;
 import lombok.experimental.FieldNameConstants;
 import net.hostsharing.hsadminng.errors.DisplayAs;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 import net.hostsharing.hsadminng.stringify.Stringify;
@@ -21,7 +21,6 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.Role.*;
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.rbacViewFor;
 import static net.hostsharing.hsadminng.stringify.Stringify.stringify;
 
-// TODO.refa: split HsOfficePersonEntity into Real+Rbac-Entity
 @Entity
 @Table(schema = "hs_office", name = "person_rv")
 @Getter

src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelation.java

@@ -5,7 +5,7 @@ import lombok.experimental.FieldNameConstants;
 import lombok.experimental.SuperBuilder;
 import net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactRealEntity;
 import net.hostsharing.hsadminng.hs.office.person.HsOfficePersonEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;
 

src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java

@@ -5,7 +5,7 @@ import net.hostsharing.hsadminng.hs.office.contact.HsOfficeContactRealRepository
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeRelationsApi;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.*;
 import net.hostsharing.hsadminng.hs.office.person.HsOfficePersonRepository;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.ResponseEntity;
 import org.springframework.transaction.annotation.Transactional;
@@ -28,7 +28,7 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeRelationRbacRepository relationRbacRepo;
@@ -37,7 +37,7 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
     private HsOfficePersonRepository holderRepo;
 
     @Autowired
-    private HsOfficeContactRealRepository realContactRepo;
+    private HsOfficeContactRealRepository contactrealRepo;
 
     @PersistenceContext
     private EntityManager em;
@@ -48,16 +48,11 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
             final String currentSubject,
             final String assumedRoles,
             final UUID personUuid,
-            final HsOfficeRelationTypeResource relationType,
+            final HsOfficeRelationTypeResource relationType) {
-            final String personData,
-            final String contactData) {
         context.define(currentSubject, assumedRoles);
 
-        final List<HsOfficeRelationRbacEntity> entities =
+        final var entities = relationRbacRepo.findRelationRelatedToPersonUuidAndRelationType(personUuid,
-                relationRbacRepo.findRelationRelatedToPersonUuidRelationTypePersonAndContactData(
+                mapper.map(relationType, HsOfficeRelationType.class));
-                        personUuid,
-                        relationType == null ? null : HsOfficeRelationType.valueOf(relationType.name()),
-                        personData, contactData);
 
         final var resources = mapper.mapList(entities, HsOfficeRelationResource.class,
                 RELATION_ENTITY_TO_RESOURCE_POSTMAPPER);
@@ -82,7 +77,7 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
         entityToSave.setHolder(holderRepo.findByUuid(body.getHolderUuid()).orElseThrow(
                 () -> new NoSuchElementException("cannot find Person by holderUuid: " + body.getHolderUuid())
         ));
-        entityToSave.setContact(realContactRepo.findByUuid(body.getContactUuid()).orElseThrow(
+        entityToSave.setContact(contactrealRepo.findByUuid(body.getContactUuid()).orElseThrow(
                 () -> new NoSuchElementException("cannot find Contact by contactUuid: " + body.getContactUuid())
         ));
 
@@ -149,6 +144,7 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi {
         return ResponseEntity.ok(mapped);
     }
 
+
     final BiConsumer<HsOfficeRelationRbacEntity, HsOfficeRelationResource> RELATION_ENTITY_TO_RESOURCE_POSTMAPPER = (entity, resource) -> {
         resource.setAnchor(mapper.map(entity.getAnchor(), HsOfficePersonResource.class));
         resource.setHolder(mapper.map(entity.getHolder(), HsOfficePersonResource.class));

src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationRbacRepository.java

@@ -12,62 +12,26 @@ public interface HsOfficeRelationRbacRepository extends Repository<HsOfficeRelat
 
     Optional<HsOfficeRelationRbacEntity> findByUuid(UUID id);
 
-    @Query(value = """
+    default List<HsOfficeRelationRbacEntity> findRelationRelatedToPersonUuidAndRelationType(@NotNull UUID personUuid, HsOfficeRelationType relationType) {
-            SELECT p.* FROM hs_office.relation_rv AS p
+        return findRelationRelatedToPersonUuidAndRelationTypeString(personUuid, relationType.toString());
-                WHERE p.anchorUuid = :personUuid OR p.holderUuid = :personUuid
-            """, nativeQuery = true)
-    List<HsOfficeRelationRbacEntity> findRelationRelatedToPersonUuid(@NotNull UUID personUuid);
-
-    /**
-     * Finds relations by a conjunction of optional criteria, including anchorPerson, holderPerson and contact data.
-     *      *
-     * @param personUuid the optional UUID of the anchorPerson or holderPerson
-     * @param relationType the type of the relation
-     * @param personData a string to match the persons tradeName, familyName or givenName (use '%' for wildcard), case ignored
-     * @param contactData a string to match the contacts caption, postalAddress, emailAddresses or phoneNumbers (use '%' for wildcard), case ignored
-     * @return a list of (accessible) relations which match all given criteria
-     */
-    default List<HsOfficeRelationRbacEntity> findRelationRelatedToPersonUuidRelationTypePersonAndContactData(
-            final UUID personUuid,
-            final HsOfficeRelationType relationType,
-            final String personData,
-            final String contactData) {
-        return findRelationRelatedToPersonUuidRelationTypePersonAndContactDataImpl(
-                personUuid, toStringOrNull(relationType), toSqlLikeOperand(personData), toSqlLikeOperand(contactData));
     }
 
     @Query(value = """
-            SELECT rel FROM HsOfficeRelationRbacEntity AS rel
+            SELECT p.* FROM hs_office.relation_rv AS p
-                WHERE (:relationType IS NULL OR CAST(rel.type AS String) = :relationType)
+                WHERE p.anchorUuid = :personUuid OR p.holderUuid = :personUuid
-                    AND ( :personUuid IS NULL
+               """, nativeQuery = true)
-                            OR rel.anchor.uuid = :personUuid OR rel.holder.uuid = :personUuid )
+    List<HsOfficeRelationRbacEntity> findRelationRelatedToPersonUuid(@NotNull UUID personUuid);
-                    AND ( :personData IS NULL
+
-                            OR lower(rel.anchor.tradeName) LIKE :personData OR lower(rel.holder.tradeName) LIKE :personData
+    @Query(value = """
-                            OR lower(rel.anchor.familyName) LIKE :personData OR lower(rel.holder.familyName) LIKE :personData
+            SELECT p.* FROM hs_office.relation_rv AS p
-                            OR lower(rel.anchor.givenName) LIKE :personData OR lower(rel.holder.givenName) LIKE :personData )
+                WHERE (:relationType IS NULL OR p.type = cast(:relationType AS HsOfficeRelationType))
-                    AND ( :contactData IS NULL
+                    AND ( p.anchorUuid = :personUuid OR p.holderUuid = :personUuid)
-                            OR lower(rel.contact.caption) LIKE :contactData
+               """, nativeQuery = true)
-                            OR lower(rel.contact.postalAddress) LIKE :contactData
+    List<HsOfficeRelationRbacEntity> findRelationRelatedToPersonUuidAndRelationTypeString(@NotNull UUID personUuid, String relationType);
-                            OR lower(CAST(rel.contact.emailAddresses AS String)) LIKE :contactData
-                            OR lower(CAST(rel.contact.phoneNumbers AS String)) LIKE :contactData )
-            """)
-    List<HsOfficeRelationRbacEntity> findRelationRelatedToPersonUuidRelationTypePersonAndContactDataImpl(
-            final UUID personUuid,
-            final String relationType,
-            final String personData,
-            final String contactData);
 
     HsOfficeRelationRbacEntity save(final HsOfficeRelationRbacEntity entity);
 
     long count();
 
     int deleteByUuid(UUID uuid);
-
-    private static String toSqlLikeOperand(final String text) {
-        return text == null ? null : ("%" + text.toLowerCase() + "%");
-    }
-
-    private static String toStringOrNull(final HsOfficeRelationType relationType) {
-        return relationType == null ? null : relationType.name();
-    }
 }

src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationRealRepository.java

@@ -13,7 +13,7 @@ public interface HsOfficeRelationRealRepository extends Repository<HsOfficeRelat
     Optional<HsOfficeRelationRealEntity> findByUuid(UUID id);
 
     default List<HsOfficeRelationRealEntity> findRelationRelatedToPersonUuidAndRelationType(@NotNull UUID personUuid, HsOfficeRelationType relationType) {
-        return findRelationRelatedToPersonUuidAndRelationTypeString(personUuid, relationType == null ? null : relationType.toString());
+        return findRelationRelatedToPersonUuidAndRelationTypeString(personUuid, relationType.toString());
     }
 
     @Query(value = """
@@ -24,7 +24,7 @@ public interface HsOfficeRelationRealRepository extends Repository<HsOfficeRelat
 
     @Query(value = """
             SELECT p.* FROM hs_office.relation AS p
-                WHERE (:relationType IS NULL OR p.type = cast(:relationType AS hs_office.RelationType))
+                WHERE (:relationType IS NULL OR p.type = cast(:relationType AS HsOfficeRelationType))
                     AND ( p.anchorUuid = :personUuid OR p.holderUuid = :personUuid)
                """, nativeQuery = true)
     List<HsOfficeRelationRealEntity> findRelationRelatedToPersonUuidAndRelationTypeString(@NotNull UUID personUuid, String relationType);

src/main/java/net/hostsharing/hsadminng/hs/office/sepamandate/HsOfficeSepaMandateController.java

@@ -5,7 +5,7 @@ import net.hostsharing.hsadminng.hs.office.generated.api.v1.api.HsOfficeSepaMand
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeSepaMandateInsertResource;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeSepaMandatePatchResource;
 import net.hostsharing.hsadminng.hs.office.generated.api.v1.model.HsOfficeSepaMandateResource;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.ResponseEntity;
 import org.springframework.transaction.annotation.Transactional;
@@ -28,7 +28,7 @@ public class HsOfficeSepaMandateController implements HsOfficeSepaMandatesApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private HsOfficeSepaMandateRepository sepaMandateRepo;

src/main/java/net/hostsharing/hsadminng/hs/office/sepamandate/HsOfficeSepaMandateEntity.java

@@ -7,7 +7,7 @@ import net.hostsharing.hsadminng.errors.DisplayAs;
 import net.hostsharing.hsadminng.hs.office.bankaccount.HsOfficeBankAccountEntity;
 import net.hostsharing.hsadminng.hs.office.debitor.HsOfficeDebitorEntity;
 import net.hostsharing.hsadminng.hs.office.relation.HsOfficeRelationRbacEntity;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.stringify.Stringify;
 import net.hostsharing.hsadminng.stringify.Stringifyable;

src/main/java/net/hostsharing/hsadminng/hs/validation/HsEntityValidator.java

@@ -130,7 +130,7 @@ public abstract class HsEntityValidator<E extends PropertiesProvider> {
     }
 
     public Map<String, Object> revampProperties(final EntityManager em, final E entity, final Map<String, Object> config) {
-        final var copy = config != null ? new HashMap<>(config) : new HashMap();
+        final var copy = new HashMap<>(config);
         stream(propertyValidators).forEach(p -> {
             if (p.isWriteOnly()) {
                 copy.remove(p.propertyName);

src/main/java/net/hostsharing/hsadminng/hs/validation/IntegerProperty.java

@@ -56,10 +56,6 @@ public class IntegerProperty<P extends IntegerProperty<P>> extends ValidatablePr
         return unit;
     }
 
-    public Integer min() {
-        return min;
-    }
-
     public Integer max() {
         return max;
     }

src/main/java/net/hostsharing/hsadminng/hs/validation/PasswordProperty.java

@@ -31,7 +31,7 @@ public class PasswordProperty extends StringProperty<PasswordProperty> {
 
     @Override
     protected void validate(final List<String> result, final String propValue, final PropertiesProvider propProvider) {
-        // TODO.legacy: remove after legacy data is migrated
+        // TODO.impl: remove after legacy data is migrated
         if (HashGenerator.using(hashedUsing).couldBeHash(propValue) && propValue.length() > this.maxLength()) {
             // already hashed => do not validate
             return;

src/main/java/net/hostsharing/hsadminng/hs/validation/StringProperty.java

@@ -3,7 +3,6 @@ package net.hostsharing.hsadminng.hs.validation;
 import lombok.AccessLevel;
 import lombok.Setter;
 import net.hostsharing.hsadminng.mapper.Array;
-import org.apache.commons.lang3.ArrayUtils;
 
 import java.util.Arrays;
 import java.util.List;
@@ -84,15 +83,11 @@ public class StringProperty<P extends StringProperty<P>> extends ValidatableProp
     }
 
     /// predefined values, similar to fixed values in a combobox
-    public P provided(final String firstProvidedValue, final String... moreProvidedValues) {
+    public P provided(final String... provided) {
-        this.provided = ArrayUtils.addAll(new String[]{firstProvidedValue}, moreProvidedValues);
+        this.provided = provided;
         return self();
     }
 
-    public String[] provided() {
-        return this.provided;
-    }
-
     /**
      * The property value is not disclosed in error messages.
      *
@@ -114,11 +109,7 @@ public class StringProperty<P extends StringProperty<P>> extends ValidatableProp
 
     @Override
     protected String display(final String propValue) {
-        return undisclosed
+        return undisclosed ? "provided value" : ("'" + propValue + "'");
-            ? "provided value"
-            : propValue != null
-                ? ("'" + propValue + "'")
-                : null;
     }
 
     @Override

src/main/java/net/hostsharing/hsadminng/lambda/Reducer.java

@@ -1,11 +0,0 @@
-package net.hostsharing.hsadminng.lambda;
-
-import lombok.experimental.UtilityClass;
-
-@UtilityClass
-public class Reducer {
-    public static  <T> T toSingleElement(T ignoredLast, T ignoredNext) {
-        throw new AssertionError("only a single entity expected");
-    }
-
-}

src/main/java/net/hostsharing/hsadminng/mapper/Mapper.java

@@ -1,30 +1,28 @@
 package net.hostsharing.hsadminng.mapper;
 
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
 import org.modelmapper.ModelMapper;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.util.ReflectionUtils;
 
+import jakarta.persistence.EntityManager;
 import jakarta.persistence.ManyToOne;
+import jakarta.persistence.PersistenceContext;
 import jakarta.validation.ValidationException;
 import java.lang.reflect.Field;
 import java.util.List;
 import java.util.function.BiConsumer;
 import java.util.stream.Collectors;
-import java.util.stream.Stream;
 
-import static java.util.Arrays.stream;
 import static net.hostsharing.hsadminng.errors.DisplayAs.DisplayName;
 
 /**
  * A nicer API for ModelMapper.
  */
-abstract class Mapper extends ModelMapper {
+public class Mapper extends ModelMapper {
 
-    EntityManagerWrapper em;
+    @PersistenceContext
+    EntityManager em;
 
-    Mapper(@Autowired final EntityManagerWrapper em) {
+    public Mapper() {
-        this.em = em;
         getConfiguration().setAmbiguityIgnored(true);
     }
 
@@ -47,12 +45,8 @@ abstract class Mapper extends ModelMapper {
 
     @Override
     public <D> D map(final Object source, final Class<D> destinationType) {
-        return map("", source, destinationType);
-    }
-
-    public <D> D map(final String namePrefix, final Object source, final Class<D> destinationType) {
         final var target = super.map(source, destinationType);
-        for (Field f : getDeclaredFieldsIncludingSuperClasses(destinationType)) {
+        for (Field f : destinationType.getDeclaredFields()) {
             if (f.getAnnotation(ManyToOne.class) == null) {
                 continue;
             }
@@ -70,30 +64,18 @@ abstract class Mapper extends ModelMapper {
             if (subEntityUuid == null) {
                 continue;
             }
-            ReflectionUtils.setField(f, target, fetchEntity(namePrefix + f.getName() + ".uuid", f.getType(), subEntityUuid));
+            ReflectionUtils.setField(f, target, findEntityById(f.getType(), subEntityUuid));
         }
         return target;
     }
 
-    private static <D> Field[] getDeclaredFieldsIncludingSuperClasses(final Class<D> destinationType) {
+    private Object findEntityById(final Class<?> entityClass, final Object subEntityUuid) {
-        if (destinationType == null) {
+        // using getReference would be more efficent, but results in very technical error messages
-            return new Field[0];
+        final var entity = em.find(entityClass, subEntityUuid);
-        }
-
-        return Stream.concat(
-                stream(destinationType.getDeclaredFields()),
-                stream(getDeclaredFieldsIncludingSuperClasses(destinationType.getSuperclass())))
-            .toArray(Field[]::new);
-    }
-
-    public <E> E fetchEntity(final String propertyName, final Class<E> entityClass, final Object subEntityUuid) {
-        final var entity = em.getReference(entityClass, subEntityUuid);
         if (entity != null) {
             return entity;
         }
-        throw new ValidationException(
+        throw new ValidationException("Unable to find " + DisplayName.of(entityClass) + " by uuid: " + subEntityUuid);
-                "Unable to find " + DisplayName.of(entityClass) +
-                " by " + propertyName + ": " + subEntityUuid);
     }
 
     public <S, T> T map(final S source, final Class<T> targetClass, final BiConsumer<S, T> postMapper) {
@@ -104,13 +86,4 @@ abstract class Mapper extends ModelMapper {
         postMapper.accept(source, target);
         return target;
     }
-
-    public <S, T> T map(final String namePrefix, final S source, final Class<T> targetClass, final BiConsumer<S, T> postMapper) {
-        if (source == null) {
-            return null;
-        }
-        final var target = map(source, targetClass);
-        postMapper.accept(source, target);
-        return target;
-    }
 }

src/main/java/net/hostsharing/hsadminng/mapper/MapperConfiguration.java

@@ -0,0 +1,13 @@
+package net.hostsharing.hsadminng.mapper;
+
+import org.springframework.context.annotation.Bean;
+import org.springframework.context.annotation.Configuration;
+
+@Configuration
+public class MapperConfiguration {
+
+    @Bean
+    public Mapper modelMapper() {
+        return new Mapper();
+    }
+}

src/main/java/net/hostsharing/hsadminng/mapper/StandardMapper.java

@@ -1,17 +0,0 @@
-package net.hostsharing.hsadminng.mapper;
-
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.stereotype.Component;
-
-/**
- * A nicer API for ModelMapper in standard mode.
- */
-@Component
-public class StandardMapper extends Mapper {
-
-    public StandardMapper(@Autowired final EntityManagerWrapper em) {
-        super(em);
-        getConfiguration().setAmbiguityIgnored(true);
-    }
-}

src/main/java/net/hostsharing/hsadminng/mapper/StrictMapper.java

@@ -1,22 +0,0 @@
-package net.hostsharing.hsadminng.mapper;
-
-import net.hostsharing.hsadminng.persistence.EntityManagerWrapper;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.stereotype.Component;
-
-import static org.modelmapper.convention.MatchingStrategies.STRICT;
-
-/**
- * A nicer API for ModelMapper in strict mode.
- *
- * <p>This makes sure that resource.whateverUuid does not accidentally get mapped to entity.uuid,
- * if resource.uuid does not exist.</p>
- */
-@Component
-public class StrictMapper extends Mapper {
-
-    public StrictMapper(@Autowired final EntityManagerWrapper em) {
-        super(em);
-        getConfiguration().setMatchingStrategy(STRICT);
-    }
-}

src/main/java/net/hostsharing/hsadminng/mapper/ToStringConverter.java

@@ -1,44 +0,0 @@
-package net.hostsharing.hsadminng.mapper;
-
-import java.util.*;
-
-import static java.util.stream.Collectors.joining;
-
-public class ToStringConverter {
-
-    final public Set<String> ignoredFields = new HashSet<>();
-
-    public ToStringConverter ignoring(final String fieldName) {
-        ignoredFields.add(fieldName);
-        return this;
-    }
-
-    public String from(final Object obj) {
-        return "{ " +
-            Arrays.stream(obj.getClass().getDeclaredFields())
-                    .filter(f -> !ignoredFields.contains(f.getName()))
-                    .map(field -> {
-                        try {
-                            field.setAccessible(true);
-                            return field.getName() + ": " + field.get(obj);
-                        } catch (IllegalAccessException e) {
-                            // ignore inaccessible fields
-                            return null;
-                        }
-                    })
-                    .filter(Objects::nonNull)
-                    .collect(joining(", "))
-        + " }";
-    }
-
-    public String from(final Map<?, ?> map) {
-        return "{ "
-            + map.keySet().stream()
-                .filter(key -> !ignoredFields.contains(key.toString()))
-                .sorted()
-                .map(k -> Map.entry(k, map.get(k)))
-                .map(e -> e.getKey() + ": " + e.getValue())
-                .collect(joining(", "))
-            + " }";
-    }
-}

src/main/java/net/hostsharing/hsadminng/persistence/EntityExistsValidator.java

@@ -1,38 +0,0 @@
-package net.hostsharing.hsadminng.persistence;
-
-import net.hostsharing.hsadminng.errors.DisplayAs.DisplayName;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.stereotype.Service;
-
-import jakarta.persistence.Entity;
-import jakarta.validation.ValidationException;
-
-@Service
-public class EntityExistsValidator {
-
-    @Autowired
-    private EntityManagerWrapper em;
-
-    public <T extends BaseEntity<T>> void validateEntityExists(final String property, final T entitySkeleton) {
-        final var foundEntity = em.find(entityClass(entitySkeleton), entitySkeleton.getUuid());
-        if ( foundEntity == null) {
-            throw new ValidationException("Unable to find " + DisplayName.of(entitySkeleton) + " by " + property + ": " + entitySkeleton.getUuid());
-        }
-    }
-
-    private static <T extends BaseEntity<T>> Class<?> entityClass(final T entityOrProxy) {
-        final var entityClass = entityClass(entityOrProxy.getClass());
-        if (entityClass == null) {
-            throw new IllegalArgumentException("@Entity not found in superclass hierarchy of " + entityOrProxy.getClass());
-        }
-        return entityClass;
-    }
-
-    private static Class<?> entityClass(final Class<?> entityOrProxyClass) {
-        return entityOrProxyClass.isAnnotationPresent(Entity.class)
-                ? entityOrProxyClass
-                : entityOrProxyClass.getSuperclass() == null
-                ? null
-                : entityClass(entityOrProxyClass.getSuperclass());
-    }
-}

src/main/java/net/hostsharing/hsadminng/rbac/generator/InsertTriggerGenerator.java

@@ -89,7 +89,7 @@ public class InsertTriggerGenerator {
                     with("superRoleRef", toRoleDescriptor(g.getSuperRoleDef(), "row")));
             } else {
                 plPgSql.writeLn("""
-                    -- Granting INSERT INTO hs_hosting.asset permissions to specified role of pre-existing hs_hosting.asset rows slipped,
+                    -- Granting INSERT INTO hs_hosting_asset permissions to specified role of pre-existing hs_hosting_asset rows slipped,
                     -- because there cannot yet be any pre-existing rows in the same table yet.
                     """,
                     with("rawSuperTable", g.getSuperRoleDef().getEntityAlias().getRawTableNameWithSchema()),
@@ -100,7 +100,7 @@ public class InsertTriggerGenerator {
                 /**
                     Grants ${rawSubTable} INSERT permission to specified role of new ${rawSuperTable} rows.
                 */
-                create or replace function ${rawSubTableSchemaPrefix}${rawSubTableShortName}_grants_insert_to_${rawSuperTableShortName}_tf()
+                create or replace function ${rawSubTableSchemaPrefix}new_${rawSubTableShortName}_grants_insert_to_${rawSuperTableShortName}_tf()
                     returns trigger
                     language plpgsql
                     strict as $$
@@ -113,11 +113,11 @@ public class InsertTriggerGenerator {
                     return NEW;
                 end; $$;
                 
-                -- ..._z_... is to put it at the end of after insert triggers, to make sure the roles exist
+                -- z_... is to put it at the end of after insert triggers, to make sure the roles exist
-                create trigger ${rawSubTableName}_z_grants_after_insert_tg
+                create trigger z_new_${rawSubTableName}_grants_after_insert_tg
                     after insert on ${rawSuperTableWithSchema}
                     for each row
-                execute procedure ${rawSubTableSchemaPrefix}${rawSubTableShortName}_grants_insert_to_${rawSuperTableShortName}_tf();
+                execute procedure ${rawSubTableSchemaPrefix}new_${rawSubTableShortName}_grants_insert_to_${rawSuperTableShortName}_tf();
                 """,
                     with("ifConditionThen", g.getSuperRoleDef().getEntityAlias().isCaseDependent()
                             // TODO.impl: .type needs to be dynamically generated
@@ -325,7 +325,7 @@ public class InsertTriggerGenerator {
 
 
     private String toRoleDescriptor(final RbacView.RbacRoleDefinition roleDef, final String ref) {
-        final var functionName = roleDef.descriptorFunctionName();
+        final var functionName = toVar(roleDef);
         if (roleDef.getEntityAlias().isGlobal()) {
             return functionName + "()";
         }

src/main/java/net/hostsharing/hsadminng/rbac/generator/RbacRoleDescriptorsGenerator.java

@@ -19,11 +19,12 @@ public class RbacRoleDescriptorsGenerator {
                 -- ============================================================================
                 --changeset RbacRoleDescriptorsGenerator:${liquibaseTagPrefix}-rbac-ROLE-DESCRIPTORS endDelimiter:--//
                 -- ----------------------------------------------------------------------------
-                call rbac.generateRbacRoleDescriptors('${rawTableName}');
+                call rbac.generateRbacRoleDescriptors('${simpleEntityVarName}', '${rawTableName}');
                 --//
 
                 """,
                 with("liquibaseTagPrefix", liquibaseTagPrefix),
+                with("simpleEntityVarName", simpleEntityVarName),
                 with("rawTableName", rawTableName));
     }
 }

src/main/java/net/hostsharing/hsadminng/rbac/generator/RbacView.java

@@ -2,7 +2,7 @@ package net.hostsharing.hsadminng.rbac.generator;
 
 import lombok.EqualsAndHashCode;
 import lombok.Getter;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import org.reflections.Reflections;
 import org.reflections.scanners.TypeAnnotationsScanner;
 
@@ -29,7 +29,6 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.RbacGrantDefinit
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.RbacSubjectReference.UserRole.CREATOR;
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.SQL.Part.AUTO_FETCH;
 import static org.apache.commons.collections4.SetUtils.hashSet;
-import static org.apache.commons.lang3.StringUtils.capitalize;
 import static org.apache.commons.lang3.StringUtils.uncapitalize;
 
 @Getter
@@ -831,10 +830,6 @@ public class RbacView {
         public boolean isGlobal(final Role role) {
             return entityAlias.isGlobal() && this.role == role;
         }
-
-        public String descriptorFunctionName() {
-            return entityAlias.getRawTableNameWithSchema() + "_" + capitalize(role.name());
-        }
     }
 
     public RbacSubjectReference findUserRef(final RbacSubjectReference.UserRole userRole) {
@@ -987,12 +982,14 @@ public class RbacView {
 
         String getRawTableShortName() {
             // TODO.impl: some combined function and trigger names are too long
-            // maybe we should shorten the table name e.g. hs_office.coopsharetx -> hsof.coopsharetx
+            // maybe we should shorten the table name e.g. hs_office.coopsharestransaction -> hsof.coopsharetx
             // this is just a workaround:
             return getRawTableName()
                     .replace("hs_office.", "hsof.")
-                    .replace("hs_booking.", "hsbk_")
+                    .replace("hs_booking_", "hsbk_")
-                    .replace("hs_hosting.", "hsho_");
+                    .replace("hs_hosting_", "hsho_")
+                    .replace("coopsharestransaction", "coopsharetx")
+                    .replace("coopassetstransaction", "coopassettx");
         }
 
         String dependsOnColumName() {

src/main/java/net/hostsharing/hsadminng/rbac/generator/RolesGrantsAndPermissionsGenerator.java

@@ -20,6 +20,7 @@ import static net.hostsharing.hsadminng.rbac.generator.RbacView.RbacGrantDefinit
 import static net.hostsharing.hsadminng.rbac.generator.RbacView.Role.*;
 import static net.hostsharing.hsadminng.rbac.generator.StringWriter.with;
 import static org.apache.commons.lang3.StringUtils.capitalize;
+import static org.apache.commons.lang3.StringUtils.uncapitalize;
 
 class RolesGrantsAndPermissionsGenerator {
 
@@ -361,10 +362,11 @@ class RolesGrantsAndPermissionsGenerator {
             System.out.println("null");
         }
         if (roleDef.getEntityAlias().isGlobal()) {
-            return "rbac.global_ADMIN()";
+            return "rbac.globalAdmin()";
         }
         final String entityRefVar = entityRefVar(rootRefVar, roleDef.getEntityAlias());
-        return roleDef.descriptorFunctionName() + "(" + entityRefVar + ")";
+        return roleDef.getEntityAlias().simpleName() + capitalize(roleDef.getRole().name())
+                + "(" + entityRefVar + ")";
     }
 
     private String entityRefVar(
@@ -387,8 +389,8 @@ class RolesGrantsAndPermissionsGenerator {
         plPgSql.writeLn();
         plPgSql.writeLn("perform rbac.defineRoleWithGrants(");
         plPgSql.indented(() -> {
-            plPgSql.writeLn("${qualifiedRawTableName)_${roleSuffix}(NEW),"
+            plPgSql.writeLn("${simpleVarName)${roleSuffix}(NEW),"
-                    .replace("${qualifiedRawTableName)", qualifiedRawTableName)
+                    .replace("${simpleVarName)", simpleEntityVarName)
                     .replace("${roleSuffix}", capitalize(role.name())));
 
             generatePermissionsForRole(plPgSql, role);
@@ -591,12 +593,16 @@ class RolesGrantsAndPermissionsGenerator {
             final RbacView.RbacRoleDefinition roleDef,
             final boolean assumed) {
         final var assumedArg = assumed ? "" : ", rbac.unassumed()";
-        return roleDef.descriptorFunctionName() +
+        return toRoleRef(roleDef) +
                 (roleDef.getEntityAlias().isGlobal() ? ( assumed ? "()" : "(rbac.unassumed())")
                         : rbacDef.isRootEntityAlias(roleDef.getEntityAlias()) ? ("(" + triggerRef.name() + ")")
                         : "(" + toTriggerReference(triggerRef, roleDef.getEntityAlias()) + assumedArg + ")");
     }
 
+    private static String toRoleRef(final RbacView.RbacRoleDefinition roleDef) {
+        return uncapitalize(roleDef.getEntityAlias().simpleName()) + capitalize(roleDef.getRole().name());
+    }
+
     private static String toTriggerReference(
             final PostgresTriggerReference triggerRef,
             final RbacView.EntityAlias entityAlias) {

src/main/java/net/hostsharing/hsadminng/rbac/grant/RbacGrantController.java

@@ -1,7 +1,7 @@
 package net.hostsharing.hsadminng.rbac.grant;
 
 import net.hostsharing.hsadminng.context.Context;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.api.RbacGrantsApi;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.model.RbacGrantResource;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -22,7 +22,7 @@ public class RbacGrantController implements RbacGrantsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private RbacGrantRepository rbacGrantRepository;

src/main/java/net/hostsharing/hsadminng/rbac/grant/RbacGrantsDiagramService.java

@@ -30,7 +30,7 @@ public class RbacGrantsDiagramService {
         try (BufferedWriter writer = new BufferedWriter(new FileWriter(fileName))) {
             writer.write("""
                     ### all grants to %s
-
+                                        
                     ```mermaid
                     %s
                     ```
@@ -62,7 +62,7 @@ public class RbacGrantsDiagramService {
     @PersistenceContext
     private EntityManager em;
 
-    private final Map<UUID, List<RawRbacGrantEntity>> descendantsByUuid = new HashMap<>();
+    private Map<UUID, List<RawRbacGrantEntity>> descendantsByUuid = new HashMap<>();
 
     public String allGrantsTocurrentSubject(final EnumSet<Include> includes) {
         final var graph = new LimitedHashSet<RawRbacGrantEntity>();
@@ -231,7 +231,8 @@ public class RbacGrantsDiagramService {
         }
     }
 
-    record Node(String idName, UUID uuid) {
+}
-
+
-    }
+record Node(String idName, UUID uuid) {
+
 }

src/main/java/net/hostsharing/hsadminng/rbac/object/BaseEntity.java

@@ -1,10 +1,11 @@
-package net.hostsharing.hsadminng.persistence;
+package net.hostsharing.hsadminng.rbac.object;
 
 
 import org.hibernate.Hibernate;
 
 import java.util.UUID;
 
+// TODO.impl: this class does not really belong into this package, but there is no right place yet
 public interface BaseEntity<T extends BaseEntity<?>> {
     UUID getUuid();
 

src/main/java/net/hostsharing/hsadminng/rbac/role/RbacRoleController.java

@@ -1,7 +1,7 @@
 package net.hostsharing.hsadminng.rbac.role;
 
 import net.hostsharing.hsadminng.context.Context;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.api.RbacRolesApi;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.model.RbacRoleResource;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -18,7 +18,7 @@ public class RbacRoleController implements RbacRolesApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private RbacRoleRepository rbacRoleRepository;

src/main/java/net/hostsharing/hsadminng/rbac/subject/RbacSubjectController.java

@@ -1,7 +1,7 @@
 package net.hostsharing.hsadminng.rbac.subject;
 
 import net.hostsharing.hsadminng.context.Context;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.api.RbacSubjectsApi;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.model.RbacSubjectPermissionResource;
 import net.hostsharing.hsadminng.rbac.generated.api.v1.model.RbacSubjectResource;
@@ -21,7 +21,7 @@ public class RbacSubjectController implements RbacSubjectsApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private RbacSubjectRepository rbacSubjectRepository;

src/main/java/net/hostsharing/hsadminng/rbac/test/cust/TestCustomerController.java

@@ -1,7 +1,7 @@
 package net.hostsharing.hsadminng.rbac.test.cust;
 
 import net.hostsharing.hsadminng.context.Context;
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.test.generated.api.v1.api.TestCustomersApi;
 import net.hostsharing.hsadminng.test.generated.api.v1.model.TestCustomerResource;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -21,7 +21,7 @@ public class TestCustomerController implements TestCustomersApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private TestCustomerRepository testCustomerRepository;

src/main/java/net/hostsharing/hsadminng/rbac/test/cust/TestCustomerEntity.java

@@ -5,7 +5,7 @@ import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
 import lombok.ToString;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 

src/main/java/net/hostsharing/hsadminng/rbac/test/dom/TestDomainEntity.java

@@ -4,7 +4,7 @@ import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 import net.hostsharing.hsadminng.rbac.test.pac.TestPackageEntity;

src/main/java/net/hostsharing/hsadminng/rbac/test/pac/TestPackageController.java

@@ -1,6 +1,6 @@
 package net.hostsharing.hsadminng.rbac.test.pac;
 
-import net.hostsharing.hsadminng.mapper.StandardMapper;
+import net.hostsharing.hsadminng.mapper.Mapper;
 import net.hostsharing.hsadminng.mapper.OptionalFromJson;
 import net.hostsharing.hsadminng.context.Context;
 import net.hostsharing.hsadminng.test.generated.api.v1.api.TestPackagesApi;
@@ -21,7 +21,7 @@ public class TestPackageController implements TestPackagesApi {
     private Context context;
 
     @Autowired
-    private StandardMapper mapper;
+    private Mapper mapper;
 
     @Autowired
     private TestPackageRepository testPackageRepository;

src/main/java/net/hostsharing/hsadminng/rbac/test/pac/TestPackageEntity.java

@@ -4,7 +4,7 @@ import lombok.AllArgsConstructor;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.Setter;
-import net.hostsharing.hsadminng.persistence.BaseEntity;
+import net.hostsharing.hsadminng.rbac.object.BaseEntity;
 import net.hostsharing.hsadminng.rbac.generator.RbacView;
 import net.hostsharing.hsadminng.rbac.generator.RbacView.SQL;
 import net.hostsharing.hsadminng.rbac.test.cust.TestCustomerEntity;

src/main/resources/api-definition/hs-booking/hs-booking-item-schemas.yaml

@@ -10,7 +10,6 @@ components:
                 - CLOUD_SERVER
                 - MANAGED_SERVER
                 - MANAGED_WEBSPACE
-                - DOMAIN_SETUP
 
         HsBookingItem:
             type: object
@@ -56,10 +55,6 @@ components:
                     type: string
                     format: uuid
                     nullable: false
-                parentItemUuid:
-                    type: string
-                    format: uuid
-                    nullable: false
                 type:
                     $ref: '#/components/schemas/HsBookingItemType'
                 caption:
@@ -73,8 +68,6 @@ components:
                     nullable: true
                 resources:
                     $ref: '#/components/schemas/BookingResources'
-                hostingAsset:
-                    $ref: '../hs-hosting/hs-hosting-asset-schemas.yaml#/components/schemas/HsHostingAssetAutoInsert'
             required:
                 - caption
                 - projectUuid

src/main/resources/api-definition/hs-hosting/hs-hosting-asset-schemas.yaml

@@ -94,68 +94,7 @@ components:
                 - type
                 - identifier
                 - caption
-            additionalProperties: false
+                - config
-
-        HsHostingAssetAutoInsert:
-            type: object
-            properties:
-                parentAssetUuid:
-                    type: string
-                    format: uuid
-                    nullable: true
-                assignedToAssetUuid:
-                    type: string
-                    format: uuid
-                type:
-                    $ref: '#/components/schemas/HsHostingAssetType'
-                identifier:
-                    type: string
-                    minLength: 3
-                    maxLength: 80
-                    nullable: false
-                caption:
-                    type: string
-                    minLength: 3
-                    maxLength: 80
-                    nullable: false
-                alarmContactUuid:
-                    type: string
-                    format: uuid
-                    nullable: true
-                config:
-                    $ref: '#/components/schemas/HsHostingAssetConfiguration'
-                subHostingAssets:
-                    type: array
-                    items:
-                        $ref: '#/components/schemas/HsHostingAssetSubInsert'
-            required:
-                - identifier
-            additionalProperties: false
-
-        HsHostingAssetSubInsert:
-            type: object
-            properties:
-                type:
-                    $ref: '#/components/schemas/HsHostingAssetType'
-                identifier:
-                    type: string
-                    minLength: 3
-                    maxLength: 80
-                    nullable: false
-                caption:
-                    type: string
-                    minLength: 3
-                    maxLength: 80
-                    nullable: false
-                assignedToAssetUuid:
-                    type: string
-                    format: uuid
-                alarmContactUuid:
-                    type: string
-                    format: uuid
-                    nullable: true
-                config:
-                    $ref: '#/components/schemas/HsHostingAssetConfiguration'
             additionalProperties: false
 
         HsHostingAssetConfiguration:

src/main/resources/api-definition/hs-office/hs-office-relations.yaml

@@ -1,8 +1,6 @@
 get:
     summary: Returns a list of (optionally filtered) person relations for a given person.
-    description:
+    description: Returns the list of (optionally filtered) person relations of a given person and which are visible to the current subject or any of it's assumed roles.
-        Returns the list of (optionally filtered) person relations of a given person and which are visible to the current subject or any of it's assumed roles.
-        To match data, all given query parameters must be fulfilled ('and' / logical conjunction).
     tags:
         - hs-office-relations
     operationId: listRelations
@@ -11,7 +9,7 @@ get:
         - $ref: 'auth.yaml#/components/parameters/assumedRoles'
         - name: personUuid
           in: query
-          required: false
+          required: true
           schema:
               type: string
               format: uuid
@@ -22,18 +20,6 @@ get:
           schema:
               $ref: 'hs-office-relation-schemas.yaml#/components/schemas/HsOfficeRelationType'
           description: Prefix of name properties from holder or contact to filter the results.
-        - name: personData
-          in: query
-          required: false
-          schema:
-              type: string
-          description: 'Data from any of these text field in the anchor or holder person: tradeName, familyName, givenName'
-        - name: contactData
-          in: query
-          required: false
-          schema:
-              type: string
-          description: 'Data from any of these text field in the contact: caption, postalAddress, emailAddresses, phoneNumbers'
     responses:
         "200":
             description: OK

src/main/resources/db/changelog/0-base/010-context.sql

@@ -168,6 +168,45 @@ begin
     return cleanIdentifier;
 end; $$;
 
+create or replace function base.findObjectUuidByIdName(objectTable varchar, objectIdName varchar)
+    returns uuid
+    returns null on null input
+    language plpgsql as $$
+declare
+    sql  varchar;
+    uuid uuid;
+begin
+    objectTable := base.pureIdentifier(objectTable);
+    objectIdName := base.pureIdentifier(objectIdName);
+    sql := format('select * from %sUuidByIdName(%L);', objectTable, objectIdName);
+    begin
+        execute sql into uuid;
+    exception
+        when others then
+            raise exception 'function %UuidByIdName(...) not found, add identity view support for table %', objectTable, objectTable;
+    end;
+    return uuid;
+end ; $$;
+
+create or replace function base.findIdNameByObjectUuid(objectTable varchar, objectUuid uuid)
+    returns varchar
+    returns null on null input
+    language plpgsql as $$
+declare
+    sql    varchar;
+    idName varchar;
+begin
+    objectTable := base.pureIdentifier(objectTable);
+    sql := format('select * from %sIdNameByUuid(%L::uuid);', objectTable, objectUuid);
+    begin
+        execute sql into idName;
+    exception
+        when others then
+            raise exception 'function %IdNameByUuid(...) not found, add identity view support for table %', objectTable, objectTable;
+    end;
+    return idName;
+end ; $$;
+
 create or replace function base.currentSubjects()
     returns varchar(1023)[]
     stable -- leakproof

src/main/resources/db/changelog/0-base/011-table-schema-and-name.sql

@@ -9,9 +9,6 @@ create or replace function base.combine_table_schema_and_name(tableSchema name,
     returns text
     language plpgsql as $$
 begin
-    assert  LEFT(tableSchema, 1) <> '"', 'tableSchema must not start with "';
-    assert  LEFT(tableName, 1) <> '"', 'tableName must not start with "';
-
     if tableSchema is null or tableSchema = 'public' or tableSchema = '' then
         return tableName::text;
     else

src/main/resources/db/changelog/0-base/030-historization.sql

@@ -63,6 +63,7 @@ begin
     if (currentSubject is null or currentSubject = '') then
         raise exception 'hsadminng.currentSubject must be defined, please use "SET LOCAL ...;"';
     end if;
+    raise notice 'currentSubject: %', currentSubject;
 
     -- determine task
     currentTask = current_setting('hsadminng.currentTask');
@@ -80,9 +81,8 @@ begin
         "alive" := false;
     end if;
 
-    sql := format('INSERT INTO %3$s_ex VALUES (DEFAULT, pg_current_xact_id(), %1$L, %2$L, $1.*)',
+    sql := format('INSERT INTO %3$I_ex VALUES (DEFAULT, pg_current_xact_id(), %1$L, %2$L, $1.*)',
                   TG_OP, alive, base.combine_table_schema_and_name(tg_table_schema, tg_table_name)::name);
-    -- raise exception 'generated-SQL: %', sql;
     execute sql using "row";
 
     return "row";
@@ -117,12 +117,12 @@ begin
                          '       EXCLUDING CONSTRAINTS' ||
                          '       EXCLUDING STATISTICS' ||
                          ')';
-    -- raise notice 'sql: %', createHistTableSql;
+    raise notice 'sql: %', createHistTableSql;
     execute createHistTableSql;
 
     -- create the historical view
-    viewName = baseTable || '_hv';
+    viewName = quote_ident(format('%s_hv', baseTable));
-    exVersionsTable = baseTable || '_ex';
+    exVersionsTable = quote_ident(format('%s_ex', baseTable));
     baseCols = (select string_agg(quote_ident(column_name), ', ')
                     from information_schema.columns
                     where table_schema = 'public'
@@ -146,14 +146,15 @@ begin
             '         )' ||
             ')',
             viewName, baseCols, exVersionsTable
-        );
+                    );
-    -- raise notice 'generated-sql: %', createViewSQL;
+    raise notice 'sql: %', createViewSQL;
     execute createViewSQL;
 
     -- "-9-" to put the trigger execution after any alphabetically lesser tx-triggers
     createTriggerSQL = 'CREATE TRIGGER tx_9_historicize_tg' ||
                        ' AFTER INSERT OR DELETE OR UPDATE ON ' || baseTable ||
                        '   FOR EACH ROW EXECUTE PROCEDURE base.tx_historicize_tf()';
+    raise notice 'sql: %', createTriggerSQL;
     execute createTriggerSQL;
 
 end; $$;

src/main/resources/db/changelog/1-rbac/1050-rbac-base.sql

@@ -233,50 +233,6 @@ $$;
 --//
 
 
--- ============================================================================
---changeset michael.hoennig:rbac-base-IDNAME-FUNCTIONS endDelimiter:--//
--- ----------------------------------------------------------------------------
-create or replace function rbac.findObjectUuidByIdName(objectTable varchar, objectIdName varchar)
-    returns uuid
-    returns null on null input
-    language plpgsql as $$
-declare
-    sql  varchar;
-    uuid uuid;
-begin
-    objectTable := base.pureIdentifier(objectTable);
-    objectIdName := base.pureIdentifier(objectIdName);
-    sql := format('select * from %s_uuid_by_id_name(%L);', objectTable, objectIdName);
-    begin
-        execute sql into uuid;
-    exception
-        when others then
-            raise exception 'function %_uuid_by_id_name(...) not found, add identity view support for table %', objectTable, objectTable;
-    end;
-    return uuid;
-end ; $$;
-
-create or replace function rbac.findIdNameByObjectUuid(objectTable varchar, objectUuid uuid)
-    returns varchar
-    returns null on null input
-    language plpgsql as $$
-declare
-    sql    varchar;
-    idName varchar;
-begin
-    objectTable := base.pureIdentifier(objectTable);
-    sql := format('select * from %s_id_name_by_uuid(%L::uuid);', objectTable, objectUuid);
-    begin
-        execute sql into idName;
-    exception
-        when others then
-            raise exception 'function %_id_name_by_uuid(...) not found, add identity view support for table %', objectTable, objectTable;
-    end;
-    return idName;
-end ; $$;
---//
-
-
 -- ============================================================================
 --changeset michael.hoennig:rbac-base-ROLE-FUNCTIONS endDelimiter:--//
 -- ----------------------------------------------------------------------------
@@ -306,7 +262,7 @@ begin
     objectTableFromRoleIdName = split_part(roleParts, '#', 1);
     objectNameFromRoleIdName = split_part(roleParts, '#', 2);
     roleTypeFromRoleIdName = split_part(roleParts, '#', 3);
-    objectUuidOfRole = rbac.findObjectUuidByIdName(objectTableFromRoleIdName, objectNameFromRoleIdName);
+    objectUuidOfRole = base.findObjectUuidByIdName(objectTableFromRoleIdName, objectNameFromRoleIdName);
 
     select uuid
         from rbac.role

src/main/resources/db/changelog/1-rbac/1054-rbac-context.sql

@@ -55,7 +55,7 @@ begin
             objectNameToAssume = split_part(roleNameParts, '#', 2);
             roleTypeToAssume = split_part(roleNameParts, '#', 3);
 
-            objectUuidToAssume = rbac.findObjectUuidByIdName(objectTableToAssume, objectNameToAssume);
+            objectUuidToAssume = base.findObjectUuidByIdName(objectTableToAssume, objectNameToAssume);
             if objectUuidToAssume is null then
                 raise exception '[401] object % cannot be found in table % (from roleNameParts=%)', objectNameToAssume, objectTableToAssume, roleNameParts;
             end if;