hostsharing/hs.hsadmin.ng
6
0
Fork 0
Code Pull Requests 2 Activity

fixing the ShareServiceUnitTest as validation was moved to ShareValidator

Browse Source
This commit is contained in:
Michael Hoennig 2019-04-20 09:43:11 +02:00
parent 98f96a72b1
commit 9f95af7547
1 changed files with 19 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
src/test/java/org/hostsharing/hsadminng/service/ShareServiceUnitTest.java
View File

@ -19,6 +19,8 @@ import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.catchThrowableOfType; import static org.assertj.core.api.Assertions.catchThrowableOfType;
import static org.mockito.ArgumentMatchers.same; import static org.mockito.ArgumentMatchers.same;
import static org.mockito.BDDMockito.given; import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doThrow;
// HINT: In IntelliJ IDEA such unit test classes can be created with Shift-Ctrl-T. // HINT: In IntelliJ IDEA such unit test classes can be created with Shift-Ctrl-T.
@ -31,6 +33,9 @@ public class ShareServiceUnitTest {
@Mock @Mock
private ShareRepository shareRepository; private ShareRepository shareRepository;
@Mock
private ShareValidator shareValidator; // needed for @InjectMocks shareService
@Mock @Mock
private ShareMapper shareMapper; private ShareMapper shareMapper;
@ -55,23 +60,11 @@ public class ShareServiceUnitTest {
} }
@Test @Test
public void saveShouldNotUpdateAnyExistingShareTransaction() { public void saveShouldPersistValidTransactions() {
// given
final ShareDTO givenShareDTO = givenShareDTO(anyNonNullId(), ShareAction.SUBSCRIPTION, anyPositiveNumber());
// when
final Throwable throwException = catchThrowableOfType(() -> shareService.save(givenShareDTO), BadRequestAlertException.class);
// then
assertThat(throwException).isEqualToComparingFieldByField(
new BadRequestAlertException("Share transactions are immutable", "share", "shareTransactionImmutable"));
}
@Test
public void saveShouldPersistSubscriptionWithPositiveAmount() {
// given // given
final ShareDTO givenShareDTO = givenShareDTO(null, ShareAction.SUBSCRIPTION, anyPositiveNumber()); final ShareDTO givenShareDTO = givenShareDTO(null, ShareAction.SUBSCRIPTION, anyPositiveNumber());
// HINT: given(...)...will...() can't be used for void methods, in that case use Mockito's do...() methods
doNothing().when(shareValidator).validate(givenShareDTO);
// when // when
final ShareDTO returnedShareDto = shareService.save(givenShareDTO); final ShareDTO returnedShareDto = shareService.save(givenShareDTO);
@ -81,22 +74,24 @@ public class ShareServiceUnitTest {
} }
@Test @Test
public void saveShouldRejectSubscriptionWithNegativeAmount() { public void saveShouldNotPersistInvalidTransactions() {
// given // given
final ShareDTO givenShareDTO = givenShareDTO(null, ShareAction.SUBSCRIPTION, anyNegativeNumber()); final ShareDTO givenShareDTO = givenShareDTO(null, ShareAction.SUBSCRIPTION, anyNegativeNumber());
doThrow(new BadRequestAlertException("Some Dummy Test Violation", "share", "shareInvalidTestDummy")).when(shareValidator).validate(givenShareDTO);
// when // when
final Throwable throwException = catchThrowableOfType(() -> shareService.save(givenShareDTO), BadRequestAlertException.class); final Throwable throwException = catchThrowableOfType(() -> shareService.save(givenShareDTO), BadRequestAlertException.class);
// then // then
assertThat(throwException).isEqualToComparingFieldByField( assertThat(throwException).isEqualToComparingFieldByField(
new BadRequestAlertException("Share subscriptions require a positive quantity", "share", "shareSubscriptionPositivQuantity")); new BadRequestAlertException("Some Dummy Test Violation", "share", "shareInvalidTestDummy"));
} }
@Test @Test
public void saveShouldPersistCancellationWithNegativeAmount() { public void saveShouldUpdateValidTransactions() {
// given // given
final ShareDTO givenShareDTO = givenShareDTO(null, ShareAction.CANCELLATION, anyNegativeNumber()); final ShareDTO givenShareDTO = givenShareDTO(anyNonNullId(), ShareAction.SUBSCRIPTION, anyPositiveNumber());
doNothing().when(shareValidator).validate(givenShareDTO);
// when // when
final ShareDTO returnedShareDto = shareService.save(givenShareDTO); final ShareDTO returnedShareDto = shareService.save(givenShareDTO);
@ -106,16 +101,18 @@ public class ShareServiceUnitTest {
} }
@Test @Test
public void saveShouldRejectCancellationWithPositiveAmount() { public void saveShouldNotUpdateInvalidTransactions() {
// given // given
final ShareDTO givenShareDTO = givenShareDTO(null, ShareAction.CANCELLATION, anyPositiveNumber()); final ShareDTO givenShareDTO = givenShareDTO(anyNonNullId(), ShareAction.SUBSCRIPTION, anyNegativeNumber());
// HINT: given(...) can't be used for void methods, in that case use Mockito's do...() methods
doThrow(new BadRequestAlertException("Some Dummy Test Violation", "share", "shareInvalidTestDummy")).when(shareValidator).validate(givenShareDTO);
// when // when
final Throwable throwException = catchThrowableOfType(() -> shareService.save(givenShareDTO), BadRequestAlertException.class); final Throwable throwException = catchThrowableOfType(() -> shareService.save(givenShareDTO), BadRequestAlertException.class);
// then // then
assertThat(throwException).isEqualToComparingFieldByField( assertThat(throwException).isEqualToComparingFieldByField(
new BadRequestAlertException("Share cancellations require a negative quantity", "share", "shareCancellationNegativeQuantity")); new BadRequestAlertException("Some Dummy Test Violation", "share", "shareInvalidTestDummy"));
} }
// --- only test fixture code below --- // --- only test fixture code below ---