amendmends after code-review
This commit is contained in:
parent
65e01b12a1
commit
8921a28c55
@ -14,12 +14,6 @@ import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMA
|
|||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMAIN_SETUP;
|
import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.DOMAIN_SETUP;
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.MANAGED_WEBSPACE;
|
import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.MANAGED_WEBSPACE;
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.UNIX_USER;
|
import static net.hostsharing.hsadminng.hs.hosting.asset.HsHostingAssetType.UNIX_USER;
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.validators.HsDomainDnsSetupHostingAssetValidator.RR_COMMENT;
|
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.validators.HsDomainDnsSetupHostingAssetValidator.RR_RECORD_DATA;
|
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.validators.HsDomainDnsSetupHostingAssetValidator.RR_RECORD_TYPE;
|
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.validators.HsDomainDnsSetupHostingAssetValidator.RR_REGEX_IN;
|
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.validators.HsDomainDnsSetupHostingAssetValidator.RR_REGEX_NAME;
|
|
||||||
import static net.hostsharing.hsadminng.hs.hosting.asset.validators.HsDomainDnsSetupHostingAssetValidator.RR_REGEX_TTL;
|
|
||||||
import static org.assertj.core.api.Assertions.assertThat;
|
import static org.assertj.core.api.Assertions.assertThat;
|
||||||
|
|
||||||
class HsDomainHttpSetupHostingAssetValidatorUnitTest {
|
class HsDomainHttpSetupHostingAssetValidatorUnitTest {
|
||||||
@ -166,32 +160,4 @@ class HsDomainHttpSetupHostingAssetValidatorUnitTest {
|
|||||||
"'DOMAIN_HTTP_SETUP:example.org|HTTP.config.subdomains' is expected to match any of [(?!-)[A-Za-z0-9-]{1,63}(?<!-)] but '@' does not match",
|
"'DOMAIN_HTTP_SETUP:example.org|HTTP.config.subdomains' is expected to match any of [(?!-)[A-Za-z0-9-]{1,63}(?<!-)] but '@' does not match",
|
||||||
"'DOMAIN_HTTP_SETUP:example.org|HTTP.config.subdomains' is expected to match any of [(?!-)[A-Za-z0-9-]{1,63}(?<!-)] but 'example.com' does not match");
|
"'DOMAIN_HTTP_SETUP:example.org|HTTP.config.subdomains' is expected to match any of [(?!-)[A-Za-z0-9-]{1,63}(?<!-)] but 'example.com' does not match");
|
||||||
}
|
}
|
||||||
|
|
||||||
@Test
|
|
||||||
void validStringMatchesRegEx() {
|
|
||||||
assertThat("@ ").matches(RR_REGEX_NAME);
|
|
||||||
assertThat("ns ").matches(RR_REGEX_NAME);
|
|
||||||
assertThat("example.com. ").matches(RR_REGEX_NAME);
|
|
||||||
|
|
||||||
assertThat("12400 ").matches(RR_REGEX_TTL);
|
|
||||||
assertThat("12400\t\t ").matches(RR_REGEX_TTL);
|
|
||||||
assertThat("12400 \t\t").matches(RR_REGEX_TTL);
|
|
||||||
assertThat("1h30m ").matches(RR_REGEX_TTL);
|
|
||||||
assertThat("30m ").matches(RR_REGEX_TTL);
|
|
||||||
|
|
||||||
assertThat("IN ").matches(RR_REGEX_IN);
|
|
||||||
assertThat("IN\t\t ").matches(RR_REGEX_IN);
|
|
||||||
assertThat("IN \t\t").matches(RR_REGEX_IN);
|
|
||||||
|
|
||||||
assertThat("CNAME ").matches(RR_RECORD_TYPE);
|
|
||||||
assertThat("CNAME\t\t ").matches(RR_RECORD_TYPE);
|
|
||||||
assertThat("CNAME \t\t").matches(RR_RECORD_TYPE);
|
|
||||||
|
|
||||||
assertThat("example.com.").matches(RR_RECORD_DATA);
|
|
||||||
assertThat("123.123.123.123").matches(RR_RECORD_DATA);
|
|
||||||
assertThat("(some more complex argument in parenthesis)").matches(RR_RECORD_DATA);
|
|
||||||
assertThat("\"some more complex argument; including a semicolon\"").matches(RR_RECORD_DATA);
|
|
||||||
|
|
||||||
assertThat("; whatever ; \" really anything").matches(RR_COMMENT);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user