some minor amendments after self-code-review

This commit is contained in:
Michael Hoennig 2024-03-08 08:53:28 +01:00
parent eb7dea54b5
commit 86c0bb3e76
8 changed files with 5 additions and 19 deletions

View File

@ -17,7 +17,6 @@ public class RbacIdentityViewGenerator {
void generateTo(final StringWriter plPgSql) {
plPgSql.writeLn("""
-- ============================================================================
--changeset ${liquibaseTagPrefix}-rbac-IDENTITY-VIEW:1 endDelimiter:--//
-- ----------------------------------------------------------------------------

View File

@ -14,7 +14,6 @@ public class RbacObjectGenerator {
void generateTo(final StringWriter plPgSql) {
plPgSql.writeLn("""
-- ============================================================================
--changeset ${liquibaseTagPrefix}-rbac-OBJECT:1 endDelimiter:--//
-- ----------------------------------------------------------------------------

View File

@ -20,7 +20,6 @@ public class RbacRestrictedViewGenerator {
void generateTo(final StringWriter plPgSql) {
plPgSql.writeLn("""
-- ============================================================================
--changeset ${liquibaseTagPrefix}-rbac-RESTRICTED-VIEW:1 endDelimiter:--//
-- ----------------------------------------------------------------------------

View File

@ -16,7 +16,6 @@ public class RbacRoleDescriptorsGenerator {
void generateTo(final StringWriter plPgSql) {
plPgSql.writeLn("""
-- ============================================================================
--changeset ${liquibaseTagPrefix}-rbac-ROLE-DESCRIPTORS:1 endDelimiter:--//
-- ----------------------------------------------------------------------------

View File

@ -59,7 +59,7 @@ class RolesGrantsAndPermissionsGenerator {
private void generateInsertTriggerFunction(final StringWriter plPgSql) {
plPgSql.writeLn("""
/*
A Creates the roles, grants and permission for the AFTER INSERT TRIGGER.
Creates the roles, grants and permission for the AFTER INSERT TRIGGER.
*/
create or replace procedure buildRbacSystemFor${simpleEntityName}(

View File

@ -58,7 +58,6 @@ public class TestPackageEntity implements HasUuid {
.toRole("customer", ADMIN).grantPermission("package", INSERT)
.createRole(OWNER, (with) -> {
with.owningUser(CREATOR);
with.incomingSuperRole("customer", ADMIN).unassumed();
with.permission(DELETE);
with.permission(UPDATE);

View File

@ -1,6 +1,5 @@
--liquibase formatted sql
-- This code generated was by RbacViewPostgresGenerator at 2024-03-07T18:03:21.967830771.
-- This code generated was by RbacViewPostgresGenerator at 2024-03-08T08:48:56.112505380.
-- ============================================================================
--changeset test-customer-rbac-OBJECT:1 endDelimiter:--//
@ -9,7 +8,6 @@ call generateRelatedRbacObject('test_customer');
--//
-- ============================================================================
--changeset test-customer-rbac-ROLE-DESCRIPTORS:1 endDelimiter:--//
-- ----------------------------------------------------------------------------
@ -22,7 +20,7 @@ call generateRbacRoleDescriptors('testCustomer', 'test_customer');
-- ----------------------------------------------------------------------------
/*
A Creates the roles, grants and permission for the AFTER INSERT TRIGGER.
Creates the roles, grants and permission for the AFTER INSERT TRIGGER.
*/
create or replace procedure buildRbacSystemForTestCustomer(
@ -101,7 +99,6 @@ create trigger test_customer_insert_permission_check_tg
execute procedure test_customer_insert_permission_missing_tf();
--//
-- ============================================================================
--changeset test-customer-rbac-IDENTITY-VIEW:1 endDelimiter:--//
-- ----------------------------------------------------------------------------
@ -111,7 +108,6 @@ call generateRbacIdentityView('test_customer', $idName$
--//
-- ============================================================================
--changeset test-customer-rbac-RESTRICTED-VIEW:1 endDelimiter:--//
-- ----------------------------------------------------------------------------

View File

@ -1,6 +1,5 @@
--liquibase formatted sql
-- This code generated was by RbacViewPostgresGenerator at 2024-03-07T18:03:22.000977525.
-- This code generated was by RbacViewPostgresGenerator at 2024-03-08T08:48:56.148164198.
-- ============================================================================
--changeset test-package-rbac-OBJECT:1 endDelimiter:--//
@ -9,7 +8,6 @@ call generateRelatedRbacObject('test_package');
--//
-- ============================================================================
--changeset test-package-rbac-ROLE-DESCRIPTORS:1 endDelimiter:--//
-- ----------------------------------------------------------------------------
@ -22,7 +20,7 @@ call generateRbacRoleDescriptors('testPackage', 'test_package');
-- ----------------------------------------------------------------------------
/*
A Creates the roles, grants and permission for the AFTER INSERT TRIGGER.
Creates the roles, grants and permission for the AFTER INSERT TRIGGER.
*/
create or replace procedure buildRbacSystemForTestPackage(
@ -42,7 +40,6 @@ begin
perform createRoleWithGrants(
testPackageOwner(NEW),
permissions => array['DELETE', 'UPDATE'],
userUuids => array[currentUserUuid()],
incomingSuperRoles => array[testCustomerAdmin(newCustomer)]
);
@ -205,7 +202,6 @@ create trigger test_package_insert_permission_check_tg
execute procedure test_package_insert_permission_missing_tf();
--//
-- ============================================================================
--changeset test-package-rbac-IDENTITY-VIEW:1 endDelimiter:--//
-- ----------------------------------------------------------------------------
@ -215,7 +211,6 @@ call generateRbacIdentityView('test_package', $idName$
--//
-- ============================================================================
--changeset test-package-rbac-RESTRICTED-VIEW:1 endDelimiter:--//
-- ----------------------------------------------------------------------------