use-case-test for delete partner - WIP

src/test/java/net/hostsharing/hsadminng/hs/office/debitor/HsOfficeDebitorControllerAcceptanceTest.java

@@ -112,7 +112,7 @@ class HsOfficeDebitorControllerAcceptanceTest extends ContextBasedTestWithCleanu
                           }
                         },
                         "debitorNumber": 1000111,
-                        "debitorNumberSuffix": 11,
+                        "debitorNumberSuffix": "11",
                         "partner": {
                           "partnerNumber": 10001,
                           "partnerRel": {
@@ -167,7 +167,7 @@ class HsOfficeDebitorControllerAcceptanceTest extends ContextBasedTestWithCleanu
                            }
                         },
                         "debitorNumber": 1000212,
-                        "debitorNumberSuffix": 12,
+                        "debitorNumberSuffix": "12",
                         "partner": {
                           "partnerNumber": 10002,
                           "partnerRel": {
@@ -201,7 +201,7 @@ class HsOfficeDebitorControllerAcceptanceTest extends ContextBasedTestWithCleanu
                             }
                         },
                         "debitorNumber": 1000313,
-                        "debitorNumberSuffix": 13,
+                        "debitorNumberSuffix": "13",
                         "partner": {
                           "partnerNumber": 10003,
                           "partnerRel": {
@@ -469,7 +469,7 @@ class HsOfficeDebitorControllerAcceptanceTest extends ContextBasedTestWithCleanu
                              }
                          },
                          "debitorNumber": 1000111,
-                         "debitorNumberSuffix": 11,
+                         "debitorNumberSuffix": "11",
                          "partner": {
                              "partnerNumber": 10001,
                              "partnerRel": {
@@ -581,7 +581,7 @@ class HsOfficeDebitorControllerAcceptanceTest extends ContextBasedTestWithCleanu
                                     "contact": { "caption": "fourth contact" }
                                 },
                                 "debitorNumber": 10004${debitorNumberSuffix},
-                                "debitorNumberSuffix": ${debitorNumberSuffix},
+                                "debitorNumberSuffix": "${debitorNumberSuffix}",
                                 "partner": {
                                     "partnerNumber": 10004,
                                     "partnerRel": {

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/HsOfficeCreatePartnerUseCase.java

@@ -1,27 +1,27 @@
 package net.hostsharing.hsadminng.hs.office.usecases;
 
+import io.restassured.http.ContentType;
 import org.springframework.http.HttpStatus;
 
-import static io.restassured.http.Method.POST;
+class HsOfficeCreatePartnerUseCase extends UseCase {
 
-class HsOfficePartnerUseCase extends UseCase {
+    public HsOfficeCreatePartnerUseCase(final UseCaseTest testSuite) {
-
-    public HsOfficePartnerUseCase(final UseCaseTest testSuite) {
         super(testSuite);
     }
 
-    void shouldCreatePartner() {
+    @Override
+    HttpResponse run() {
 
-        http(POST, "/api/hs/office/persons", usingJsonBody("""
+        httpPost("/api/hs/office/persons", usingJsonBody("""
                 {
                     "personType": "LEGAL_PERSON",
                     "tradeName": "Test AG"
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(HttpStatus.CREATED).expecting(ContentType.JSON)
                 .keepingAs("person:Test AG.uuid");
 
-        http(POST, "/api/hs/office/contacts", usingJsonBody("""
+        httpPost("/api/hs/office/contacts", usingJsonBody("""
                 {
                     "caption": "Test AG - Bord of Directors",
                     "emailAddresses": {
@@ -29,10 +29,10 @@ class HsOfficePartnerUseCase extends UseCase {
                     }
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(HttpStatus.CREATED).expecting(ContentType.JSON)
                 .keepingAs("contact:Test AG - Bord of Directors.uuid");
 
-        http(POST, "/api/hs/office/partners", usingJsonBody("""
+        return httpPost("/api/hs/office/partners", usingJsonBody("""
                 {
                     "partnerNumber": "30003",
                     "partnerRel": {
@@ -46,7 +46,6 @@ class HsOfficePartnerUseCase extends UseCase {
                     }
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(HttpStatus.CREATED).expecting(ContentType.JSON);
-                .keepingAs("partner:Test AG.uuid");
     }
 }

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/HsOfficeDebitorUseCase.java

@@ -1,28 +1,29 @@
 package net.hostsharing.hsadminng.hs.office.usecases;
 
-import org.springframework.http.HttpStatus;
+import static io.restassured.http.ContentType.JSON;
-
+import static org.springframework.http.HttpStatus.CREATED;
-import static io.restassured.http.Method.POST;
 
 class HsOfficeDebitorUseCase extends UseCase {
 
     public HsOfficeDebitorUseCase(final UseCaseTest testSuite) {
         super(testSuite);
+
+        requires("person:Test AG.uuid", () -> new HsOfficeCreatePartnerUseCase(testSuite));
     }
 
-    void shouldCreateSelfDebitorForPartner() {
+    @Override
-
+    HttpResponse run() {
-        http(POST, "/api/hs/office/bankaccounts", usingJsonBody("""
+        httpPost("/api/hs/office/bankaccounts", usingJsonBody("""
                  {
                      "holder": "Test AG - refund bank account",
                      "iban": "DE88100900001234567892",
                      "bic": "BEVODEBB"
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(CREATED).expecting(JSON)
                 .keepingAs("bankaccount:Test AG - refund bank account.uuid");
 
-        http(POST, "/api/hs/office/contacts", usingJsonBody("""
+        httpPost("/api/hs/office/contacts", usingJsonBody("""
                 {
                     "caption": "Test AG - billing department",
                     "emailAddresses": {
@@ -30,10 +31,10 @@ class HsOfficeDebitorUseCase extends UseCase {
                     }
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(CREATED).expecting(JSON)
                 .keepingAs("contact:Test AG - billing department.uuid");
 
-        http(POST, "/api/hs/office/debitors", usingJsonBody("""
+        httpPost("/api/hs/office/debitors", usingJsonBody("""
                 {
                     "debitorRel": {
                         "type": "DEBITOR", // FIXME: should be defaulted to DEBITOR
@@ -51,7 +52,8 @@ class HsOfficeDebitorUseCase extends UseCase {
                     "defaultPrefix": "tst"
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(CREATED).expecting(JSON)
                 .keepingAs("debitor:Test AG - Hauptdebitor.uuid");
+        return null;
     }
 }

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/HsOfficeDeletePartnerUseCase.java

@@ -0,0 +1,19 @@
+package net.hostsharing.hsadminng.hs.office.usecases;
+
+import org.springframework.http.HttpStatus;
+
+class HsOfficeDeletePartnerUseCase extends UseCase {
+
+    public HsOfficeDeletePartnerUseCase(final UseCaseTest testSuite) {
+        super(testSuite);
+
+        requires("partner:Test AG for deletetion:uuid", () -> new HsOfficeCreatePartnerUseCase(testSuite));
+    }
+
+    @Override
+    HttpResponse run() {
+        httpDelete("/api/hs/office/partners/" + uuid("partner:Test AG.uuid"))
+                .expecting(HttpStatus.NO_CONTENT);
+        return null;
+    }
+}

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/HsOfficeMembershipUseCase.java

@@ -1,17 +1,17 @@
 package net.hostsharing.hsadminng.hs.office.usecases;
 
+import io.restassured.http.ContentType;
 import org.springframework.http.HttpStatus;
 
-import static io.restassured.http.Method.POST;
-
 class HsOfficeMembershipUseCase extends UseCase {
 
     public HsOfficeMembershipUseCase(final UseCaseTest testSuite) {
         super(testSuite);
     }
 
-    void shouldCreateMembershipForPartner() {
+    @Override
-        http(POST, "/api/hs/office/memberships", usingJsonBody("""
+    HttpResponse run() {
+        httpPost("/api/hs/office/memberships", usingJsonBody("""
                 {
                    "partnerUuid": "${partner:Test AG.uuid}",
                    "memberNumberSuffix": "00",
@@ -19,7 +19,8 @@ class HsOfficeMembershipUseCase extends UseCase {
                    "membershipFeeBillable": "true"
                 }
                 """))
-                .expecting(HttpStatus.CREATED)
+                .expecting(HttpStatus.CREATED).expecting(ContentType.JSON)
                 .keepingAs("membership:Test AG 00.uuid");
+        return null;
     }
 }

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/HsOfficeUseCasesTest.java

@@ -2,11 +2,12 @@ package net.hostsharing.hsadminng.hs.office.usecases;
 
 import net.hostsharing.hsadminng.HsadminNgApplication;
 import net.hostsharing.hsadminng.rbac.test.JpaAttempt;
-import org.junit.jupiter.api.ClassOrderer;
+import org.junit.jupiter.api.MethodOrderer;
 import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.TestClassOrder;
+import org.junit.jupiter.api.TestMethodOrder;
+import org.junit.jupiter.api.extension.ExtendWith;
 import org.springframework.boot.test.context.SpringBootTest;
 
 @SpringBootTest(
@@ -14,24 +15,32 @@ import org.springframework.boot.test.context.SpringBootTest;
         classes = { HsadminNgApplication.class, JpaAttempt.class }
 )
 @Tag("useCaseTest")
-@TestClassOrder(ClassOrderer.OrderAnnotation.class)
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
+@ExtendWith(OrderedDependedTestsExtension.class)
 class HsOfficeUseCasesTest extends UseCaseTest {
 
     @Test
     @Order(1010)
     void shouldCreatePartner() {
-        new HsOfficePartnerUseCase(this).shouldCreatePartner();
+        new HsOfficeCreatePartnerUseCase(this).run()
+                .keepingAs("partner:Test AG.uuid");
+    }
+
+    @Test
+    @Order(1011)
+    void shouldDeletePartner() {
+        new HsOfficeDeletePartnerUseCase(this).run();
     }
 
     @Test
     @Order(1020)
     void shouldCreateSelfDebitorForPartner() {
-        new HsOfficeDebitorUseCase(this).shouldCreateSelfDebitorForPartner();
+        new HsOfficeDebitorUseCase(this).run();
     }
 
     @Test
     @Order(1030)
     void shouldCreateMembershipForPartner() {
-        new HsOfficeMembershipUseCase(this).shouldCreateMembershipForPartner();
+        new HsOfficeMembershipUseCase(this).run();
     }
 }

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/UseCase.java

@@ -2,7 +2,6 @@ package net.hostsharing.hsadminng.hs.office.usecases;
 
 import io.restassured.RestAssured;
 import io.restassured.http.ContentType;
-import io.restassured.http.Method;
 import io.restassured.response.Response;
 import io.restassured.response.ValidatableResponse;
 import org.springframework.http.HttpStatus;
@@ -11,12 +10,13 @@ import java.util.ArrayList;
 import java.util.Map;
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicReference;
+import java.util.function.Supplier;
 import java.util.regex.Pattern;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.hamcrest.Matchers.startsWith;
 
-public class UseCase {
+public abstract class UseCase {
 
     private final UseCaseTest testSuite;
 
@@ -24,24 +24,40 @@ public class UseCase {
         this.testSuite = testSuite;
     }
 
+    void requires(final String alias, final Supplier<UseCase> useCaseSupplier) {
+        if ( !UseCaseTest.aliases.containsKey(alias) ) {
+            useCaseSupplier.get().run().keepingAs(alias);
+        }
+    }
+
+    abstract HttpResponse run();
+
     JsonTemplate usingJsonBody(final String jsonTemplate) {
         return new JsonTemplate(jsonTemplate);
     }
 
-    HttpResponse http(final Method method, final String uriPath, final JsonTemplate bodyJsonTemplate) {
+    HttpResponse httpPost(final String uriPath, final JsonTemplate bodyJsonTemplate) {
-        final var request = RestAssured.given()
+        final var response = RestAssured.given()
                 .header("current-subject", UseCaseTest.RUN_AS_USER)
                 .contentType(ContentType.JSON)
                 .body(bodyJsonTemplate.with(UseCaseTest.aliases))
-                .port(testSuite.port);
+                .port(testSuite.port)
-        final var response =
+                .when().post("http://localhost" + uriPath);
-                switch (method) {
-                    case POST -> request.when().post("http://localhost" + uriPath);
-                    default -> throw new IllegalStateException("HTTP method not implemented yet: " + method);
-                };
         return new HttpResponse(response);
     }
 
+    HttpResponse httpDelete(final String uriPath) {
+        final var response = RestAssured.given()
+                .header("current-subject", UseCaseTest.RUN_AS_USER)
+                .port(testSuite.port)
+                .when().delete("http://localhost" + uriPath);
+        return new HttpResponse(response);
+    }
+
+    UUID uuid(final String alias) {
+        return testSuite.aliases.get(alias);
+    }
+
     static class JsonTemplate {
 
         private final String template;
@@ -50,10 +66,10 @@ public class UseCase {
             this.template = jsonTemplate;
         }
 
-        String with(final Map<String, String> aliases) {
+        String with(final Map<String, UUID> aliases) {
             var partiallyResolved = new AtomicReference<>(template);
             aliases.forEach((k, v) ->
-                    partiallyResolved.set(partiallyResolved.get().replace("${" + k + "}", v)));
+                    partiallyResolved.set(partiallyResolved.get().replace("${" + k + "}", v.toString())));
             verifyAllPlaceholdersResolved(partiallyResolved.get());
             return partiallyResolved.get();
         }
@@ -80,8 +96,12 @@ public class UseCase {
         }
 
         HttpResponse expecting(final HttpStatus httpStatus) {
-            response.statusCode(httpStatus.value())
+            response.statusCode(httpStatus.value());
-                    .contentType(ContentType.JSON);
+            return this;
+        }
+
+        HttpResponse expecting(final ContentType contentType) {
+            response.contentType(contentType);
             return this;
         }
 
@@ -91,7 +111,7 @@ public class UseCase {
             final var newSubjectUuid = UUID.fromString(
                     location.substring(location.lastIndexOf('/') + 1));
             assertThat(newSubjectUuid).isNotNull();
-            UseCaseTest.aliases.put(uuidAliasName, newSubjectUuid.toString());
+            UseCaseTest.aliases.put(uuidAliasName, newSubjectUuid);
         }
     }
 }

src/test/java/net/hostsharing/hsadminng/hs/office/usecases/UseCaseTest.java

@@ -6,17 +6,23 @@ import net.hostsharing.hsadminng.lambda.Reducer;
 import net.hostsharing.hsadminng.rbac.context.ContextBasedTest;
 import net.hostsharing.hsadminng.rbac.test.JpaAttempt;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.extension.BeforeEachCallback;
+import org.junit.jupiter.api.extension.ExtensionContext;
+import org.junit.jupiter.api.extension.TestWatcher;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.web.server.LocalServerPort;
 
 import java.util.HashMap;
 import java.util.Map;
+import java.util.UUID;
+
+import static org.assertj.core.api.Assumptions.assumeThat;
 
 public abstract class UseCaseTest extends ContextBasedTest {
 
     final static String RUN_AS_USER = "superuser-alex@hostsharing.net"; // TODO.test: use global:AGENT when implemented
 
-    final static Map<String, String> aliases = new HashMap<>();
+    final static Map<String, UUID> aliases = new HashMap<>();
 
     @LocalServerPort
     Integer port;
@@ -37,9 +43,23 @@ public abstract class UseCaseTest extends ContextBasedTest {
                             personRepo.findPersonByOptionalNameLike("Hostsharing eG")
                                     .stream()
                                     .map(HsOfficePersonEntity::getUuid)
-                                    .map(Object::toString)
                                     .reduce(Reducer::toSingleElement).orElseThrow());
                 }
         );
     }
 }
+
+class OrderedDependedTestsExtension implements TestWatcher, BeforeEachCallback {
+
+    private static boolean previousTestsPassed = true;
+
+    @Override
+    public void testFailed(final ExtensionContext context, final Throwable cause) {
+        previousTestsPassed = false;
+    }
+
+    @Override
+    public void beforeEach(final ExtensionContext extensionContext) {
+        assumeThat(previousTestsPassed).isTrue();
+    }
+}