diff --git a/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java b/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java index 0ebb0c9b..9910f4b7 100644 --- a/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java +++ b/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationController.java @@ -45,35 +45,31 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi { @Override @Transactional(readOnly = true) public ResponseEntity> listRelations( - final String currentSubject, - final String assumedRoles, - final UUID personUuid, - final HsOfficeRelationTypeResource relationType, - final String personData, - final String contactData) { + final String currentSubject, + final String assumedRoles, + final UUID personUuid, + final HsOfficeRelationTypeResource relationType, + final String personData, + final String contactData) { context.define(currentSubject, assumedRoles); final List entities = - ( personData == null && contactData == null ) - ? relationRbacRepo.findRelationRelatedToPersonUuidRelationTypePersonAndContactData(personUuid, - relationType == null ? null : HsOfficeRelationType.valueOf(relationType.name()), - personData, contactData) - : relationRbacRepo.findRelationRelatedToPersonUuidRelationTypePersonAndContactData( - personUuid, - relationType == null ? null : HsOfficeRelationType.valueOf(relationType.name()), - forLike(personData), forLike(contactData)); + relationRbacRepo.findRelationRelatedToPersonUuidRelationTypePersonAndContactData( + personUuid, + relationType == null ? null : HsOfficeRelationType.valueOf(relationType.name()), + personData, contactData); final var resources = mapper.mapList(entities, HsOfficeRelationResource.class, - RELATION_ENTITY_TO_RESOURCE_POSTMAPPER); + RELATION_ENTITY_TO_RESOURCE_POSTMAPPER); return ResponseEntity.ok(resources); } @Override @Transactional public ResponseEntity addRelation( - final String currentSubject, - final String assumedRoles, - final HsOfficeRelationInsertResource body) { + final String currentSubject, + final String assumedRoles, + final HsOfficeRelationInsertResource body) { context.define(currentSubject, assumedRoles); @@ -81,33 +77,33 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi { entityToSave.setType(HsOfficeRelationType.valueOf(body.getType())); entityToSave.setMark(body.getMark()); entityToSave.setAnchor(holderRepo.findByUuid(body.getAnchorUuid()).orElseThrow( - () -> new NoSuchElementException("cannot find Person by anchorUuid: " + body.getAnchorUuid()) + () -> new NoSuchElementException("cannot find Person by anchorUuid: " + body.getAnchorUuid()) )); entityToSave.setHolder(holderRepo.findByUuid(body.getHolderUuid()).orElseThrow( - () -> new NoSuchElementException("cannot find Person by holderUuid: " + body.getHolderUuid()) + () -> new NoSuchElementException("cannot find Person by holderUuid: " + body.getHolderUuid()) )); entityToSave.setContact(realContactRepo.findByUuid(body.getContactUuid()).orElseThrow( - () -> new NoSuchElementException("cannot find Contact by contactUuid: " + body.getContactUuid()) + () -> new NoSuchElementException("cannot find Contact by contactUuid: " + body.getContactUuid()) )); final var saved = relationRbacRepo.save(entityToSave); final var uri = - MvcUriComponentsBuilder.fromController(getClass()) - .path("/api/hs/office/relations/{id}") - .buildAndExpand(saved.getUuid()) - .toUri(); + MvcUriComponentsBuilder.fromController(getClass()) + .path("/api/hs/office/relations/{id}") + .buildAndExpand(saved.getUuid()) + .toUri(); final var mapped = mapper.map(saved, HsOfficeRelationResource.class, - RELATION_ENTITY_TO_RESOURCE_POSTMAPPER); + RELATION_ENTITY_TO_RESOURCE_POSTMAPPER); return ResponseEntity.created(uri).body(mapped); } @Override @Transactional(readOnly = true) public ResponseEntity getRelationByUuid( - final String currentSubject, - final String assumedRoles, - final UUID relationUuid) { + final String currentSubject, + final String assumedRoles, + final UUID relationUuid) { context.define(currentSubject, assumedRoles); @@ -121,9 +117,9 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi { @Override @Transactional public ResponseEntity deleteRelationByUuid( - final String currentSubject, - final String assumedRoles, - final UUID relationUuid) { + final String currentSubject, + final String assumedRoles, + final UUID relationUuid) { context.define(currentSubject, assumedRoles); final var result = relationRbacRepo.deleteByUuid(relationUuid); @@ -137,10 +133,10 @@ public class HsOfficeRelationController implements HsOfficeRelationsApi { @Override @Transactional public ResponseEntity patchRelation( - final String currentSubject, - final String assumedRoles, - final UUID relationUuid, - final HsOfficeRelationPatchResource body) { + final String currentSubject, + final String assumedRoles, + final UUID relationUuid, + final HsOfficeRelationPatchResource body) { context.define(currentSubject, assumedRoles); diff --git a/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationRbacRepository.java b/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationRbacRepository.java index 69771dcd..96d4b8d5 100644 --- a/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationRbacRepository.java +++ b/src/main/java/net/hostsharing/hsadminng/hs/office/relation/HsOfficeRelationRbacRepository.java @@ -28,10 +28,10 @@ public interface HsOfficeRelationRbacRepository extends Repository findRelationRelatedToPersonUuidRelationTypePersonAndContactData( - UUID personUuid, - HsOfficeRelationType relationType, - String personData, - String contactData) { + final UUID personUuid, + final HsOfficeRelationType relationType, + final String personData, + final String contactData) { return findRelationRelatedToPersonUuidRelationTypePersonAndContactDataImpl( personUuid, toStringOrNull(relationType), toSqlLikeOperand(personData), toSqlLikeOperand(contactData)); } @@ -57,36 +57,6 @@ public interface HsOfficeRelationRbacRepository extends Repository findRelationRelatedToPersonUuidRelationTypePersonAndContactData( - UUID personUuid, - HsOfficeRelationType relationType, - String personData, - String contactData); - HsOfficeRelationRbacEntity save(final HsOfficeRelationRbacEntity entity); long count();