diff --git a/src/main/java/org/hostsharing/hsadminng/HsadminNgApp.java b/src/main/java/org/hostsharing/hsadminng/HsadminNgApp.java index 3b119fde..a0ecca17 100644 --- a/src/main/java/org/hostsharing/hsadminng/HsadminNgApp.java +++ b/src/main/java/org/hostsharing/hsadminng/HsadminNgApp.java @@ -42,9 +42,6 @@ public class HsadminNgApp { @PostConstruct public void initApplication() { - // TODO: remove this hack once proper user roles are implemented - SecurityUtils.addUserRole(null, null, Role.HOSTMASTER); - Collection activeProfiles = Arrays.asList(env.getActiveProfiles()); if (activeProfiles.contains(JHipsterConstants.SPRING_PROFILE_DEVELOPMENT) && activeProfiles.contains(JHipsterConstants.SPRING_PROFILE_PRODUCTION)) { log.error("You have misconfigured your application! It should not run " + @@ -54,6 +51,14 @@ public class HsadminNgApp { log.error("You have misconfigured your application! It should not " + "run with both the 'dev' and 'cloud' profiles at the same time."); } + + // TODO: remove this hack once proper user roles are implemented + if (activeProfiles.contains(JHipsterConstants.SPRING_PROFILE_DEVELOPMENT)) { + // For some strange reasons, HsadminNgApp is created in locally running tests, + // but not on Jenkins, therefore the login user had no rights and many tests + // failed. + SecurityUtils.addUserRole(null, null, Role.HOSTMASTER); + } } /** diff --git a/src/main/java/org/hostsharing/hsadminng/domain/Asset.java b/src/main/java/org/hostsharing/hsadminng/domain/Asset.java index 97410eba..ef7fa87e 100644 --- a/src/main/java/org/hostsharing/hsadminng/domain/Asset.java +++ b/src/main/java/org/hostsharing/hsadminng/domain/Asset.java @@ -22,7 +22,7 @@ public class Asset implements Serializable { private static final long serialVersionUID = 1L; public static final String ENTITY_NAME = "asset"; - + @Id @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "sequenceGenerator") @SequenceGenerator(name = "sequenceGenerator") @@ -59,6 +59,11 @@ public class Asset implements Serializable { return id; } + public Asset id(Long id) { + this.id = id; + return this; + } + public void setId(Long id) { this.id = id; } diff --git a/src/main/java/org/hostsharing/hsadminng/security/SecurityUtils.java b/src/main/java/org/hostsharing/hsadminng/security/SecurityUtils.java index f5a4a1cb..93a40dd8 100644 --- a/src/main/java/org/hostsharing/hsadminng/security/SecurityUtils.java +++ b/src/main/java/org/hostsharing/hsadminng/security/SecurityUtils.java @@ -1,6 +1,8 @@ package org.hostsharing.hsadminng.security; import org.hostsharing.hsadminng.service.accessfilter.Role; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.security.core.context.SecurityContext; import org.springframework.security.core.context.SecurityContextHolder; import org.springframework.security.core.userdetails.UserDetails; @@ -14,6 +16,8 @@ import java.util.Optional; */ public final class SecurityUtils { + private static final Logger log = LoggerFactory.getLogger(SecurityUtils.class); + private static List userRoleAssignments = new ArrayList<>(); private SecurityUtils() { @@ -86,16 +90,18 @@ public final class SecurityUtils { ? ura.role : Role.ANYBODY). reduce(Role.ANYBODY, (r1, r2) -> r1.covers(r2) ? r1 : r2); + log.debug("getLoginUserRoleFor({}, {}) returned {}", onDtoClass, onId, highestRole); return highestRole; } private static boolean matches(Class onDtoClass, Long onId, UserRoleAssignment ura) { - final boolean matches = (ura.onClass == null || onDtoClass == ura.onClass) && (ura.onId == null || ura.onId.equals(onId)); + final boolean matches = (ura.onClass == null || onDtoClass == ura.onClass) && (ura.onId == null || ura.onId.equals(onId)); return matches; } // TODO: depends on https://plan.hostsharing.net/project/hsadmin/us/67?milestone=34 public static void addUserRole(final Class onClass, final Long onId, final Role role) { + log.info("addUserRole({}, {}, {})", onClass, onId, role); userRoleAssignments.add(new UserRoleAssignment(onClass, onId, role)); } diff --git a/src/main/java/org/hostsharing/hsadminng/service/AssetService.java b/src/main/java/org/hostsharing/hsadminng/service/AssetService.java index bc15e0b3..dd60f120 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/AssetService.java +++ b/src/main/java/org/hostsharing/hsadminng/service/AssetService.java @@ -4,6 +4,7 @@ import org.hostsharing.hsadminng.domain.Asset; import org.hostsharing.hsadminng.repository.AssetRepository; import org.hostsharing.hsadminng.service.dto.AssetDTO; import org.hostsharing.hsadminng.service.mapper.AssetMapper; +import org.hostsharing.hsadminng.web.rest.errors.BadRequestAlertException; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.data.domain.Page; @@ -11,6 +12,7 @@ import org.springframework.data.domain.Pageable; import org.springframework.stereotype.Service; import org.springframework.transaction.annotation.Transactional; +import javax.persistence.EntityManager; import java.util.Optional; /** @@ -18,16 +20,19 @@ import java.util.Optional; */ @Service @Transactional -public class AssetService { +public class AssetService implements IdToDtoResolver { private final Logger log = LoggerFactory.getLogger(AssetService.class); + private final EntityManager em; + private final AssetRepository assetRepository; private final AssetMapper assetMapper; private final AssetValidator assetValidator; - public AssetService(AssetRepository assetRepository, AssetMapper assetMapper, AssetValidator assetValidator ) { + public AssetService(final EntityManager em, final AssetRepository assetRepository, final AssetMapper assetMapper, final AssetValidator assetValidator) { + this.em = em; this.assetRepository = assetRepository; this.assetMapper = assetMapper; this.assetValidator = assetValidator; @@ -44,6 +49,8 @@ public class AssetService { assetValidator.validate(assetDTO); Asset asset = assetMapper.toEntity(assetDTO); asset = assetRepository.save(asset); + em.flush(); + em.refresh(asset); return assetMapper.toDto(asset); } @@ -81,6 +88,7 @@ public class AssetService { */ public void delete(Long id) { log.debug("Request to delete Asset : {}", id); - assetRepository.deleteById(id); + + throw new BadRequestAlertException("Asset transactions are immutable", Asset.ENTITY_NAME, "assetTransactionImmutable"); } } diff --git a/src/main/java/org/hostsharing/hsadminng/service/MembershipService.java b/src/main/java/org/hostsharing/hsadminng/service/MembershipService.java index 473f5d7e..82e365d2 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/MembershipService.java +++ b/src/main/java/org/hostsharing/hsadminng/service/MembershipService.java @@ -12,6 +12,7 @@ import org.springframework.data.domain.Pageable; import org.springframework.stereotype.Service; import org.springframework.transaction.annotation.Transactional; +import javax.persistence.EntityManager; import java.util.Optional; /** @@ -23,15 +24,19 @@ public class MembershipService implements IdToDtoResolver { private final Logger log = LoggerFactory.getLogger(MembershipService.class); + private final EntityManager em; + private final MembershipValidator membershipValidator; private final MembershipRepository membershipRepository; private final MembershipMapper membershipMapper; - public MembershipService(final MembershipValidator membershipValidator, + public MembershipService(final EntityManager em, + final MembershipValidator membershipValidator, final MembershipRepository membershipRepository, final MembershipMapper membershipMapper) { + this.em = em; this.membershipValidator = membershipValidator; this.membershipRepository = membershipRepository; this.membershipMapper = membershipMapper; @@ -50,6 +55,8 @@ public class MembershipService implements IdToDtoResolver { Membership membership = membershipMapper.toEntity(membershipDTO); membership = membershipRepository.save(membership); + em.flush(); + em.refresh(membership); return membershipMapper.toDto(membership); } diff --git a/src/main/java/org/hostsharing/hsadminng/service/ShareService.java b/src/main/java/org/hostsharing/hsadminng/service/ShareService.java index c9ff868b..4fbc8bec 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/ShareService.java +++ b/src/main/java/org/hostsharing/hsadminng/service/ShareService.java @@ -12,6 +12,7 @@ import org.springframework.data.domain.Pageable; import org.springframework.stereotype.Service; import org.springframework.transaction.annotation.Transactional; +import javax.persistence.EntityManager; import java.util.Optional; /** @@ -23,13 +24,16 @@ public class ShareService implements IdToDtoResolver { private final Logger log = LoggerFactory.getLogger(ShareService.class); + private final EntityManager em; + private final ShareRepository shareRepository; private final ShareMapper shareMapper; private final ShareValidator shareValidator; - public ShareService(ShareRepository shareRepository, ShareMapper shareMapper, ShareValidator shareValidator) { + public ShareService(final EntityManager em, final ShareRepository shareRepository, final ShareMapper shareMapper, final ShareValidator shareValidator) { + this.em = em; this.shareRepository = shareRepository; this.shareMapper = shareMapper; this.shareValidator = shareValidator; @@ -48,6 +52,8 @@ public class ShareService implements IdToDtoResolver { Share share = shareMapper.toEntity(shareDTO); share = shareRepository.save(share); + em.flush(); + em.refresh(share); return shareMapper.toDto(share); } diff --git a/src/main/java/org/hostsharing/hsadminng/service/dto/AssetDTO.java b/src/main/java/org/hostsharing/hsadminng/service/dto/AssetDTO.java index d52a535a..cfeb355e 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/dto/AssetDTO.java +++ b/src/main/java/org/hostsharing/hsadminng/service/dto/AssetDTO.java @@ -1,6 +1,11 @@ package org.hostsharing.hsadminng.service.dto; import org.hostsharing.hsadminng.domain.enumeration.AssetAction; +import org.hostsharing.hsadminng.service.AssetService; +import org.hostsharing.hsadminng.service.MembershipService; +import org.hostsharing.hsadminng.service.accessfilter.*; +import org.springframework.boot.jackson.JsonComponent; +import org.springframework.context.ApplicationContext; import javax.validation.constraints.NotNull; import javax.validation.constraints.Size; @@ -12,29 +17,40 @@ import java.util.Objects; /** * A DTO for the Asset entity. */ -public class AssetDTO implements Serializable { +public class AssetDTO implements Serializable, AccessMappings { + @SelfId(resolver = AssetService.class) + @AccessFor(read = Role.ANY_CUSTOMER_USER) private Long id; @NotNull + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private LocalDate documentDate; @NotNull + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private LocalDate valueDate; @NotNull + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private AssetAction action; @NotNull + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private BigDecimal amount; @Size(max = 160) + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = Role.SUPPORTER) private String remark; - + @ParentId(resolver = MembershipService.class) + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private Long membershipId; - private String membershipDisplayReference; + // TODO: these init/update rights actually mean "ignore", we might want to express this in a better way + // background: there is no converter for any display label in DTOs to entity field values anyway + @AccessFor(init=Role.ANYBODY, update = Role.ANYBODY, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) + private String membershipDisplayLabel; public Long getId() { return id; @@ -92,12 +108,12 @@ public class AssetDTO implements Serializable { this.membershipId = membershipId; } - public String getMembershipDisplayReference() { - return membershipDisplayReference; + public String getMembershipDisplayLabel() { + return membershipDisplayLabel; } - public void setMembershipDisplayReference(String membershipDisplayReference) { - this.membershipDisplayReference = membershipDisplayReference; + public void setMembershipDisplayLabel(String membershipDisplayLabel) { + this.membershipDisplayLabel = membershipDisplayLabel; } @Override @@ -131,7 +147,23 @@ public class AssetDTO implements Serializable { ", amount=" + getAmount() + ", remark='" + getRemark() + "'" + ", membership=" + getMembershipId() + - ", membership='" + getMembershipDisplayReference() + "'" + + ", membership='" + getMembershipDisplayLabel() + "'" + "}"; } + + @JsonComponent + public static class AssetJsonSerializer extends JsonSerializerWithAccessFilter { + + public AssetJsonSerializer(final ApplicationContext ctx) { + super(ctx); + } + } + + @JsonComponent + public static class AssetJsonDeserializer extends JsonDeserializerWithAccessFilter { + + public AssetJsonDeserializer(final ApplicationContext ctx) { + super(ctx); + } + } } diff --git a/src/main/java/org/hostsharing/hsadminng/service/dto/CustomerDTO.java b/src/main/java/org/hostsharing/hsadminng/service/dto/CustomerDTO.java index c1b42b75..85908ac9 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/dto/CustomerDTO.java +++ b/src/main/java/org/hostsharing/hsadminng/service/dto/CustomerDTO.java @@ -85,6 +85,9 @@ public class CustomerDTO extends FluentBuilder implements AccessMap @AccessFor(init = Role.ADMIN, update = Role.SUPPORTER, read = Role.SUPPORTER) private String remark; + @AccessFor(init=Role.ANYBODY, update=Role.ANYBODY, read = Role.ANY_CUSTOMER_USER) + private String displayLabel; + public Long getId() { return id; } @@ -213,6 +216,14 @@ public class CustomerDTO extends FluentBuilder implements AccessMap this.remark = remark; } + public String getDisplayLabel() { + return displayLabel; + } + + public void setDisplayLabel(final String displayLabel) { + this.displayLabel = displayLabel; + } + @Override public boolean equals(Object o) { if (this == o) { diff --git a/src/main/java/org/hostsharing/hsadminng/service/dto/MembershipDTO.java b/src/main/java/org/hostsharing/hsadminng/service/dto/MembershipDTO.java index 2286a064..7efeaaba 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/dto/MembershipDTO.java +++ b/src/main/java/org/hostsharing/hsadminng/service/dto/MembershipDTO.java @@ -2,10 +2,9 @@ package org.hostsharing.hsadminng.service.dto; import org.hostsharing.hsadminng.service.CustomerService; import org.hostsharing.hsadminng.service.MembershipService; -import org.hostsharing.hsadminng.service.accessfilter.AccessFor; -import org.hostsharing.hsadminng.service.accessfilter.ParentId; -import org.hostsharing.hsadminng.service.accessfilter.Role; -import org.hostsharing.hsadminng.service.accessfilter.SelfId; +import org.hostsharing.hsadminng.service.accessfilter.*; +import org.springframework.boot.jackson.JsonComponent; +import org.springframework.context.ApplicationContext; import javax.validation.constraints.NotNull; import javax.validation.constraints.Size; @@ -16,7 +15,7 @@ import java.util.Objects; /** * A DTO for the Membership entity. */ -public class MembershipDTO extends FluentBuilder implements Serializable { +public class MembershipDTO extends FluentBuilder implements Serializable, AccessMappings { @SelfId(resolver = MembershipService.class) @AccessFor(read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) @@ -26,18 +25,18 @@ public class MembershipDTO extends FluentBuilder implements Seria @AccessFor(init = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private LocalDate admissionDocumentDate; - @AccessFor(init = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private LocalDate cancellationDocumentDate; @NotNull @AccessFor(init = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private LocalDate memberFromDate; - @AccessFor(init = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private LocalDate memberUntilDate; @Size(max = 160) - @AccessFor(init = Role.ADMIN, read = Role.SUPPORTER) + @AccessFor(init = Role.ADMIN, update = Role.ADMIN, read = Role.SUPPORTER) private String remark; @ParentId(resolver = CustomerService.class) @@ -47,6 +46,12 @@ public class MembershipDTO extends FluentBuilder implements Seria @AccessFor(init = Role.ADMIN, read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) private String customerPrefix; + @AccessFor(init = Role.ANYBODY, update = Role.ANYBODY, read = Role.FINANCIAL_CONTACT) + private String displayLabel; + + @AccessFor(init = Role.ANYBODY, update = Role.ANYBODY, read = Role.FINANCIAL_CONTACT) + private String customerDisplayLabel; + public Long getId() { return id; } @@ -111,6 +116,22 @@ public class MembershipDTO extends FluentBuilder implements Seria this.customerPrefix = customerPrefix; } + public String getDisplayLabel() { + return displayLabel; + } + + public void setDisplayLabel(final String displayLabel) { + this.displayLabel = displayLabel; + } + + public String getCustomerDisplayLabel() { + return customerDisplayLabel; + } + + public void setCustomerDisplayLabel(final String customerDisplayLabel) { + this.customerDisplayLabel = customerDisplayLabel; + } + @Override public boolean equals(Object o) { if (this == o) { @@ -145,4 +166,20 @@ public class MembershipDTO extends FluentBuilder implements Seria ", customer='" + getCustomerPrefix() + "'" + "}"; } + + @JsonComponent + public static class MembershipJsonSerializer extends JsonSerializerWithAccessFilter { + + public MembershipJsonSerializer(final ApplicationContext ctx) { + super(ctx); + } + } + + @JsonComponent + public static class MembershipJsonDeserializer extends JsonDeserializerWithAccessFilter { + + public MembershipJsonDeserializer(final ApplicationContext ctx) { + super(ctx); + } + } } diff --git a/src/main/java/org/hostsharing/hsadminng/service/dto/ShareDTO.java b/src/main/java/org/hostsharing/hsadminng/service/dto/ShareDTO.java index cb61e088..8bd1daa4 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/dto/ShareDTO.java +++ b/src/main/java/org/hostsharing/hsadminng/service/dto/ShareDTO.java @@ -48,7 +48,7 @@ public class ShareDTO implements Serializable { private Long membershipId; @AccessFor(read = {Role.CONTRACTUAL_CONTACT, Role.FINANCIAL_CONTACT}) - private String membershipDisplayReference; + private String membershipDisplayLabel; public Long getId() { return id; @@ -106,12 +106,12 @@ public class ShareDTO implements Serializable { this.membershipId = membershipId; } - public String getMembershipDisplayReference() { - return membershipDisplayReference; + public String getMembershipDisplayLabel() { + return membershipDisplayLabel; } - public void setMembershipDisplayReference(String membershipDisplayReference) { - this.membershipDisplayReference = membershipDisplayReference; + public void setMembershipDisplayLabel(String membershipDisplayLabel) { + this.membershipDisplayLabel = membershipDisplayLabel; } @Override @@ -145,7 +145,7 @@ public class ShareDTO implements Serializable { ", quantity=" + getQuantity() + ", remark='" + getRemark() + "'" + ", membership=" + getMembershipId() + - ", membership='" + getMembershipDisplayReference() + "'" + + ", membership='" + getMembershipDisplayLabel() + "'" + "}"; } } diff --git a/src/main/java/org/hostsharing/hsadminng/service/mapper/AssetMapper.java b/src/main/java/org/hostsharing/hsadminng/service/mapper/AssetMapper.java index 40399960..293d87e8 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/mapper/AssetMapper.java +++ b/src/main/java/org/hostsharing/hsadminng/service/mapper/AssetMapper.java @@ -2,8 +2,10 @@ package org.hostsharing.hsadminng.service.mapper; import org.hostsharing.hsadminng.domain.Asset; import org.hostsharing.hsadminng.service.dto.AssetDTO; +import org.mapstruct.AfterMapping; import org.mapstruct.Mapper; import org.mapstruct.Mapping; +import org.mapstruct.MappingTarget; /** * Mapper for the entity Asset and its DTO AssetDTO. @@ -12,9 +14,14 @@ import org.mapstruct.Mapping; public interface AssetMapper extends EntityMapper { @Mapping(source = "membership.id", target = "membershipId") - @Mapping(source = "membership.admissionDocumentDate", target = "membershipDisplayReference") + @Mapping(target = "membershipDisplayLabel", ignore = true) AssetDTO toDto(Asset asset); + @AfterMapping + default void setMembershipDisplayLabel(final @MappingTarget AssetDTO dto, final Asset entity) { + dto.setMembershipDisplayLabel(MembershipMapper.displayLabel(entity.getMembership())); + } + @Mapping(source = "membershipId", target = "membership") Asset toEntity(AssetDTO assetDTO); diff --git a/src/main/java/org/hostsharing/hsadminng/service/mapper/CustomerMapper.java b/src/main/java/org/hostsharing/hsadminng/service/mapper/CustomerMapper.java index 6c9c204a..ced8f394 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/mapper/CustomerMapper.java +++ b/src/main/java/org/hostsharing/hsadminng/service/mapper/CustomerMapper.java @@ -1,9 +1,11 @@ package org.hostsharing.hsadminng.service.mapper; -import org.hostsharing.hsadminng.domain.*; +import org.hostsharing.hsadminng.domain.Customer; import org.hostsharing.hsadminng.service.dto.CustomerDTO; - -import org.mapstruct.*; +import org.mapstruct.AfterMapping; +import org.mapstruct.Mapper; +import org.mapstruct.Mapping; +import org.mapstruct.MappingTarget; /** * Mapper for the entity Customer and its DTO CustomerDTO. @@ -11,6 +13,18 @@ import org.mapstruct.*; @Mapper(componentModel = "spring", uses = {}) public interface CustomerMapper extends EntityMapper { + static String displayLabel(Customer customer) { + return customer.getName() + + " [" + customer.getReference() + ":" + customer.getPrefix() +"]"; + } + + @Mapping(target = "displayLabel", ignore = true) + CustomerDTO toDto(Customer customer); + + @AfterMapping + default void setDisplayLabel(final @MappingTarget CustomerDTO dto, final Customer entity) { + dto.setDisplayLabel(displayLabel(entity)); + } @Mapping(target = "memberships", ignore = true) @Mapping(target = "sepamandates", ignore = true) diff --git a/src/main/java/org/hostsharing/hsadminng/service/mapper/MembershipMapper.java b/src/main/java/org/hostsharing/hsadminng/service/mapper/MembershipMapper.java index 02a45ace..0ae815e1 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/mapper/MembershipMapper.java +++ b/src/main/java/org/hostsharing/hsadminng/service/mapper/MembershipMapper.java @@ -1,9 +1,14 @@ package org.hostsharing.hsadminng.service.mapper; -import org.hostsharing.hsadminng.domain.*; +import org.hostsharing.hsadminng.domain.Customer; +import org.hostsharing.hsadminng.domain.Membership; import org.hostsharing.hsadminng.service.dto.MembershipDTO; +import org.mapstruct.AfterMapping; +import org.mapstruct.Mapper; +import org.mapstruct.Mapping; +import org.mapstruct.MappingTarget; -import org.mapstruct.*; +import java.util.Objects; /** * Mapper for the entity Membership and its DTO MembershipDTO. @@ -11,10 +16,27 @@ import org.mapstruct.*; @Mapper(componentModel = "spring", uses = {CustomerMapper.class}) public interface MembershipMapper extends EntityMapper { + static String displayLabel(final Membership entity) { + final Customer customer = entity.getCustomer(); + return CustomerMapper.displayLabel(customer) + " " + + Objects.toString(entity.getMemberFromDate(), "") + " - " + + Objects.toString(entity.getMemberUntilDate(), "..."); + } + @Mapping(source = "customer.id", target = "customerId") @Mapping(source = "customer.prefix", target = "customerPrefix") + @Mapping(target = "displayLabel", ignore = true) + @Mapping(target = "customerDisplayLabel", ignore = true) MembershipDTO toDto(Membership membership); + // TODO BLOG HOWTO: multi-field display reference for selection lists + // also change the filed in the option list in *-update.html + @AfterMapping + default void setMembershipDisplayLabel(final @MappingTarget MembershipDTO dto, final Membership entity) { + dto.setDisplayLabel(displayLabel(entity)); + dto.setCustomerDisplayLabel(CustomerMapper.displayLabel(entity.getCustomer())); + } + @Mapping(target = "shares", ignore = true) @Mapping(target = "assets", ignore = true) @Mapping(source = "customerId", target = "customer") diff --git a/src/main/java/org/hostsharing/hsadminng/service/mapper/ShareMapper.java b/src/main/java/org/hostsharing/hsadminng/service/mapper/ShareMapper.java index 775ca7be..80ddc52b 100644 --- a/src/main/java/org/hostsharing/hsadminng/service/mapper/ShareMapper.java +++ b/src/main/java/org/hostsharing/hsadminng/service/mapper/ShareMapper.java @@ -2,8 +2,10 @@ package org.hostsharing.hsadminng.service.mapper; import org.hostsharing.hsadminng.domain.Share; import org.hostsharing.hsadminng.service.dto.ShareDTO; +import org.mapstruct.AfterMapping; import org.mapstruct.Mapper; import org.mapstruct.Mapping; +import org.mapstruct.MappingTarget; /** * Mapper for the entity Share and its DTO ShareDTO. @@ -12,9 +14,14 @@ import org.mapstruct.Mapping; public interface ShareMapper extends EntityMapper { @Mapping(source = "membership.id", target = "membershipId") - @Mapping(source = "membership.admissionDocumentDate", target = "membershipDisplayReference") + @Mapping(target = "membershipDisplayLabel", ignore = true) ShareDTO toDto(Share share); + @AfterMapping + default void setMembershipDisplayLabel(final @MappingTarget ShareDTO dto, final Share entity) { + dto.setMembershipDisplayLabel(MembershipMapper.displayLabel(entity.getMembership())); + } + @Mapping(source = "membershipId", target = "membership") Share toEntity(ShareDTO shareDTO); diff --git a/src/main/java/org/hostsharing/hsadminng/web/rest/CustomerResource.java b/src/main/java/org/hostsharing/hsadminng/web/rest/CustomerResource.java index b5a3b74e..6e7e3a81 100644 --- a/src/main/java/org/hostsharing/hsadminng/web/rest/CustomerResource.java +++ b/src/main/java/org/hostsharing/hsadminng/web/rest/CustomerResource.java @@ -131,7 +131,7 @@ public class CustomerResource { @DeleteMapping("/customers/{id}") public ResponseEntity deleteCustomer(@PathVariable Long id) { log.debug("REST request to delete Customer : {}", id); - customerService.delete(id); - return ResponseEntity.ok().headers(HeaderUtil.createEntityDeletionAlert(ENTITY_NAME, id.toString())).build(); + // TODO mhoennig: Rather completely remove the endpoint? + throw new BadRequestAlertException("Customres can't be deleted", ENTITY_NAME, "customerNotDeletable"); } } diff --git a/src/main/java/org/hostsharing/hsadminng/web/rest/MembershipResource.java b/src/main/java/org/hostsharing/hsadminng/web/rest/MembershipResource.java index befa075f..795cd59e 100644 --- a/src/main/java/org/hostsharing/hsadminng/web/rest/MembershipResource.java +++ b/src/main/java/org/hostsharing/hsadminng/web/rest/MembershipResource.java @@ -1,25 +1,24 @@ package org.hostsharing.hsadminng.web.rest; + +import io.github.jhipster.web.util.ResponseUtil; +import org.hostsharing.hsadminng.service.MembershipQueryService; import org.hostsharing.hsadminng.service.MembershipService; +import org.hostsharing.hsadminng.service.dto.MembershipCriteria; +import org.hostsharing.hsadminng.service.dto.MembershipDTO; import org.hostsharing.hsadminng.web.rest.errors.BadRequestAlertException; import org.hostsharing.hsadminng.web.rest.util.HeaderUtil; import org.hostsharing.hsadminng.web.rest.util.PaginationUtil; -import org.hostsharing.hsadminng.service.dto.MembershipDTO; -import org.hostsharing.hsadminng.service.dto.MembershipCriteria; -import org.hostsharing.hsadminng.service.MembershipQueryService; -import io.github.jhipster.web.util.ResponseUtil; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import org.springframework.data.domain.Page; import org.springframework.data.domain.Pageable; import org.springframework.http.HttpHeaders; -import org.springframework.http.HttpStatus; import org.springframework.http.ResponseEntity; import org.springframework.web.bind.annotation.*; import javax.validation.Valid; import java.net.URI; import java.net.URISyntaxException; - import java.util.List; import java.util.Optional; @@ -132,7 +131,7 @@ public class MembershipResource { @DeleteMapping("/memberships/{id}") public ResponseEntity deleteMembership(@PathVariable Long id) { log.debug("REST request to delete Membership : {}", id); - membershipService.delete(id); - return ResponseEntity.ok().headers(HeaderUtil.createEntityDeletionAlert(ENTITY_NAME, id.toString())).build(); + // TODO mhoennig: Rather completely remove the endpoint? + throw new BadRequestAlertException("Memberships can't be deleted", ENTITY_NAME, "membershipNotDeletable"); } } diff --git a/src/main/resources/config/application-dev.yml b/src/main/resources/config/application-dev.yml index 502ea108..8e53af01 100644 --- a/src/main/resources/config/application-dev.yml +++ b/src/main/resources/config/application-dev.yml @@ -37,7 +37,10 @@ spring: indent-output: true datasource: type: com.zaxxer.hikari.HikariDataSource + # H2 in memory: url: jdbc:h2:mem:hsadminng;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE + # H2 in file: + # url: jdbc:h2:~/.hsadminng.h2db;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE username: hsadminNg password: hikari: diff --git a/src/main/resources/logback-spring.xml b/src/main/resources/logback-spring.xml index 0b9cc1fd..2d182c88 100644 --- a/src/main/resources/logback-spring.xml +++ b/src/main/resources/logback-spring.xml @@ -26,6 +26,7 @@ --> + diff --git a/src/main/webapp/app/entities/asset/asset-detail.component.html b/src/main/webapp/app/entities/asset/asset-detail.component.html index d31955d3..d092b737 100644 --- a/src/main/webapp/app/entities/asset/asset-detail.component.html +++ b/src/main/webapp/app/entities/asset/asset-detail.component.html @@ -1,7 +1,7 @@
-

Asset {{asset.id}}

+

Asset: #{{asset.id}} - {{asset.membershipDisplayLabel}}


@@ -28,7 +28,7 @@
Membership
diff --git a/src/main/webapp/app/entities/asset/asset-update.component.html b/src/main/webapp/app/entities/asset/asset-update.component.html index 3b3a5c43..951db0b4 100644 --- a/src/main/webapp/app/entities/asset/asset-update.component.html +++ b/src/main/webapp/app/entities/asset/asset-update.component.html @@ -89,7 +89,7 @@
diff --git a/src/main/webapp/app/entities/asset/asset.component.html b/src/main/webapp/app/entities/asset/asset.component.html index 29ac04a6..8472107d 100644 --- a/src/main/webapp/app/entities/asset/asset.component.html +++ b/src/main/webapp/app/entities/asset/asset.component.html @@ -19,8 +19,7 @@ Value Date Action Amount - Remark - Membership + Membership @@ -31,10 +30,9 @@ {{asset.valueDate | date:'mediumDate'}} {{asset.action}} {{asset.amount}} - {{asset.remark}} diff --git a/src/main/webapp/app/entities/customer/customer-detail.component.html b/src/main/webapp/app/entities/customer/customer-detail.component.html index 93c22ade..3a74ce9e 100644 --- a/src/main/webapp/app/entities/customer/customer-detail.component.html +++ b/src/main/webapp/app/entities/customer/customer-detail.component.html @@ -1,7 +1,7 @@
-

Customer {{customer.id}}

+

Customer: {{customer.displayLabel}}


diff --git a/src/main/webapp/app/entities/customer/customer.component.html b/src/main/webapp/app/entities/customer/customer.component.html index afb4fb12..c655cc04 100644 --- a/src/main/webapp/app/entities/customer/customer.component.html +++ b/src/main/webapp/app/entities/customer/customer.component.html @@ -18,18 +18,7 @@ Reference Prefix Name - Kind - Birth Date - Birth Place - Registration Court - Registration Number - Vat Region - Vat Number - Contractual Salutation - Contractual Address - Billing Salutation - Billing Address - Remark + Kind @@ -40,17 +29,6 @@ {{customer.prefix}} {{customer.name}} {{customer.kind}} - {{customer.birthDate | date:'mediumDate'}} - {{customer.birthPlace}} - {{customer.registrationCourt}} - {{customer.registrationNumber}} - {{customer.vatRegion}} - {{customer.vatNumber}} - {{customer.contractualSalutation}} - {{customer.contractualAddress}} - {{customer.billingSalutation}} - {{customer.billingAddress}} - {{customer.remark}}